Item Trigger

[BloodDrunk]

Ola

• Eoric Staff
  • Events
    • Game - damageEventTrigger becomes Equal to 1.00
  • Conditions
    • damageType Equal to 0
    • (source is A Hero) Equal to True
    • (source is an illusion) Equal to False
    • (source has an item of type |cFFFFFF00Eoric Staff) Equal to True
  • Actions
    • Set TempPoint = (Position of target)
    • Set EoricStaff_UnitGroup = (Units within 350.00 of TempPoint matching ((((Matching unit) is A structure) Equal to False) and (((Matching unit) belongs to an enemy of (Owner of source)) Equal to True)))
    • Unit Group - Pick every unit in EoricStaff_UnitGroup and do (Actions)
      • Loop - Actions
        • Unit - Cause source to damage (Picked unit), dealing 4000.00 damage of attack type Spells and damage type Normal
    • Custom script: call RemoveLocation(udg_TempPoint)
    • Custom script: call DestroyGroup(udg_EoricStaff_UnitGroup)

I was having a conversation with looking_for_help (pm) about this trigger and he said this action:

• Unit - Cause source to damage (Picked unit), dealing 4000.00 damage of attack type Spells and damage type Normal

could make infinite trigger looping. He gave me a custom script (I dont have it anymore) for damaging so it doesn't reactivates the trigger.

Could this infinite looping cause crash?

 

[GreeN!X]

Yes. Infinite loops causes the game to crash. If it was me, I would turn off the trigger before applying the damage, then turn it on again after the damage by the trigger is applied so that the damage applied by the trigger will not trigger the trigger itself.

 

[BloodDrunk]

like this?

• Eoric Staff
  • Events
    • Game - damageEventTrigger becomes Equal to 1.00
  • Conditions
    • damageType Equal to 0
    • (source is A Hero) Equal to True
    • (source is an illusion) Equal to False
    • (source has an item of type |cFFFFFF00Eoric Staff) Equal to True
  • Actions
    • Trigger - Turn off (This trigger)
    • Set TempPoint = (Position of target)
    • Set EoricStaff_UnitGroup = (Units within 350.00 of TempPoint matching ((((Matching unit) is A structure) Equal to False) and (((Matching unit) belongs to an enemy of (Owner of source)) Equal to True)))
    • Unit Group - Pick every unit in EoricStaff_UnitGroup and do (Actions)
      • Loop - Actions
        • Unit - Cause source to damage (Picked unit), dealing 4000.00 damage of attack type Spells and damage type Normal
    • Custom script: call RemoveLocation(udg_TempPoint)
    • Custom script: call DestroyGroup(udg_EoricStaff_UnitGroup)
    • Trigger - Turn on (This trigger)

 

[GreeN!X]

Yep. :3

 

[BloodDrunk]

so, it's won't infinite loop anymore. Are you sure or you think it could bug up?
I really struggle with crash fix on my map...

 

[GreeN!X]

I'm pretty sure it won't bug up. but I could try it myself first if you want. Just to be sure. you're using looking_for_help's DDS right?

 

[BloodDrunk]

I'm pretty sure it won't bug up. but I could try it myself first if you want. Just to be sure. you're using looking_for_help's DDS right?

yes, his. But heroes have kinda fast attack speed and there are more heroes with same item. That's why I'm asking could it bug up to turn on/off rapidly :O

 

[GreeN!X]

Well, it works on about 300 paladins using the same item so i guess it won't bug up. X3

 

[BloodDrunk]

Well, it works on about 300 paladins using the same item so i guess it won't bug up. X3

Good then, hope it won't crash again...

 

[deathismyfriend]

it wont bug up with the turn on / off because it is instant. if it had a wait or a timer then yes it would bug up.

 

[BloodDrunk]

it wont bug up with the turn on / off because it is instant. if it had a wait or a timer then yes it would bug up.

good, good

 

[deathismyfriend]

good, good

yup lol