[Trigger] Item quest help

[hapykiller999999]

Ok so i got warcraft 3 frozen throne and i need help with item quest, so when i get 4 items quest need to be completed, but i cannot do that
Here is what i done:

• Shimering portal part 2 completition
  • Events
    • Unit - A unit Acquires an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to Shimering portal parts
  • Actions
    • Set ShimeringPortalParts[(Player number of (Owner of (Item being manipulated)))] = ((Player number of (Owner of (Item being manipulated))) + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ShimeringPortalParts[(Player number of (Owner of (Item being manipulated)))] Equal to 4
      • Then - Actions
        • Quest - Display to (All players) the Quest Update message: |cff995500(Part 2 o...
        • Quest - Mark ShimeringPortalQuest[2] as Completed
        • Player - Add 3 to (Matching player) Current lumber
        • Hero - Add 20 experience to (Triggering unit), Show level-up graphics
      • Else - Actions
        • Do nothing

 

[Bribe]

• Do nothing

is only needed for if/then/else single action. It's wasteful to place it on an if/then/else multiple actions.

(Player number of (Owner of (Item being manipulated)))

This can be shortened to:

(Player number of (Triggering Player))

You can use "Triggering Player" for "generic unit event" almost every time to retrieve the player who owns the Triggering Unit.

• Set ShimeringPortalParts[(Player number of (Owner of (Item being manipulated)))] = ((Player number of (Owner of (Item being manipulated))) + 1)

This needs to be:

• Set ShimeringPortalParts[(Player number of (Triggering Player))] = ShimeringPortalParts[(Player number of (Triggering Player))] + 1

You weren't adding "Shimmering Portal Parts" by itself, causing the main problem.

• Player - Add 3 to (Matching player) Current lumber

"Matching Player" is not valid here, causing another problem. You need to use Triggering Player.

 

[hapykiller999999]

• Do nothing

is only needed for if/then/else single action. It's wasteful to place it on an if/then/else multiple actions.

(Player number of (Owner of (Item being manipulated)))

This can be shortened to:

(Player number of (Triggering Player))

You can use "Triggering Player" for "generic unit event" almost every time to retrieve the player who owns the Triggering Unit.

• Set ShimeringPortalParts[(Player number of (Owner of (Item being manipulated)))] = ((Player number of (Owner of (Item being manipulated))) + 1)

This needs to be:

• Set ShimeringPortalParts[(Player number of (Triggering Player))] = ShimeringPortalParts[(Player number of (Triggering Player))] + 1

You weren't adding "Shimmering Portal Parts" by itself, causing the main problem.

• Player - Add 3 to (Matching player) Current lumber

"Matching Player" is not valid here, causing another problem. You need to use Triggering Player.

Thank you very much for your reply, ill check it out now!

 

[hapykiller999999]

Nope not working here is my trigger you said to be fixed, i got all 4 items in my inventory but it does not say quest completed.

• Shimering portal part 2 completition
  • Events
    • Unit - A unit Acquires an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to Shimering portal parts
  • Actions
    • Set ShimeringPortalParts[(Player number of (Triggering player))] = ((Player number of (Triggering player)) + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ShimeringPortalParts[(Player number of (Owner of (Item being manipulated)))] Equal to 4
      • Then - Actions
        • Quest - Display to (All players) the Quest Update message: |cff995500(Part 2 o...
        • Quest - Mark ShimeringPortalQuest[2] as Completed
        • Player - Add 3 to (Triggering player) Current lumber
        • Hero - Add 20 experience to (Triggering unit), Show level-up graphics
      • Else - Actions
        • Trigger - Turn off (This trigger)

 

[Bribe]

• Set ShimeringPortalParts[(Player number of (Triggering player))] = ((Player number of (Triggering player)) + 1)

You still didn't fix this. It needs to be:

• Set ShimeringPortalParts[(Player number of (Triggering player))] = ShimeringPortalParts[((Player number of (Triggering player)))]+1

 

[hapykiller999999]

Oh dear i don't know how to do it, here is screenshot i cannot find shimeringportalparts to be on first place like here

• Set ShimeringPortalParts[(Player number of (Triggering player))] = ShimeringPortalParts[((Player number of (Triggering player)))]+1

 

[Bribe]

You need to select:

1. Math
2. Arithmatic
3. first box: ShimmeringPortalParts[PlayerNumber of TriggeringPlayer]
4. delimeter: Plus-sign
5. second box: 1.

Seriously this would be way logical in JASS because you only have to type it instead of select through that ridiculous tree.

set udg_ShimeringPortalParts[GetPlayerId(GetTriggerPlayer())] = udg_ShimeringPortalParts[GetPlayerId(GetTriggerPlayer())] + 1

 

[hapykiller999999]

• Shimering portal part 2 completition
  • Events
    • Unit - A unit Acquires an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to Shimering portal parts
  • Actions
    • Custom script: set udg_ShimeringPortalParts[GetPlayerId(GetTriggerPlayer())] = udg_ShimeringPortalParts[GetPlayerId(GetTriggerPlayer())] + 1
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ShimeringPortalParts[(Player number of (Owner of (Item being manipulated)))] Equal to 4
      • Then - Actions
        • Quest - Display to (All players) the Quest Update message: |cff995500(Part 2 o...
        • Quest - Mark ShimeringPortalQuest[2] as Completed
        • Player - Add 3 to (Triggering player) Current lumber
        • Hero - Add 20 experience to (Triggering unit), Show level-up graphics
      • Else - Actions
        • Trigger - Turn off (This trigger)

Done?But When you told me first math, there wasnt just math, it was MMath-.., with what math to select please tell.

 

[Bribe]

Wow, you actually used the custom script that I gave you. I wouldn't have guessed you knew how to input JASS better than you knew clicking through that annoying gooey tree.

The JASS actually had a catch that conflicts with your other GUI, so to fix:

set udg_ShimeringPortalParts[GetPlayerId(GetTriggerPlayer())+1] = udg_ShimeringPortalParts[GetPlayerId(GetTriggerPlayer())+1]+1

The second "math" you would need to click is called "Arithmatic", like it says in step 2. I'm not going to check to see if I'm wrong on that becuase I refuse to labor with that disgusting box-tree GUI.

 

[hapykiller999999]

Wow, you actually used the custom script that I gave you. I wouldn't have guessed you knew how to input JASS better than you knew clicking through that annoying gooey tree.

The JASS actually had a catch that conflicts with your other GUI, so to fix:

set udg_ShimeringPortalParts[GetPlayerId(GetTriggerPlayer())+1] = udg_ShimeringPortalParts[GetPlayerId(GetTriggerPlayer())+1]+1

The second "math" you would need to click is called "Arithmatic", like it says in step 2. I'm not going to check to see if I'm wrong on that becuase I refuse to labor with that disgusting box-tree GUI.

• Shimering portal part 2 completition
  • Events
    • Unit - A unit Acquires an item
  • Conditions
    • (Item-type of (Item being manipulated)) Equal to Shimering portal parts
  • Actions
    • Custom script: set udg_ShimeringPortalParts[GetPlayerId(GetTriggerPlayer())+1] = udg_ShimeringPortalParts[GetPlayerId(GetTriggerPlayer())+1]+1
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ShimeringPortalParts[(Player number of (Owner of (Item being manipulated)))] Equal to 4
      • Then - Actions
        • Quest - Display to (All players) the Quest Update message: |cff995500(Part 2 o...
        • Quest - Mark ShimeringPortalQuest[2] as Completed
        • Player - Add 3 to (Triggering player) Current lumber
        • Hero - Add 20 experience to (Triggering unit), Show level-up graphics
      • Else - Actions
        • Trigger - Turn off (This trigger)

Ok that is my trigger i will see if it is working and report you back, since i am still learning C++ and i don't know anything, just not yet started, i have to know if i change to another item,, so i should change name in that cusom script insted of ShimeringPortalParts?

 

[hapykiller999999]

Nope, not working does not say completed :O.By the way, the number near quest variable is an arry, is that good?

 

[Bribe]

• Trigger - Turn off (This trigger)

Seriously?

Remove that XD of course you're having trouble! You don't need anything to be in the "Else" actions, it should just be blank.

 

[hapykiller999999]

Not worknig, by the way if you are worried how item is called, it is called Shimering portal parts

 

[hapykiller999999]

Here is the map you check it please.

 

[Bribe]

• Custom script: call BJDebugMsg("working")

Add that to the beginning of your trigger. Tell me if you see it or not. Even better, send me the map so I can check it more thoroughly.

 

[hapykiller999999]

There is attachment, above your post, please fix it with not custom scripts, i want it with only normal blizzard trigger tree, thank you, more rep for you.

 

[Bribe]

OK, your problem is "owner of item being manipulated". That doesn't return the correct player

Replace that with "Triggering Player"

I'll send you the map that uses 100% gooey, so you can see what needs to happen with the math-arithmetic box stuff.

 

[Bribe]

Attached is the map of it working. Delete the 5 items that I added

 

[hapykiller999999]

You rock bro thank you so much, you saved my life in wc3 lol .REP GAINED!