[JASS] Is this JASS script written correctly?

[numb]

I was just wondering if this JASS script is written correctly because when i save the map, it says that there is an error and it wont enable the trigger.

function Trig_Summon_Rifle_Conditions takes nothing returns boolean
    if ( not ( GetResearched() == 'R007' ) ) then
        return false
    endif
    return true
endfunction

function Trig_Summon_Rifle_Actions takes nothing returns nothing
    call EnableTrigger( gg_trg_Bring_Rifle )
endfunction

//===========================================================================
function InitTrig_Summon_Rifle takes nothing returns nothing
    set gg_trg_Summon_Rifle = CreateTrigger(  )
    call TriggerRegisterUnitEvent( gg_trg_Summon_Rifle, gg_unit_hbla_0023, EVENT_UNIT_RESEARCH_FINISH )
    call TriggerAddCondition( gg_trg_Summon_Rifle, Condition( function Trig_Summon_Rifle_Conditions ) )
    call TriggerAddAction( gg_trg_Summon_Rifle, function Trig_Summon_Rifle_Actions )
endfunction

Thankyou


numb[/code]

 

[Daelin]

Blah, global triggers. Anyway:

GetResearched() - Where is this function? You access it but I don't see it.

What I see here is an extremely bad GUI -> JASS conversion, in which you just edited the first function. You really should check my tutorial.

~Daelin

 

[numb]

alright, thanks