Is there something wrong with this trigger?

[kewlthis]

It works perfectly, but It gives lagg if I spam it. The lag ocurs after i spam the spell with like 20 times and cast the spell again. The lagg is ONLY when i cast the spell again (first few spells doesnt lagg at all). I spam the spell with 0 cooldown to see how it works.

The trigger might look a bit messy since i mix locals and no variables with groups, but it should be fine if it doesnt leak?

And any ideas what could cause the lagg? Something doesnt get destroyed properly maybe?

Ok here is the triggers:

*EDIT* Changed some stuff, it should work better now, but it still causes the lagg....

 

[Dr Super Good]

By the looks of it, it could be caused by the dummy unit decaying.

Try waiting a few minutes to see if the lag goes away.

Additionally the garbage collector might run every few minutes, thus it may leak temporarrilly.

 

[mrzwach]

Try removing the dummy unit as opposed to killing it.

 

[kewlthis]

Neither worked....

This really sux, I dont want to make more spells while I cant get this working properly (the lagg issue).

I tried removing the units and waiting, but the lagg always comes when I cast the spell.

What makes it weird, why does it only lagg when i cast the spell again...this kind of thing never happened with wc3 editori .

I dont know if I should try to make spells another way, like using effects search function...it could be usefull, but im not too familiar with data editor yet.


*edit* Oh and im really stuck with this...I dont know what I could do to spot the problem. I checked using text display that units gets removed from groups...So if you go any ideas, im happy to test them. The problem also isnt related to last part of trigger where I add buff and actor, since the lagg starts even if I dont hit enemy units...

 

[TwentyThree]

1) How does the trigger start? theres obviously a trigger that turns i on.
2) Im not smart, but think it could be the .003 and the making a unit/dummy/actor/buff that spams that kind of thing..

Try running it without the .003 event, just make the trigger run without any periodic event, it could be lagging because of it.. I know i would stay away from that kind of thing

 

[kewlthis]

1) How does the trigger start? theres obviously a trigger that turns i on.
2) Im not smart, but think it could be the .003 and the making a unit/dummy/actor/buff that spams that kind of thing..

Try running it without the .003 event, just make the trigger run without any periodic event, it could be lagging because of it.. I know i would stay away from that kind of thing

In wc3 I had no problems with periodic events. And Im quite sure the periodic trigger is where the problems is...but it could be true that too much spam is too much...

Anyway here is the starting trigger in case it helps someone....

 

[Dr Super Good]

Are you sure you are not leaking actors due to incorrect actor event setup?

 

[kewlthis]

Are you sure you are not leaking actors due to incorrect actor event setup?

What do you mean? In the periodic trigger even if I remove the actor adding part it still causes the lagg...

Is there some other way my actors could leak? I dont see where I could use them wrong. Or maybe the model actor on the dummy unit could be set wrong...But I dont really know anything about actors...

 

[Dr Super Good]

It could be the dummy unit does not detroy its actor on death. This results in an actor leak.

How much memory you got? It could be that even with the deleaking stuff you do not have enough.

 

[kewlthis]

I got 4gigs of memory. That actor destroying sounds interesting...I think i will have to look from other models if there is a difference...As I said I dont really know anything about actors so dunno what to look....

*edit* I tried using normal unit instead of dummy unit. Still causes the lagg after spamming the spell......I quess im at a dead end now, dunno should i try something else. Or maybe even give up mapping if I cannot get simple spell like this to work...or my pc cant handle it or whatever :<.

Another Idea is that something just leaks in the periodic trigger...I dont know what and I dont know how should I find it, since I got no idea how the garbage system works...PFF

"8. Will there be improvements on the "Garbage Collector" for the new language? For example, in JASS all local variables need to be set to null at the end of their use, and certain data-types need to be removed from the game (such as Locations) at the end of their use to avoid memory leaks.
Galaxy features a robust garbage collection system for all native types, which is a huge improvement over WarCraft III (which technically did not have a garbage collection system at all). The script memory leak issues from WarCraft III will be a thing of the past. "

So can I even make leaks? FFS AFFGEhgaweh

 

[Darkness-4ever]

Try uploading your map and have others take a look at it, visualizing how it would look and understanding its relation with the data editor and other triggers is difficult to visualize with just the periodic trigger showing.

 

[mrzwach]

Does the lag persist long after whatever dummy unit is destroyed?

Also, does the dummy unit have like a timed life or so? Otherwise, it could continue moving on indefinitely.

Just try using the spell 20 times at moderate intervals, and see if it lags AFTER that.

If you still have trouble, upload the map or something so we can look at it.

 

[kewlthis]

I quess uploading is best sollution. There is some unnececary stuff there so it might be messy....But its just testing learning map for me....

Indeed dummy has timed life buff. Should it be removed too after it dies or what?

If you spam it like 50 times, you should see it lagging

 

[AionCannonzSC2]

why dont you use action definitions with threads instead of the periodic event

 

[kewlthis]

why dont you use action definitions with threads instead of the periodic event

What are those? .......Never head of them :/

and plz explain how to use them....

 

[AionCannonzSC2]

this video introduces action definitions in the context of a triggered projectile

http://www.youtube.com/user/GalaxyEditorTutorial#p/u/53/Om6hlErVTVw

 

[kewlthis]

Im going to try and test action definition system and compare how much better that works...

Anyway anyone tested the map? I do not know does it lagg if you dont spam it, but Im still concerned that when you make a map it might cause leaks because too much effects or so....

 

[kewlthis]

Just wanted you to know that action definition is definnetly the way to go. Its pretty simple to use and that tutorial really helped a lot in geting to know action definitions (Atleast the map and triggers that you could dl from tube description).

I spammed the same spell like 100+ times and no lagg with action definition...I quess I could have made my periodic trigger the same way too (using units movement instead of moving the unit), that seems to lessen the actions/lagg greatly.

Well thanks for everyone in helping. Ill give you some +rep. And I can start mapping again with this.