Is it safe..

[Maximilianx]

to localize a special effect? or would this cause desyncs?
example:

if GetLocalPlayer() == Player(i) then
    call AddSpecialEffect("Special//effect//name", x, y)
endif

thanks in advance.

 

[TriggerHappy]

It's not safe.

local string s = ""
if GetLocalPlayer() == Player(i) then
    set s = "Special//effect//name"
endif
call AddSpecialEffect(s, x, y)

EDIT: @Komaqtion, I updated my post before you made yours. I remembered after I posted.

 

[Maximilianx]

Awesome, thanks.

 

[Komaqtion]

No !!
Are you kidding me, TriggerHappy ? :S

local string s = "Special//effect//name"

if GetLocalPlayer() != Player(i) then
    set s = ""
endif
call AddSpecialEffect(s, x, y)

That's safe

 

[Maximilianx]

ah, nifty trick thanks a lot guys.

 

[meOme]

Komaqtion, your Trigger does exactly the same as TriggerHappy's.

Or am I stupid?

 

[Komaqtion]

Well, it does basically the same, though mine will not desync...

 

[Justify]

It doesn't.
The one kills the string to nothing, the other creates a string out of nothing.
I heard once that TriggerHappys version is the correct one, but some people
tried it before some days and only the one from Koma didn't desync.
Ask blizzards stringtables why D: