[Solved] Is it safe to do this?

[Alain.Mark]

Hey guys is it safe to do this (i mean the subtraction part)

 function MEEP takes handle H, string Label, integer Data returns nothing
    call SaveInteger(MEEP,GetHandleId(H)-8191,StringHash(Label)-8191,Data)
 endfunction

my reason for subtracting 8191 is to save some space in the game.

 

[mckill2009]

I dunu, but remove the StringHash string...do like this...

function MEEP takes handle H, integer Label, integer Data returns nothing
   call SaveInteger(MEEP, GetHandleId(H), Label, Data)
endfunction

 

[Berb]

to save some space in the game.

Why not do GetHandleId(H) - GetHandleId(null) instead of 8191? The number produced by GetHandleId(H) is far larger than 8191. I think it's either 0x100000 or 0x10008.

Either way, you're not really speeding anything up by reducing that number. Hash-tables don't work like arrays, their indexes are not directly representative of how much memory you'll need to store that.

You don't necessarily have to remove the StringHash part; depends how you want to interface it.

 

[axleion]

I dunu, but remove the StringHash string...do like this...

function MEEP takes handle H, integer Label, integer Data returns nothing
   call SaveInteger(MEEP, GetHandleId(H), Label, Data)
endfunction

i think he might want to recreate the local handle vars interface, so it's fine for him.

 

[Garfield1337]

I dunu, but remove the StringHash string...do like this...

function MEEP takes handle H, integer Label, integer Data returns nothing
   call SaveInteger(MEEP, GetHandleId(H), Label, Data)
endfunction

That wouldn't work, keys are integers, not strings. (Label is a string so it will show a compile error)

 

[mckill2009]

That wouldn't work, keys are integers, not strings. (Label is a string so it will show a compile error)

as you can see, I changed it to "integer Label" ...I already tested it and it worked

 

[Garfield1337]

as you can see, I changed it to "integer Label" ...I already tested it and it worked

Oh, didn't see it. Sorry.

 

[Adiktuz]

I don't see the point in subtracting 8191... but anyways, it should work...

 

[Alain.Mark]

Solved! Thank you for your help guys!

 

[Bribe]

Trying to shrink values to store them into a hash table is a waste of time unless the value is somehow beyond 2^31 − 1 (which no native integer in JASS should be, whether it be rawcode or handle id).

The only excuse to "hash" stringhash is if you need to store it into an array, and the ASCII library does that quite well: http://www.hiveworkshop.com/forums/jass-functions-413/snippet-ascii-190746/

 

[Berb]

unless the value is somehow beyond 2^31 − 1

Yes that seems to be the largest integer value possible in JASS. This is one of those things that JASS doesn't seem to handle very well though.