Infernal Cyclone v. 1.3.2.0

[T. D. W.]

Update

Changelogs Release Trigger Optimization Trigger Optimization Bug Fix Attack Type and Damage Type are now configurable Many Trigger Optimization Small Changes in the Spell's configs Updated to KB3D v. 1.6.0 with iKB Updated with KB3D v. 1.6.X, used the new features like targets allowed Small Trigger Changes Trigger Fixes Bug Fixes

Note that i didn't understand the blizzard tooltip part all other notices were fixed

 

[Maker]

Like this

Ability [Q] - Level 1

Text here yada yada and more explanation
Omg this spell is kewl

Level 1 - x damage, y second stun
Level 2 - z damage, w second stun
Level 3 - # damage, ö second stun

 

[T. D. W.]

Oh, okay, tomorrow, cuz you moderated it right before i go to bed... Any way so it can be approved now :3?

 

[chobibo]

What does this do?

jass

function iPreload takes string s returns nothing
    local string S = ""
    local integer x = 0
    loop
        exitwhen (x >= StringLength(s))
        set x = x + 1
        if (SubString(s, x-1,x) == "\\") then
            set S = S + "\\" + "\\"
        else
            set S = S + SubString(s, x-1,x)
        endif
    endloop
    call Preload(S)
endfunction

 

[Malhorne]

I don't really now I have to admit that use the common Preload thingy but that's a long time I didn't see the preload subject ^^'

 

[T. D. W.]

This function transforms any model path into jass path ( \ becomes \\ ) to preload them
So with this function we don't need users to preload themselves their changed effects

 

[Maker]

Use this for preloading

Game - Preload IC_Fx3

 

[chobibo]

I don't get why that is needed, wouldn't GUI already convert that properly for you?

• String WTF
  • Events
  • Conditions
  • Actions
    • Set str = Abilities\YadaYada\MoreYadaYada\YadaDoey.mdl

converted:

function Trig_String_WTF_Actions takes nothing returns nothing
    set udg_str = "Abilities\\YadaYada\\MoreYadaYada\\YadaDoey.mdl"
endfunction

//===========================================================================
function InitTrig_String_WTF takes nothing returns nothing
    set gg_trg_String_WTF = CreateTrigger(  )
    call TriggerAddAction( gg_trg_String_WTF, function Trig_String_WTF_Actions )
endfunction

 

[Malhorne]

Yes it changes already ^^'
So Jad I think it is a fail

 

[T. D. W.]

I just noticed that with maker
Anyways, it took me 5 mins to do this, it isn't like the whole spell is a fail
Tomorrow then too

 

[Malhorne]

Never said the spell is fail
It's good

 

[T. D. W.]

I know i know, i didn't say someone said the spell was a fail xD

 

[FUJI]

^ I thought the preload thing will be implemented at Knockback System?

 

[T. D. W.]

Why in te Knockback? It's useless to preload it in the KB, it should be preloaded at the start of the map...

 

[T. D. W.]

Update

Changelogs Release Trigger Optimization Trigger Optimization Bug Fix Attack Type and Damage Type are now configurable Many Trigger Optimization Small Changes in the Spell's configs Updated to KB3D v. 1.6.0 with iKB Updated with KB3D v. 1.6.X, used the new features like targets allowed Small Trigger Changes Trigger Fixes Bug Fixes Trigger Changes (Preloading) Tooltip Changed

 

[FUJI]

Infernal Cyclone v1.2.2.0
This spell had been reviewed by jakeZinc.

if LoadBoolean(udg_IC_HA, i, 4) then
    set T = LoadReal(udg_IC_HA, i, 1)
    call SaveReal(udg_IC_HA, i, 1, T - 0.03125)
    if T <= 0.03125 then

endif
endif

Please fix the indentation in here so that it will increase the readability of the code. Indentation is four spaces in JASS and every block is required
to be indented, with the rare exception of indenting the contents of
an all-encompassing library or scope because it's usually obvious
then. References: JPAG in this link you can read the proper convention names of the functions variables etc. set u1 = CreateUnit(GetTriggerPlayer(), udg_IC_Dummy, x, y, 0) store the GetTriggerPlayer() to the hashtable so that you won't use the GetOwningPlayer(U1) and I see there that you used that two times. The trigger is looks ok right now and it does not have any issues about it.

• -------- Z offest reached by the looping Missiles --------

you have a mistake here lol, the documentation must be explained not juts only like this:

• -------- DPS dealt by the Looping Missiles --------

because some of them might not understand what DPS means and they'll ask what is looping missile? the shard or the etc.? The documentation in the configuration trigger is hard to read maybe seperate them by a clear comments to increase the readability of the spell ^^.

set udg_KB3D_DestroyTree = true Destroying trees must be enabled in configurability of the spell because what if some users don't want to destroy trees if they use this spell so that you must add it ^^. I think that is the only left in the configuration and you make it all configurability values.

MUI and leakless spell. Fun to cast, It has a swag and beautiful eye candy effects like the cyclone event that the missile spins to the target location but it seems like from the Melting Phoenixes ^^.

It does lag in execution of the spell and when casted two times which doesn't really good .

// -Check that Create Unknown variables is checked in your WE preferences// You must tell them that preferences can be found at File --> Preferences --> General because this is lacking of information. Also the import, you must tell them that it is from the F12 Import manager but I think there's not a problem with that ^^. That's all I can say and it has an importing instruction.

It is really nice that you add a spinning effects, knockback effects, explosion and blast of the shards. Maybe reducing some effects or objects because this effects can drop my FPS below. It has a beautiful effects and good looking!.The effect looks great and the movement of the fire is well done

Useful in reducing outnumbered armies!: Flying units and ground units can be destroyed in the spell which can show it's usefulness ^^.

Reduce some effects of the spell so that lags will not show up. Decrease the spell damage because it is Imbalanced that's why the Knockback Event has only a 40% chance to execute the knockback. Other than that none.

The tooltip supports every level of the spell. It does follow the blizzard standard tooltip ^^.

Rejected: 1-10
Unacceptable : 11-30
Lacking : 31-49
Useful : 50-69
Recommended : 70-90
Highly Recommended : 91-100
Director Cut : 101-105

1) Triggering - 17/20
2) Documentation - 7/10
3) Importing Instruction - 6/10
4) Special Effects - 14/15
5) Usefulness - 17/20
6) Tooltip - 8/10
7) Configuration - 8/10

Total Score - 77/105
jakeZinc Rating - 3.7/5
Status - Recommended

The rating will be higher if you reduce the lag of the spell and balanced it.

 

[T. D. W.]

Well, finally lol , thanks for the review

 

[T. D. W.]

Update

Changelogs Release Trigger Optimization Trigger Optimization Bug Fix Attack Type and Damage Type are now configurable Many Trigger Optimization Small Changes in the Spell's configs Updated to KB3D v. 1.6.0 with iKB Updated with KB3D v. 1.6.X, used the new features like targets allowed Small Trigger Changes Trigger Fixes Bug Fixes Trigger Changes (Preloading) Tooltip Changed Updated to KB3D v. 1.7.0 Icon Changed Balanced Better Instructions/Documentation Possibility to configure iKB (damaging and KBing) Possibility to configure Destroy Tree Better Code

 

[FUJI]

I'll review it later because I'm on mobile right now xD

 

[T. D. W.]

XD okay

 

[FUJI]

It is now approve so no need to review it lol xD.

 

[T. D. W.]

XD then Rate it !

 

[FUJI]

^ rate submitted lol .

 

[Malhorne]

local integer i = 0

I told you once to initiate your locals after the condition.
Otherwise every time a spell is casted you allocate the place for local and you initiate :/
No need to initiate if the spell isn't the one casted.

set U = null
set u1 = null

Put this inside the if block.
Because when they are created locals got no value.

 

[T. D. W.]

okay, you gave me a reason for updating this

 

[Malhorne]

Ahah no problem

 

[T. D. W.]

Update

Changelogs Release Trigger Optimization Trigger Optimization Bug Fix Attack Type and Damage Type are now configurable Many Trigger Optimization Small Changes in the Spell's configs Updated to KB3D v. 1.6.0 with iKB Updated with KB3D v. 1.6.X, used the new features like targets allowed Small Trigger Changes Trigger Fixes Bug Fixes Trigger Changes (Preloading) Tooltip Changed Updated to KB3D v. 1.7.0 Icon Changed Balanced Better Instructions/Documentation Possibility to configure iKB (damaging and KBing) Possibility to configure Destroy Tree Better Code Updated to KB3D v. 1.7.1 Spell Follow through time added, better casting experience Trigger optimization Changed Z offset from 650 to 500/600/700

 

[laserdemon]

The spell kills myself, please fix it.