Income system

[Animalpower]

I need a special income system. The income=gold every 30 seconds is determined by the numbers of buildings=town halls a player posesses. Two buildings=200 gold, one building 100 gold, three 300 gold and so on. I need somebody to make the trigger it is not hard but I can not figure out what way to do it. Post a map or trigger.

 

[rulerofiron99]

Add the town halls to a unit group:

• Income
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Unit Group - Pick every unit in (Units owned by (Player((Player number of (Picked player)))) of type Town Hall) and do (Actions)
          • Loop - Actions
            • Unit Group - Add (Picked unit) to income[(Player number of (Picked player))]

Add newly built town halls to the same group:

• income add
  • Events
    • Unit - A unit Finishes construction
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to Town Hall
  • Actions
    • Unit Group - Add (Triggering unit) to income[(Player number of (Picked player))]

Looping trigger that adds the gold:

• Command
  • Events
    • Time - Every 30.00 seconds of game time
  • Conditions
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Unit Group - Pick every unit in income[(Player number of (Picked player))] and do (Actions)
          • Loop - Actions
            • Player - Add 100 to (Picked player) Current gold

 

[Dr. Boom]

Moin moin =)

Why not just:

• Trigger
  • Events
    • Time - Every 30.00 seconds of game time
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units of type Town Hall) and do (Actions)
      • Loop - Actions
        • Player - Add 100 to (Owner of (Picked unit)) Current gold

Greetings and Peace
Dr. Boom

 

[rulerofiron99]

That works too.

Just copied the triggers from a map I had lying around.

 

[MortAr]

• Untitled Trigger 001
  • Events
    • Time - Every 30.00 seconds of game time
  • Conditions
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Player - Add (100 x (Number of living Town Hall units owned by (Picked player))) to (Picked player) Current gold

Less calls.

 

[rulerofiron99]

Two leaks, although a 30 sec intervals they're insignificant.

 

[MortAr]

Those aren't leaks.
All players exists throughout the entire game, regardless of what happens, thus you don't need to destroy it.

The group is refreshed each time a unit appears on the map (eg. enter playable map field).

 

[rulerofiron99]

Oh, that's not a unit group. My bad.

 

[Spartipilo]

Pick every unit from (units of type) leaks. At least, that's what i've heard.

 

[defskull]

Check the system Income Generator at my Signature.
This method of "picking every unit in map" prove to be quite powerful function if you have many units in the map (first pick every unit, then filter it out)

My system just pick units inside the unit group (if you build 3 Town Halls, you would only be picking 3 Town Halls instead 453 units).

I may sound badass advertising my own resource (again), but I'm just helping him to guide him to use system which is more efficient.

 

[Garfield1337]

Pick every unit from (units of type) leaks. At least, that's what i've heard.

I thought so too at first, but this function destroys the group.

Hidden

function CountLivingPlayerUnitsOfTypeId takes integer unitId, player whichPlayer returns integer
    local group g
    local integer matchedCount

    set g = CreateGroup()
    set bj_livingPlayerUnitsTypeId = unitId
    call GroupEnumUnitsOfPlayer(g, whichPlayer, filterLivingPlayerUnitsOfTypeId)
    set matchedCount = CountUnitsInGroup(g)
    call DestroyGroup(g)

    return matchedCount
endfunction

 

[ap0calypse]

Guys? I have a great idea!
Let us continue this pointless discussion about efficiency when a poor guy just asked about a simple income system.


Anyway, I think this is the most efficient:

Triggers

• Build Town Hall
  • Events
    • Unit - A unit Finishes construction
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to Town Hall
  • Actions
    • Set tempInt = (Player number of (Owner of (Triggering unit)))
    • Set countTownHalls[tempInt] = (countTownHalls[tempInt] + 1)

• Gather Income
  • Events
    • Time - Every 30.00 seconds of game time
  • Conditions
  • Actions
    • For each (Integer A) from 1 to 12, do (Actions)
      • Loop - Actions
        • Player - Add (100 x countTownHalls[(Integer A)]) to (Player((Integer A))) Current gold

To the inexperienced eye it may look like it's a lot more than Dr. Boom's or MortAr's suggestions, but do not let that fool you.
This does not use unit groups (which are horribly inefficient in GUI).
The most horrible function would be "Player - Add (gold)" in this method.
tempInt is to avoid running unnecessary functions multiple times.

This is actually quite similar to Defskull's system, though mine is not flexible at all.
If you have multiple building types that add different amounts of gold, choose that one.
If you have only 1 building type, or have several but they all add the same gold amount, pick mine

Unless someone could prove me wrong about the entire efficiency-thing of course.



(No unit groups were created in the making of this comment)

 

[MortAr]

No man, you have to make all this into a single trigger.
If we used 2, it'd have been quite easy, as your example shows it.

 

[ap0calypse]

No man, you have to make all this into a single trigger.
If we used 2, it'd have been quite easy, as your example shows it.

Your wish is my command.

New Trigger - Hyperadvanced multieventual GUI triggering

• Build Town Hall + Income!
  • Events
    • Unit - A unit Finishes construction
    • Time - Every 5.00 seconds of game time
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) is A structure) Equal to False
      • Then - Actions
        • For each (Integer A) from 1 to 12, do (Actions)
          • Loop - Actions
            • Player - Add (100 x countTownHalls[(Integer A)]) to (Player((Integer A))) Current gold
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Unit-type of (Triggering unit)) Equal to Town Hall
          • Then - Actions
            • Set tempInt = (Player number of (Owner of (Triggering unit)))
            • Set countTownHalls[tempInt] = (countTownHalls[tempInt] + 1)
          • Else - Actions

What's next?
(Though it did lose all beauty it had before ).

 

[defskull]

I don't want to brag, but;

- My system has an individual timer per interval per building finished constructed (this what makes it different from method suggested above)
- As I said, my system just assess the units that is in the Unit Group (while your trigger, is to assess all Player Unit (1 ~ 12)). Imagine if Player 6 ~ 12 does not build any building-type income yet, you would still have to loop it each time the trigger run.
- Player Loop -> Unit Loop, once you loop each Player, in that function, you loop through each building, making it a double-loop, quite unefficient if you ask me
- The more you can configure in a system, the more freedom you will have.
- My system has an easy configuration setup :/

That's all I think.

But it's up to him if he want to resort to the most simple way, don't use my system.
But if you feel that you have many players playing your map (12) and your map gonna lasts a long game duration (1 ~ 2 hours), you can use my system.

Again, it is up to you.

 

[rulerofiron99]

If I may be so bold as to rejoin this turd-flinging contest:

• I responded first
• He's probably using my system right now
• I got rep for it (most important point)

 

[ap0calypse]

I don't want to brag, but;

- My system has individual timer per interval per building finished constructed
- As I said, my system just assess the units that is in the Unit Group (while your trigger, is to assess all Player Unit (1 ~ 12)). Imagine if Player 6 ~ 12 does not build any building-type income yet, you would still have to loop it each time the trigger run.
- Player Loop -> Unit Loop, once you loop each Player, in that function, you loop through each building, making it a double-loop, quite unefficient if you ask me
- The more you can configure in a system, the more freedom you will have.
- My system has an easy configuration setup :/

That's all I think.

But it's up to him if he want to resort to the most simple way, don't use my system.
But if you feel that you have many players playing your map (12) and your map gonna lasts a long game duration (1 ~ 2 hours), you can use my system.

Again, it is up to you.

The "12" is temporary. If there only are 6 players, he can make it loop from 1 to 6, right?
And you are right that it does indeed fire the actions for every player, whether that player actually built something or not.
You could circumvent this by adding an ITE with condition countTownHalls > 0.

Yes, your system is way more configurable
I made mine as short as possible, that means 0 configuration (not even a "MAX_PLAYERS" variable exists).

- Player Loop -> Unit Loop, once you loop each Player, in that function, you loop through each building, making it a double-loop, quite unefficient if you ask me

I didn't get this. It doesn't loop through any units. Players, yes. Units, no.
It only loops once, and that is for all players.
Or am I missing something? :S


Edit: YOU STAY OUT OF THIS RULEROFIRON99! ( )

 

[defskull]

I responded first

Doesn't mean the thread starter always follow the first person that gives solution to their problems, could be wrong.

He's probably using my system right now

Probably, been inactive in his own thread for such a long time.

I got rep for it (most important point)

This would be in contradiction with point A.

Naah I just leave this thread alone, let alone he decide which he will use (probably ruler's trigger by now).

@apo
Let's PM ! Haha

 

[Dr. Boom]

If I may be so bold as to rejoin this turd-flinging contest:

• I responded first
• He's probably using my system right now
• I got rep for it (most important point)

Someone is egoistic here .. guys you are not allowed to post here anymore!! Get it!!

@ ap0: Well as I said, I don't think its a good way to use 2 variables for just a simple thing like this ^^

 

[rulerofiron99]

Someone is egoistic here .. guys you are not allowed to post here anymore!! Get it!!

@ ap0: Well as I said, I don't think its a good way to use 2 variables for just a simple thing like this ^^

You understand me!

For what it's worth, I think your trigger was the best.

"Things should be as simple as they need to be - and no simpler."

 

[defskull]

Your wish is my command.

New Trigger - Hyperadvanced multieventual GUI triggering

• Build Town Hall + Income!
  • Events
    • Unit - A unit Finishes construction
    • Time - Every 5.00 seconds of game time
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) is A structure) Equal to False
      • Then - Actions
        • For each (Integer A) from 1 to 12, do (Actions)
          • Loop - Actions
            • Player - Add (100 x countTownHalls[(Integer A)]) to (Player((Integer A))) Current gold
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Unit-type of (Triggering unit)) Equal to Town Hall
          • Then - Actions
            • Set tempInt = (Player number of (Owner of (Triggering unit)))
            • Set countTownHalls[tempInt] = (countTownHalls[tempInt] + 1)
          • Else - Actions

What's next?
(Though it did lose all beauty it had before ).

• Set tempInt = (Player number of (Owner of (Triggering unit)))

Owner of (Triggering unit) -> (Triggering player), calls less function.

You should cache (Triggering unit) as you call it more than once.

Your trigger could be problem if he wants to have more than one building-type, I mean like 10 building or something, you're going to do a 10 I/T/E calls lol.

 

[ap0calypse]

"Things should be as simple as they need to be - and no simpler."

But...
I thought mine was more simple when converted to JASS.

Animalpower: I am sorry for taking some of your free time and destroying it with useless... words and... sentences and all that.
You can use any system you deem best, after all: 1 trigger (or 2 if you use mine - hint hint) won't make the difference, certainly not when all your other triggers are probably GUI as well.

 

[defskull]

"Things should be as simple as they need to be - and no simpler."

Don't use this as an excuse
Sometimes, we need to think advance and do advance thing because it will make your work to be worth like 50X instead sticking to the "simple" idea.

 

[rulerofiron99]

We're making an income trigger here, not the code for the game.

For a projectile system, definitely, but in this case it's really insignificant.

 

[defskull]

We're making an income trigger here, not the code for the game.

Nobody's asking a trigger for... showcase.
Definitely he wants to put it in a map, lolz.

 

[infoleather]

Although I am not flexible, if you have more than one type of construction, adding different amount of gold that choice. The size of Women Purple Leather Shoulder bags also depends upon the needs of women. If you are working women who has to go her office daily then you may need cwmalls.com Women Leather Flap Messenger Bags that can contain files and gadgets.

 

[defskull]

Although I am not flexible, if you have more than one type of construction, adding different amount of gold that choice.

Do you mean different gold gain for different building ?
Yeah my system does that, also, if you're gonna use the "simplest method", you will have to do a check like 10 times (O(n) search is bad) for 10 different types of building.

 

[Dadus2000]

Dr boom realy helped me too. I was searching for a way creating income/unit for a loooonggggggg time..(3 days) and I never tough that the solution was that simple.I min, 1 SINGLE TRIGGER!! Thats great!!

 

[easybakecakes]

nice

Add the town halls to a unit group:

• Income
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Unit Group - Pick every unit in (Units owned by (Player((Player number of (Picked player)))) of type Town Hall) and do (Actions)
          • Loop - Actions
            • Unit Group - Add (Picked unit) to income[(Player number of (Picked player))]

Add newly built town halls to the same group:

• income add
  • Events
    • Unit - A unit Finishes construction
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to Town Hall
  • Actions
    • Unit Group - Add (Triggering unit) to income[(Player number of (Picked player))]

Looping trigger that adds the gold:

• Command
  • Events
    • Time - Every 30.00 seconds of game time
  • Conditions
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Unit Group - Pick every unit in income[(Player number of (Picked player))] and do (Actions)
          • Loop - Actions
            • Player - Add 100 to (Picked player) Current gold

This trigger works excellent, of all my searching online this week and stamping of feet and smoking of cigarettes, this is it! This trigger is simple, easy to learn, and easy to change.

I found necessary to include a trigger that removes the income building from income if it is destroyed, and included it the attached map with ruleofiron99's trigs as well, all working.

If using different types of buildings for different types of income/amounts, then create variables and triggers for each using same format.

For instance Im making a map where if you capture a marketplace you get 1k gold, if you capture a lumber mill, you get 500 lumber, and my nubness found it best to make new trigs and variables following same format.

Sounds tedious but copy and paste is good and change what you need.

Does my method seem spammy or leaky? I have seen some snappy looking triggers balling this all into one, but I dont think they achieve what I need.

Maybe some overlord reading this has some advice?

I grew tired of tampering with tables and custom scripts and WE crashing after following step by step instructions from people on forums, so please try to be extra specific here.

Im new with incom triggers but have been moding for a decade, so spare me the insults, if I had not spent a week searching online and testing and tinkering already and smoking myself to death in front of my computer I wouldnt be asking this.

 

[easybakecakes]

ruleofiron99 youre going into my credits when I launch