[JASS] if multiple conditions ?

[deathismyfriend]

well i have an if condition but it has to check multiple conditions (all r units) any way to shorten this ?

if ( GetTriggerUnit() == udg_Unit_Spawns_Red[1] or GetTriggerUnit() == udg_Unit_Spawns_Red[2] or GetTriggerUnit() == udg_Unit_Spawns_Red[3] or GetTriggerUnit() == udg_Unit_Spawns_Red[4] or GetTriggerUnit() == udg_Unit_Spawns_Red[5] or GetTriggerUnit() == udg_Unit_Spawns_Red[6] or GetTriggerUnit() == udg_Unit_Spawns_Red[7] or GetTriggerUnit() == udg_Unit_Spawns_Red[8] or GetTriggerUnit() == udg_Unit_Spawns_Red[9] or GetTriggerUnit() == udg_Unit_Spawns_Red[10] or GetTriggerUnit() == udg_Unit_Spawns_Red[11] or GetTriggerUnit() == udg_Unit_Spawns_Red[12] or GetTriggerUnit() == udg_Unit_Spawns_Red[13] or GetTriggerUnit() == udg_Unit_Spawns_Red[14] or GetTriggerUnit() == udg_Unit_Spawns_Red[15] or GetTriggerUnit() == udg_Unit_Spawns_Red[16] or GetTriggerUnit() == udg_Unit_Spawns_Red[17] or GetTriggerUnit() == udg_Unit_Spawns_Red[18] or GetTriggerUnit() == udg_Unit_Spawns_Red[19] or GetTriggerUnit() == udg_Unit_Spawns_Red[20] or GetTriggerUnit() == udg_Unit_Spawns_Red[21] or GetTriggerUnit() == udg_Unit_Spawns_Red[22] or GetTriggerUnit() == udg_Unit_Spawns_Red[23] or GetTriggerUnit() == udg_Unit_Spawns_Red[24] or GetTriggerUnit() == udg_Unit_Spawns_Red[25] or GetTriggerUnit() == udg_Boss_Unit_Player[1]) then

thanks for helping

 

[rulerofiron99]

You could put it all in another function, with multiple return places, and call it.

If you want to keep it local, you can set a temp bool = true and loop through all the elements in your array, and set the temp bool to false if the condition is false.

 

[deathismyfriend]

how exactly would i do tht lol and which way is more efficient ? thanks

 

[rulerofiron99]

Okay after looking at your code again, the first way might be more efficient since you are doing a lot of conditions, and you only need one of them to be true.

function CheckUnitSpawns takes unit u returns boolean
    local integer i = 1
    loop
        exitwhen i == 25
        if (GetTriggerUnit() == udg_Unit_Spawns_Red[i]) then
            //do nothing
        else
            return false
        endif
        set i = i +1
    endloop
    if (GetTriggerUnit() == udg_Boss_Unit_Player[1]) then
        //do nothing
    else
        return false
    endif
    return false
endfunction

I'm not 100% sure about the syntax, though. I'm still new at JASS myself and I'm not fully comfortable with multiple return statements.

 

[deathismyfriend]

ok lol thanks ill see how it works

 

[Maker]

rulerofiron99, return true when a match is found, no need to keep looping after that.

deathismyfriend, you could register the death events of specific units, then there would be no need for the conditions.

 

[deathismyfriend]

what do u mean register the death events of specific units ?