• Listen to a special audio message from Bill Roper to the Hive Workshop community (Bill is a former Vice President of Blizzard Entertainment, Producer, Designer, Musician, Voice Actor) 🔗Click here to hear his message!
  • Read Evilhog's interview with Gregory Alper, the original composer of the music for WarCraft: Orcs & Humans 🔗Click here to read the full interview.

[Spell] Huge problem >.< - Spells deal damage to allies

Status
Not open for further replies.

Kusanagi Kuro

Hosted Project: SC
Level 10
Joined
Mar 11, 2012
Messages
708
Hello guys. Today I've discovered many problem in my trigger. I'll attach my map here. Here is my problems:
1. Some of my trigger cause the Casting Unit to damage a non-allies unit but they dont damage the Neutral Hostile and sometimes they deal damage to allies too.
2. In the Sun Strike Damage trigger (u will see it inside my map), I dont know why it doesnt deal any damage.
Only 2 question but they're so serious to me. If anyone find out why and know how to fix it, plz let me know. Thks very much.
P/S: If u dont understand my problems, just tell me and I'll try to explain as well as I could.
 
Last edited:
Level 12
Joined
Sep 11, 2011
Messages
1,176
Hello guys. Today I've discovered many problem in my trigger. I'll attach my map here. Here is my problems:
1. Some of my trigger cause the Casting Unit to damage a non-allies unit but they dont damage the Neutral Hostile and sometimes they deal damage to allies too.
2. In the Sun Strike Damage trigger (u will see it inside my map), I dont know why it doesnt deal any damage.
Only 2 question but they're so serious to me. If anyone find out why and know how to fix it, plz let me know. Thks very much.
P/S: If u dont understand my problems, just tell me and I'll try to explain as well as I could.

1. which trigger ?
2. Here i fixed your triggers, see how it works.
http://www.hiveworkshop.com/forums/pastebin.php?id=arf6t8

  • Sun Strike
    • Events
      • Unit - A unit Begins casting an ability
    • Conditions
      • (Ability being cast) Equal to Sun Strike
    • Actions
      • Set SS_Unit = (Triggering unit)
      • Set cv = (Custom value of SS_Unit)
      • Set SS_LVLs[cv] = (Level of Sun Strike for SS_Unit)
      • Set SS_SFXs[cv] = (Target point of ability being cast)
      • Set SS_AOEs[cv] = (150.00 + ((Real(SS_LVLs[cv])) x 50.00))
      • Set SS_Groups[cv] = (Units within SS_AOEs[cv] of (Target point of ability being cast) matching (((Matching unit) belongs to an enemy of (Owner of (Casting unit))) Equal to True))
      • Set SS_GroupCountss[cv] = (Number of units in SS_Groups[cv])
      • Set SS_DMGs[cv] = ((100.00 + ((Real(SS_LVLs[cv])) x 50.00)) + ((30.00 + ((Real(SS_LVLs[cv])) x 10.00)) x (Real(SS_GroupCountss[cv]))))
      • Unit Group - Add (Triggering unit) to SS_Group
      • Trigger - Turn on Sun Strike Damage <gen>
      • Trigger - Turn on Sun Strike Stop <gen>
  • Sun Strike Stop
    • Events
      • Unit - A unit Stops casting an ability
    • Conditions
      • (Ability being cast) Equal to Sun Strike
    • Actions
      • Trigger - Turn off Sun Strike Damage <gen>
      • Trigger - Turn off (This trigger)
  • Sun Strike Damage
    • Events
      • Unit - A unit Finishes casting an ability
    • Conditions
      • (Ability being cast) Equal to Sun Strike
    • Actions
      • Unit Group - Pick every unit in SS_Group and do (Actions)
        • Loop - Actions
          • Set SS_Unit = (Picked unit)
          • Set cv = (Custom value of SS_Unit)
          • Unit Group - Pick every unit in SS_Groups[cv] and do (Actions)
            • Loop - Actions
              • Unit - Cause (SS_Unit) to damage (Picked unit), dealing SS_DMGs[cv] damage of attack type Spells and damage type Normal
          • For each (Integer A) from 1 to 15, do (Actions)
            • Loop - Actions
              • Set SS_SFX2s[cv] = (SS_SFXs[cv] offset by (125.00 + ((Real(SS_LVLs[cv])) x 50.00)) towards (24.00 x (Real((Integer A)))) degrees)
              • Special Effect - Create a special effect at SS_SFX2s[cv] using Abilities\Spells\Human\FlameStrike\FlameStrike1.mdl
      • Custom script: call DestroyGroup (udg_SS_Group)
      • Custom script: call DestroyGroup (udg_SS_Groups[udg_cv])
      • Trigger - Turn off (This trigger)
the problem is, there is no unit picked on your triggers, resulting the Sun Strike to deal damages to no unit :).

i suspect the problem is the trigger didn't reach the conditions, so it was like picking no unit. so i changed it to this

  • Set SS_Groups[cv] = (Units within SS_AOEs[cv] of (Target point of ability being cast) matching (((Matching unit) belongs to an enemy of (Owner of (Casting unit))) Equal to True))
that way, it would pick only the enemy of caster. in other word, the kodo beast.

and i see you are setting the damages and ranges each level. you could do math for it, so you don't have to set it manually each level :)

  • Set SS_DMGs[cv] = ((100.00 + ((Real(SS_LVLs[cv])) x 50.00)) + ((30.00 + ((Real(SS_LVLs[cv])) x 10.00)) x (Real(SS_GroupCountss[cv]))))
result :
level 1 - (100 + level(1) x 50) + (30 + (level(1) x 10)) x (Number Of Units in Group)
=(100 + 50) + ((30 + 10) x (for example : 5))
=150 + (40 x 5)
= 350 damages

level 2 - (100 + level(2) x 50) + (30 + (level(2) x 10)) x (Number Of Units in Group)
=(100 + 100) + ((30 + 20) x 5))
=200 + (60 x 5)
= 500 damages

and so on.

the same goes for AOE and Point of Special Effects :)
 
Last edited:

Kusanagi Kuro

Hosted Project: SC
Level 10
Joined
Mar 11, 2012
Messages
708
1. which trigger ?
The Ice Prison Trigger and the Fire Shield trigger. This is my first time making map. There many things I have to learn especially about trigger and testing. I dont have many friends that can help me testing my map so there many leaks. Thks for solving my 2nd problem.
Edit: Ur trigger has a huge problem with it, it can only occur one time only and the damage isnt equal ain different position.
 
Last edited:

Kusanagi Kuro

Hosted Project: SC
Level 10
Joined
Mar 11, 2012
Messages
708
I mean the damage done to 1 unit is different to damage done to another unit in the area. And plz check for me the Ice Prison and Fire Shield trigger. They damage allies too >.<
 
Level 12
Joined
Sep 11, 2011
Messages
1,176
I mean the damage done to 1 unit is different to damage done to another unit in the area. And plz check for me the Ice Prison and Fire Shield trigger. They damage allies too >.<

no, i've tested it several times and it dealt the same damage to all units in that area, the damages dealt for 5 units are 350 damages and all the five kodos got 9650 out of 10000.

if you want to know how many damages it would deal and how many units are damaged, add this :

  • Game - Display to (All players) the text: (String(SS_GroupCountss[cv]))
after
  • Set SS_GroupCountss[cv] = (Number of units in SS_Groups[cv])
and then add this

  • Game - Display to (All players) the text: (String(SS_DMGs[cv]))
after
  • Set SS_DMGs[cv] = ((100.00 + ((Real(SS_LVLs[cv])) x 50.00)) + ((30.00 + ((Real(SS_LVLs[cv])) x 10.00)) x (Real(SS_GroupCountss[cv]))))
and about your Ice Prison and Fire shield spells, i've fixed it and now i'm uploading the map. next time, you shouldn't use this condition :

  • (Owner of (Picked unit)) Not equal to (Random player from (All allies of (Owner of CastingHero)))
use boolean comparison instead :

  • ((Picked unit) belongs to an enemy of (Owner of (Casting unit))) Equal to True
it's Unit - Unit belongs to an Enemy of Player

that way, it would only pick units that belongs to an enemy of the caster.

Edit : http://www.hiveworkshop.com/forums/pastebin.php?id=arf6t8
there you are, i've added the damage messages too, make sure to remove it after you checks the damage to all the kodos.
 
Status
Not open for further replies.
Top