How do I detect how many players are in game?

[X-Death]

For hero selection at the start of my game I need some way of detecting when all players are finished choosing their heroes. How can I detect how many players are in-game, excluding computers?

 

[Doomlord]

• Player Count
  • Events
  • Conditions
  • Actions
    • For each (Integer LoopIndex) from 1 to 12, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Player(LoopIndex)) controller) Equal to User
            • ((Player(LoopIndex)) slot status) Equal to Is playing
          • Then - Actions
            • Set Count = (Count + 1)
          • Else - Actions

Count is the number of valid map players in the map.

 

[X-Death]

Nice, thank you. But I just did this instead.

• Set PlayerCount = (Number of players in (All players matching ((((Matching player) slot status) Equal to Is playing) and (((Matching player) controller) Equal to User))))

 

[deathismyfriend]

that creates a player group i believe.

 

[X-Death]

that creates a player group i believe.

Is that a problem? Will my method cause a leak?

 

[Spartipilo]

Yes, it creates leaks.

Check "All Players" group. I think it only returns human playing players.

 

[deathismyfriend]

yes it leaks a player group.

 

[X-Death]

How do I clean the leak?

Check "All Players" group. I think it only returns human playing players.

No, that will detect computer players too.

 

[deathismyfriend]

create player group add all the players to player group then destroy the player group.

 

[Spartipilo]

Oh... my bad, no, it doesn't leak because it uses bj_AllPlayers, but it can be improved with some JASS, the thing is that both of the "Matching" thing creates additional functions... but it's not a big deal

All Player never leaks.

 

[deathismyfriend]

It does leak look at the players matching condition call.

function GetPlayersByMapControl takes mapcontrol whichControl returns force
    local force f = CreateForce()
    local integer playerIndex
    local player  indexPlayer

    set playerIndex = 0
    loop
        set indexPlayer = Player(playerIndex)
        if GetPlayerController(indexPlayer) == whichControl then
            call ForceAddPlayer(f, indexPlayer)
        endif

        set playerIndex = playerIndex + 1
        exitwhen playerIndex == bj_MAX_PLAYER_SLOTS
    endloop

    return f
endfunction

doing what doomlord suggested is both faster and more efficient and leakless.

 

[X-Death]

deathismyfriend, wouldn't this method be okay too?

• Set PlayerCountGroup = (All players matching ((((Matching player) slot status) Equal to Is playing) and (((Matching player) controller) Equal to User)))
• Set PlayerCount = (Number of players in PlayerCountGroup)
• Custom script: call DestroyForce(udg_PlayerCountGroup)

 

[deathismyfriend]

Yes but it is less efficient and slower.