[Trigger] Help!

[HolyBear]

This spell works just later in the game it crashes the game. Any ideas what may be causes the crash?

• Shark Frenzy
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to (==) 5 Feeding Sharks
  • Actions
    • Set Kisame_Caster[3] = (Casting unit)
    • Set Kisame_Target[2] = (Target unit of ability being cast)
    • Set Kisame_Real[3] = 1500.00
    • Set Kisame_Real[4] = 0.00
    • Unit - Create 1 Dummy target for (Owner of Kisame_Caster[3]) at (Position of Kisame_Target[2]) facing Default building facing (270.0) degrees
    • Set Kisame_CreatedUnit[9] = (Last created unit)
    • Set Kisame_Point[1] = ((Position of Kisame_Target[2]) offset by 100.00 towards 72.00 degrees)
    • Unit - Create 1 DummyShark for (Owner of Kisame_Caster[3]) at Kisame_Point[1] facing (Facing of Kisame_Target[2]) degrees
    • Set Kisame_CreatedUnit[3] = (Last created unit)
    • Animation - Change Kisame_CreatedUnit[3] flying height to 150.00 at 1000.00
    • Lightning - Create a Drain Mana lightning effect from source (Position of Kisame_CreatedUnit[9]) to target (Position of Kisame_CreatedUnit[3])
    • Set Kisame_Light[1] = (Last created lightning effect)
    • Set Kisame_Point[1] = ((Position of Kisame_Target[2]) offset by 100.00 towards 144.00 degrees)
    • Unit - Create 1 DummyShark for (Owner of Kisame_Caster[3]) at Kisame_Point[1] facing (Facing of Kisame_Target[2]) degrees
    • Set Kisame_CreatedUnit[4] = (Last created unit)
    • Animation - Change Kisame_CreatedUnit[4] flying height to 150.00 at 1000.00
    • Lightning - Create a Drain Mana lightning effect from source (Position of Kisame_CreatedUnit[9]) to target (Position of Kisame_CreatedUnit[4])
    • Set Kisame_Light[2] = (Last created lightning effect)
    • Set Kisame_Point[1] = ((Position of Kisame_Target[2]) offset by 100.00 towards 210.00 degrees)
    • Unit - Create 1 DummyShark for (Owner of Kisame_Caster[3]) at Kisame_Point[1] facing (Facing of Kisame_Target[2]) degrees
    • Set Kisame_CreatedUnit[5] = (Last created unit)
    • Animation - Change Kisame_CreatedUnit[5] flying height to 150.00 at 1000.00
    • Lightning - Create a Drain Mana lightning effect from source (Position of Kisame_CreatedUnit[9]) to target (Position of Kisame_CreatedUnit[5])
    • Set Kisame_Light[3] = (Last created lightning effect)
    • Set Kisame_Point[1] = ((Position of Kisame_Target[2]) offset by 100.00 towards 288.00 degrees)
    • Unit - Create 1 DummyShark for (Owner of Kisame_Caster[3]) at Kisame_Point[1] facing (Facing of Kisame_Target[2]) degrees
    • Set Kisame_CreatedUnit[6] = (Last created unit)
    • Animation - Change Kisame_CreatedUnit[6] flying height to 150.00 at 1000.00
    • Lightning - Create a Drain Mana lightning effect from source (Position of Kisame_CreatedUnit[9]) to target (Position of Kisame_CreatedUnit[6])
    • Set Kisame_Light[4] = (Last created lightning effect)
    • Set Kisame_Point[1] = ((Position of Kisame_Target[2]) offset by 100.00 towards 360.00 degrees)
    • Unit - Create 1 DummyShark for (Owner of Kisame_Caster[3]) at Kisame_Point[1] facing (Facing of Kisame_Target[2]) degrees
    • Set Kisame_CreatedUnit[7] = (Last created unit)
    • Animation - Change Kisame_CreatedUnit[7] flying height to 150.00 at 1000.00
    • Lightning - Create a Drain Mana lightning effect from source (Position of Kisame_CreatedUnit[9]) to target (Position of Kisame_CreatedUnit[7])
    • Set Kisame_Light[5] = (Last created lightning effect)
    • Trigger - Turn on Shark Frenzy Move <gen>

• Shark Frenzy Move
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • Set Kisame_Real[4] = (Kisame_Real[4] + 6.00)
    • Set Kisame_Point[2] = ((Position of Kisame_Target[2]) offset by 250.00 towards (72.00 + Kisame_Real[4]) degrees)
    • Unit - Move Kisame_CreatedUnit[9] instantly to (Position of Kisame_Target[2]), facing Default building facing (270.0) degrees
    • Unit - Move Kisame_CreatedUnit[3] instantly to Kisame_Point[2], facing Kisame_Real[4] degrees
    • Unit - Make Kisame_CreatedUnit[3] face ((Angle from (Position of Kisame_Target[2]) to (Position of Kisame_CreatedUnit[3])) + 90.00) over 0.00 seconds
    • Lightning - Move Kisame_Light[1] to source (Position of Kisame_CreatedUnit[9]) and target (Position of Kisame_CreatedUnit[3])
    • Set Kisame_Point[2] = ((Position of Kisame_Target[2]) offset by 250.00 towards (210.00 + Kisame_Real[4]) degrees)
    • Unit - Move Kisame_CreatedUnit[4] instantly to Kisame_Point[2], facing Kisame_Real[4] degrees
    • Unit - Make Kisame_CreatedUnit[4] face ((Angle from (Position of Kisame_Target[2]) to (Position of Kisame_CreatedUnit[4])) + 90.00) over 0.00 seconds
    • Lightning - Move Kisame_Light[2] to source (Position of Kisame_CreatedUnit[9]) and target (Position of Kisame_CreatedUnit[4])
    • Set Kisame_Point[2] = ((Position of Kisame_Target[2]) offset by 250.00 towards (144.00 + Kisame_Real[4]) degrees)
    • Unit - Move Kisame_CreatedUnit[5] instantly to Kisame_Point[2], facing Kisame_Real[4] degrees
    • Unit - Make Kisame_CreatedUnit[5] face ((Angle from (Position of Kisame_Target[2]) to (Position of Kisame_CreatedUnit[5])) + 90.00) over 0.00 seconds
    • Lightning - Move Kisame_Light[3] to source (Position of Kisame_CreatedUnit[9]) and target (Position of Kisame_CreatedUnit[5])
    • Set Kisame_Point[2] = ((Position of Kisame_Target[2]) offset by 250.00 towards (360.00 + Kisame_Real[4]) degrees)
    • Unit - Move Kisame_CreatedUnit[6] instantly to Kisame_Point[2], facing Kisame_Real[4] degrees
    • Unit - Make Kisame_CreatedUnit[6] face ((Angle from (Position of Kisame_Target[2]) to (Position of Kisame_CreatedUnit[6])) + 90.00) over 0.00 seconds
    • Lightning - Move Kisame_Light[4] to source (Position of Kisame_CreatedUnit[9]) and target (Position of Kisame_CreatedUnit[6])
    • Set Kisame_Point[2] = ((Position of Kisame_Target[2]) offset by 250.00 towards (288.00 + Kisame_Real[4]) degrees)
    • Unit - Move Kisame_CreatedUnit[7] instantly to Kisame_Point[2], facing Kisame_Real[4] degrees
    • Unit - Make Kisame_CreatedUnit[7] face ((Angle from (Position of Kisame_Target[2]) to (Position of Kisame_CreatedUnit[7])) + 90.00) over 0.00 seconds
    • Lightning - Move Kisame_Light[5] to source (Position of Kisame_CreatedUnit[9]) and target (Position of Kisame_CreatedUnit[7])
      • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • Kisame_Real[3] Equal to (==) 0.00
        • Then - Actions
          • Unit - Remove Spell Book from Kisame_Target[2]
          • Lightning - Destroy Kisame_Light[1]
          • Lightning - Destroy Kisame_Light[2]
          • Lightning - Destroy Kisame_Light[3]
          • Lightning - Destroy Kisame_Light[4]
          • Lightning - Destroy Kisame_Light[5]
          • Unit - Remove Kisame_CreatedUnit[3] from the game
          • Unit - Remove Kisame_CreatedUnit[4] from the game
          • Unit - Remove Kisame_CreatedUnit[5] from the game
          • Unit - Remove Kisame_CreatedUnit[6] from the game
          • Unit - Remove Kisame_CreatedUnit[7] from the game
          • Unit - Remove Kisame_CreatedUnit[9] from the game
          • Custom script: call RemoveLocation (udg_Kisame_Point[1])
          • Custom script: call RemoveLocation (udg_Kisame_Point[2])
          • Trigger - Turn off (This trigger)
        • Else - Actions
          • Set Kisame_Real[3] = (Kisame_Real[3] - 3.00)

• Shark Frenzy Buff
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to (==) 5 Feeding Sharks
  • Actions
    • Unit - Add Spell Book to Kisame_Target[2]
    • Player - Disable Spell Book for (Owner of Kisame_Target[2])
    • Unit - Set level of Slow Aura (Tornado) for Kisame_Target[2] to (Level of 5 Feeding Sharks for Kisame_Caster[3])
    • Unit - Set level of Trueshot Aura for Kisame_Target[2] to (Level of 5 Feeding Sharks for Kisame_Caster[3])

• Shark Frenzy Dies
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Dying unit) Equal to (==) Kisame_Target[2]
  • Actions
    • Trigger - Turn off Shark Frenzy Move <gen>
    • Unit - Remove Spell Book from Kisame_Target[2]
    • Lightning - Destroy Kisame_Light[1]
    • Lightning - Destroy Kisame_Light[2]
    • Lightning - Destroy Kisame_Light[3]
    • Lightning - Destroy Kisame_Light[4]
    • Lightning - Destroy Kisame_Light[5]
    • Unit - Remove Kisame_CreatedUnit[3] from the game
    • Unit - Remove Kisame_CreatedUnit[4] from the game
    • Unit - Remove Kisame_CreatedUnit[5] from the game
    • Unit - Remove Kisame_CreatedUnit[6] from the game
    • Unit - Remove Kisame_CreatedUnit[7] from the game
    • Unit - Remove Kisame_CreatedUnit[9] from the game
    • Custom script: call RemoveLocation (udg_Kisame_Point[1])
    • Custom script: call RemoveLocation (udg_Kisame_Point[2])

 

[deathismyfriend]

all of these leak.

• Lightning - Create a Drain Mana lightning effect from source (Position of Kisame_CreatedUnit[9]) to target (Position of Kisame_CreatedUnit[6])
• -------- this also leaks ----------
  • Unit - Make Kisame_CreatedUnit[3] face ((Angle from (Position of Kisame_Target[2]) to (Position of Kisame_CreatedUnit[3])) + 90.00) over 0.00 seconds

it might crash the map because of this

• Kisame_Real[3] Equal to (==) 0.00

never use reals for timers. it probably never hits 0.00
when u subtract 30.00 - 1.00 - 1.00 it may not hit 0.00 because they are inaccurate.
so ur trigger is running indefinitely even when the effects and everything are destroyed. So it tries to destroy null points.

also this spell is not MUI.

 

[HolyBear]

I changed Kisame_Real[3] to integer but how would i fix some leaks with having the same effect?

 

[deathismyfriend]

The effects don't leak the position of whatever leaks u need to put them in a variable and remove them.

 

[HolyBear]

So like this? where i just remove the point then set the point again instead of setting the point then changing the point with set point again.

• Set Kisame_Point[2] = ((Position of Kisame_Target[2]) offset by 250.00 towards (72.00 + Kisame_Real[4]) degrees)
• Unit - Move Kisame_CreatedUnit[9] instantly to (Position of Kisame_Target[2]), facing Default building facing (270.0) degrees
• Unit - Move Kisame_CreatedUnit[3] instantly to Kisame_Point[2], facing Kisame_Real[4] degrees
• Custom script: call RemoveLocation (udg_Kisame_Point[2])
• Unit - Make Kisame_CreatedUnit[3] face ((Angle from (Position of Kisame_Target[2]) to (Position of Kisame_CreatedUnit[3])) + 90.00) over 0.00 seconds
• Lightning - Move Kisame_Light[1] to source (Position of Kisame_CreatedUnit[9]) and target (Position of Kisame_CreatedUnit[3])
• Set Kisame_Point[2] = ((Position of Kisame_Target[2]) offset by 250.00 towards (210.00 + Kisame_Real[4]) degrees)

 

[deathismyfriend]

So like this? where i just remove the point then set the point again instead of setting the point then changing the point with set point again.

• Set Kisame_Point[2] = ((Position of Kisame_Target[2]) offset by 250.00 towards (72.00 + Kisame_Real[4]) degrees)
• Unit - Move Kisame_CreatedUnit[9] instantly to (Position of Kisame_Target[2]), facing Default building facing (270.0) degrees
• Unit - Move Kisame_CreatedUnit[3] instantly to Kisame_Point[2], facing Kisame_Real[4] degrees
• Custom script: call RemoveLocation (udg_Kisame_Point[2])
• Unit - Make Kisame_CreatedUnit[3] face ((Angle from (Position of Kisame_Target[2]) to (Position of Kisame_CreatedUnit[3])) + 90.00) over 0.00 seconds
• Lightning - Move Kisame_Light[1] to source (Position of Kisame_CreatedUnit[9]) and target (Position of Kisame_CreatedUnit[3])
• Set Kisame_Point[2] = ((Position of Kisame_Target[2]) offset by 250.00 towards (210.00 + Kisame_Real[4]) degrees)

u need to use the point in the action. then u remove the points.