[Trigger] Help with a Give Command

[Karkul]

Here I'm making a give command but I get issues with selection bug. I want to be sure that when red select 12 units and do, for example, -give 2, it'll give those 12 units only to player 2. But instead of it, it also include units selected by other players else than red.

Here my actual trigger:

• Events
• Player - Player 1 type a chat message containing -give 2 as a equivalent result
• Action
• Group Unit - Pick every units in (units currently selected by player 1) and do (if owner of picked units equal to player 1) then do (unit - Change ownership of picked unit to player 2 and change color), else do nothing

 

[rulerofiron99]

• Give Units
  • Events
    • Player - Player 1 (Red) types a chat message containing -give as A substring
  • Conditions
  • Actions
    • Set GivePlayer = (Player((Integer((Substring((Entered chat string), 7, 8))))))
    • Set GiveGroup = (Units currently selected by (Triggering player))
    • Unit Group - Pick every unit in GiveGroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Owner of (Picked unit)) Equal to (Triggering player)
          • Then - Actions
            • Unit - Change ownership of (Picked unit) to GivePlayer and Change color
          • Else - Actions

This works fine.

 

[Karkul]

Thank you for your help but now my game crash.

When someone type somethign else than a number, the game crash. Like -give hostile, -give neutral, etc.

Any help about that?

Edit: Ok fixed the crash error by setting every possible events instead of just a simple -give.

 

[rulerofiron99]

No man D:

Make an integer variable, set Substring (entered chat string, 7, 8) = that integer
Check if integer is between 1 and 12, if it is, do the rest of the actions.

 

[HesitationSnow]

If that still doesn't work you must use Jass. I heard some time ago there was an issue with GUI and selected units but I've never tested.

 

[rulerofiron99]

If that still doesn't work you must use Jass. I heard some time ago there was an issue with GUI and selected units but I've never tested.

I've never had any issues with selection groups in GUI, but that is worth testing if there is some truth to it.

 

[Karkul]

I bring back my old topic but It still doesn't work.

What JASS I'll need to use?

If I could get the Give Command trigger from SotDRP or AoC, it would be nice.

 

[rulerofiron99]

Sigh.

I am very annoyed that I gave you a functioning trigger and explained how to fix the possible crash.

Anyways, since it is the festive season:

• Give
  • Events
    • Player - Player 1 (Red) types a chat message containing -give as A substring
    • Player - Player 2 (Blue) types a chat message containing -give as A substring
    • ...
    • Player - Player 12 (Brown) types a chat message containing -give as A substring
  • Conditions
  • Actions
    • Set tempGroup = (Units currently selected by (Triggering player))
    • Set tempInteger = (Integer((Substring((Entered chat string), 7, 8))))
    • -------- Check if the number is valid --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • And - All (Conditions) are true
          • Conditions
            • tempInteger Greater than or equal to 1
            • tempInteger Less than or equal to 12
      • Then - Actions
        • Set tempPlayer = (Player(tempInteger))
        • Unit Group - Pick every unit in tempGroup and do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Owner of (Picked unit)) Equal to (Triggering player)
              • Then - Actions
                • Unit - Change ownership of (Picked unit) to tempPlayer and Change color
              • Else - Actions
      • Else - Actions
    • Custom script: call DestroyGroup(udg_tempGroup)

Also attached, fill in the rest of the player events.