[Trigger] Chat command Unit transfer Help

[Gadgetguy]

I am trying to make a trigger where if someone types something like -gu 2. It will give your selected units to player 2.

I have this so far.

• Actions
• Unit Group - Pick every unit in (Units currently selected by Player 1 (Red)) and do (Actions)
  • Loop - Actions
    • Unit - Change ownership of (Picked unit) to Player 2 (Blue) and Change color

The problem I am having is I can't figure out how to make it so any player can say this and it will work without me having to make lots of triggers for the situation.

 

[Starquizer]

I will post the trigger soon, expect an edit.

<<< EDIT >>>

here you are:

• Initialization
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Trigger - Add to Give Unit to Player <gen> the event (Player - (Picked player) types a chat message containing -gu as A substring)

• Give Unit to Player
  • Events
  • Conditions
  • Actions
    • Set Index = (Integer((Substring((Entered chat string), 5, 5))))
    • Set gu_SourcePlayer = (Triggering player)
    • Set gu_TargetPlater = (Player(Index))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Index Greater than or equal to 0
        • gu_SourcePlayer Equal to gu_TargetPlater
      • Then - Actions
        • Game - Display to (Player group(gu_SourcePlayer)) the text: |cffffcc00Can not c...
      • Else - Actions
        • Set gu_SelectedUnit = (Random unit from (Units currently selected by gu_SourcePlayer))
        • Unit - Change ownership of gu_SelectedUnit to gu_TargetPlater and Change color
        • Game - Display to (All players) the text: ((Name of gu_SourcePlayer) + ( |cffffcc00changed ownership of|r + ((Name of gu_SelectedUnit) + ( |cffffcc00to|r + (Name of gu_TargetPlater)))))

 

[Maker]

^Player group leak -> http://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/

 

[Starquizer]

Then he could just remove the display messages I just added them for information.

 

[defskull]

^Player group leak -> Things That Leak

Which Player Group was that ?
Is it (All players) or Displaying message ?

I believed (All players) does not leak.

 

[Maker]

Which Player Group was that ?
Is it (All players) or Displaying message ?

I believed (All players) does not leak.

• Game - Display to (Player group(gu_SourcePlayer)) the text: |cffffcc00Can not c...

And this leaks a unit group

• Set gu_SelectedUnit = (Random unit from (Units currently selected by gu_SourcePlayer))

 

[Starquizer]

@ Maker, How about this, now ?

• Initialization
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Trigger - Add to Give Unit to Player <gen> the event (Player - (Picked player) types a chat message containing -gu as A substring)

• Give Unit to Player
  • Events
  • Conditions
  • Actions
    • Set Index = (Integer((Substring((Entered chat string), 5, 5))))
    • Set gu_SourcePlayer = (Triggering player)
    • Set gu_TargetPlater = (Player(Index))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Index Greater than or equal to 0
        • gu_SourcePlayer Equal to gu_TargetPlater
      • Then - Actions
        • Set gu_PlayerG = (Player group(gu_SourcePlayer))
        • Game - Display to gu_PlayerG the text: |cffffcc00Can not c...
      • Else - Actions
        • Set gu_Selection = (Units currently selected by gu_SourcePlayer)
        • Set gu_SelectedUnit = (Random unit from gu_Selection)
        • Unit - Change ownership of gu_SelectedUnit to gu_TargetPlater and Change color
        • Game - Display to (All players) the text: ((Name of gu_SourcePlayer) + ( |cffffcc00changed ownership of|r + ((Name of gu_SelectedUnit) + ( |cffffcc00to|r + (Name of gu_TargetPlater)))))

 

[defskull]

• Set gu_PlayerG = (Player group(gu_SourcePlayer))

Leak, clean it like this;

• Custom script: call DestroyGroup(udg_gu_PlayerG)

• Set gu_Selection = (Units currently selected by gu_SourcePlayer)

Repeat instructions above.

 

[Starquizer]

Leak, clean it like this;

• Custom script: call DestroyGroup(udg_gu_PlayerG)

Repeat instructions above.

udg_PlayerG is a player group (force) not unit group, DestroyGroup() might cause error

 

[defskull]

Eh, I meant DestroyForce(udg_gu_PlayerG) for Player Group while DestroyGroup(udg_gu_Selection) for Unit Group
Sorry about the confusion.

Both leak, Player Group and Unit Group.

 

[Starquizer]

Both leak, Player Group and Unit Group.

I got confused at first, you see I thought if I destroy the group the variable will be destroyed as well making it no longer available for another use but I now remember that variables are just pointer and I will be destroying what it is pointing to not the pointer itself. Anyway, thanks for the reminder.

 

[defskull]

You could name it TempVariableName, because you used it in the trigger that has instant effect.
Blizzard uses a single-threaded structure that you can never have bugs running 3 triggers at once as long as the effect of the trigger is instant (and yes, even those triggers uses same variable, but different variable setting for each trigger)

That's why after it is used, we destroy it.

By destroying the memory of the variable, we are not destroying the variable itself lol, just like Point variable and such.