[Trigger] Help, function causes fatal error

[Zacharias]

Hi there!
since weeks this trigger, designed for a area spell, causes fatal errors (access violation) in random situations. The error appears when only one unit is in range, cant get more information out of it, it seems very random.

Could someone help me plz?

function UnitEnemyNS takes nothing returns boolean
    if GetUnitState(GetFilterUnit(),UNIT_STATE_LIFE)<= 0 or IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) or GetUnitAbilityLevel(GetEnumUnit(),'Avul')>0 or GetUnitAbilityLevel(GetEnumUnit(),'Aloc')>0 then
        return false
    endif
    return IsPlayerEnemy(GetOwningPlayer(GetFilterUnit()), GetOwningPlayer(udg_tmpUnit))
endfunction


function Trig_Sandstorm_Actions takes nothing returns nothing
    local unit uCaster = GetTriggerUnit()
    local location tmpLocation = GetSpellTargetLoc()
    local real tx = GetLocationX(tmpLocation)
    local real ty = GetLocationY(tmpLocation)
    local real x
    local real y
    local real angle
    local real dist
    local integer i = 0
    local integer j = 0
    local integer n
    local group g = CreateGroup()
    local unit u
    local integer abilvl = GetUnitAbilityLevel(uCaster,'A05Q')
    local real dmg = I2R(abilvl+3)*10+I2R(GetHeroStr(uCaster,true))/2.0
    call RemoveLocation( tmpLocation )
    set tmpLocation = null

    loop
        exitwhen i > 20
        call CameraNoise(300, tx, ty)

        set angle = GetRandomReal(0,2*bj_PI)
        set dist = GetRandomReal(64, 256.00)
        set x = tx+Cos(angle)*dist
        set y = ty+Sin(angle)*dist
        call DestroyEffect(AddSpecialEffect("Objects\\Spawnmodels\\Undead\\ImpaleTargetDust\\ImpaleTargetDust.mdl",x,y))
        set angle = GetRandomReal(0,2*bj_PI)
        set dist = GetRandomReal(64, 256.00)
        set x = tx+Cos(angle)*dist
        set y = ty+Sin(angle)*dist
        call DestroyEffect(AddSpecialEffect("Objects\\Spawnmodels\\Undead\\ImpaleTargetDust\\ImpaleTargetDust.mdl",x,y))
        
        call GroupClear(g)
        set udg_tmpUnit = uCaster
        call GroupEnumUnitsInRange(g,tx,ty,256.0,Condition(function UnitEnemyNS))
        set u = null
        set n = CountUnitsInGroup(g)
        if n>0 then
            set n = GetRandomInt(1,n)
            set j=1
            loop
                exitwhen j>=n
                call GroupRemoveUnit(g,FirstOfGroup(g))
                set j=j+1
            endloop
            set u = FirstOfGroup(g)

            //call UnitDamageTarget(uCaster,u,dmg,true,false,ATTACK_TYPE_MAGIC, DAMAGE_TYPE_MAGIC, WEAPON_TYPE_WHOKNOWS)
            call DestroyEffect(AddSpecialEffect("Abilities\\Spells\\Undead\\Impale\\ImpaleHitTarget.mdl",GetUnitX(u),GetUnitY(u)))
        endif
        
        call TriggerSleepAction( 0.50 )
        set i = i+1
    endloop
    
    call DestroyGroup(g)
    set g = null
endfunction

 

[Teelo]

            loop
                exitwhen j>=n
                call GroupRemoveUnit(g,FirstOfGroup(g))
                set j=j+1
            endloop
            set u = FirstOfGroup(g)

u is always going to be null, because you remove everything from the group during that loop, then try to take the next unit.

 

[Zacharias]

No.

set n = CountUnitsInGroup(g)
        if n>0 then
            set n = GetRandomInt(1,n)

As you can see n is the limited by the number of units in the group.

            loop
                exitwhen j>=n
                call GroupRemoveUnit(g,FirstOfGroup(g))
                set j=j+1
            endloop

The loop: it ends before the last unit is reached, even if n is the last unit.


Edit the problem even occurs, when using the first of the group (0 units in group checked).

 

[Teelo]

Ah, I see. My bad.
It is a bit strange. I ran through your code and didn't see anything wrong.

You said that its happening when only one unit is in range. I suggest adding some debug lines with some waits, and keeping in mind what the last debug message was you saw before the game crashed.

 

[Zacharias]

Well i´ve added those debug lines, but without waits - cool idea thx will test it

 

[Teelo]

Add the waits, because otherwise it will just crash and you'll never get a chance to see what the last debug line was

 

[Zacharias]

It stops at "wait" which is pretty uncommon. I replaced the main ability, now it works. It seems that "monsoon" is bugged. Guess it depens on the time, as in this case the error pops up in the first loop. while it crashed in 2nd or 3rd before. Monsoon, which is channeled, wont follow the spell after some seconds.

function Trig_Sandstorm_Actions takes nothing returns nothing
    local unit uCaster = GetTriggerUnit()
    local location tmpLocation = GetSpellTargetLoc()
    local real tx = GetLocationX(tmpLocation)
    local real ty = GetLocationY(tmpLocation)
    local integer i = 0
    local group g = CreateGroup()
    local unit u
    local integer abilvl = GetUnitAbilityLevel(uCaster,'A05Q')
    local real dmg = I2R(abilvl+3)*10+I2R(GetHeroStr(uCaster,true))/2.0
    call RemoveLocation( tmpLocation )
    set tmpLocation = null
    
    call Print("init")
    call TriggerSleepAction( 0.40 )

    loop
        call Print("loop")        
        call TriggerSleepAction( 0.40 )
        exitwhen i > 20
        call Print("exitwhen i > 20")
        call TriggerSleepAction( 0.40 )
        
        call GroupClear(g)
        call Print("GroupClear(g)")
        call TriggerSleepAction( 0.40 )
        set udg_tmpUnit = uCaster
        call Print("udg_tmpUnit = uCaster")
        call TriggerSleepAction( 0.40 )
        call GroupEnumUnitsInRange(g,tx,ty,256.0,Condition(function UnitEnemyNS))
        call Print("GroupEnumUnitsInRange")
        call TriggerSleepAction( 0.40 )
        set u = FirstOfGroup(g)
        call Print("u = FirstOfGroup(g)")
        call TriggerSleepAction( 0.40 )
        call UnitDamageTarget(uCaster,u,dmg,true,false,ATTACK_TYPE_MAGIC, DAMAGE_TYPE_MAGIC, WEAPON_TYPE_WHOKNOWS)
        call Print("UnitDamageTarget")
        call TriggerSleepAction( 0.40 )
        call Print("wait")        
        call TriggerSleepAction( 0.40 )
        call Print("i = i+1")
        call TriggerSleepAction( 0.40 )
        set i = i+1
    endloop
    
    call Print("DestroyGroup(g)")        
    call TriggerSleepAction( 0.40 )
    
    call DestroyGroup(g)
    set g = null
endfunction

 

[Teelo]

Try using Channel, unless you need it to place buffs on units?

 

[Zacharias]

1st: channel wont show me the area-mouse-pointer (or can it be activated?)
2nd: every hero got 6 abilities, i try to avoid it since it blocks maybe other spells which cant be done in any other way.

 

[Teelo]

1. Something like Data target type - Area
2. Change the base order id

 

[Zacharias]

1. Something like Data target type - Area

No option.

2. Change the base order id

That works? (cooldowns?)

 

[Teelo]

Lame. Thought channel was supposed to be the need-no-other-spell ability. Oh well.

 

[Darkyvm]

There is an option, it's show targeting image i think, need to check, though.

 

[Zacharias]

There is an option, it's show targeting image i think, need to check, though.

havn´t found it

 

[Darkyvm]

Ok, found it, it's Level X - Data - Options, check visible (if you haven't already) and targeting image.

 

[Zacharias]

Ok, found it, it's Level X - Data - Options, check visible (if you haven't already) and targeting image.

Ahhh k got it thx for that.
Well, problem fixed, i´m happy now thx