Heal Event for GUI, version 1.1.1.1

[Bribe]

Any chance of updating heal event to work with GUI Unit Indexer 1.4.0.0 ? I was having issues awhile back and had to remove heal event from my map as it wasn't working with the 1.4 indexer, really like the system so would be great to add back in!

Why not use Unit Event? It's superior to GUI Unit Indexer and helps Heal Event perform better with regards to dead/transporting/reincarnating units. If Heal Event were modified to use Unit Indexer, you'd get a +600 Heal Event showing wherever a 600 HP unit is revived.

 

[Radski]

Why not use Unit Event? It's superior to GUI Unit Indexer and helps Heal Event perform better with regards to dead/transporting/reincarnating units. If Heal Event were modified to use Unit Indexer, you'd get a +600 Heal Event showing wherever a 600 HP unit is revived.

I already use GUI unit indexer 1.4 on my map for a respawn system. Heal event comes with a unit indexer but that indexer doesn't seem to work with my respawn system and unit indexer 1.4 doesn't work with heal event lol. Was just curious if it is possible to have them work together.

 

[Bribe]

I already use GUI unit indexer 1.4 on my map for a respawn system. Heal event comes with a unit indexer but that indexer doesn't seem to work with my respawn system and unit indexer 1.4 doesn't work with heal event lol. Was just curious if it is possible to have them work together.

Just delete Unit Indexer. Unit Event integrates it already.

 

[StangtennisGuru]

Hey Bribe tried this out together with Damage Engine 5.9 and Unit Event (not Unit Indexer) and have some questions. First I seem to have the same issue as Ugabunda described on the last page: random healing text showing up when units take damage (quoted below). And actually that's the only healing text I get, nothing from healing abilities (Priest Heal, Healing Wave etc.) or regen (I'm using the default On Heal text creator). I can tell its the Heal Adjust triggers causing the random text and when I add the "heal_inSys[(Custom value of DamageEventTarget)] Equal to True" condition they stop showing up, but still got no real heal text though.

Also, assuming I can get it to work, I need to be able to register healing for buildings/units with no movement speed in my map, what would I have to change to do that?

Lastly, am I correct in understanding that since GUI Unit Event uses Custom Values I'll be unable to use that for anything myself? I was hoping to use it to track the original owner of each unit.

Hi Bribe, I have a weird issue, which I narrowed down to 2 triggers from this system.

The problem is that in some cases when dealing damage, a heal text tag is created on the enemy unit. However, the healing tag should not have been created, as when checking 2 enemies that are hit by damage (one of them creating a healing tag, and the other doesn't), both have the same HP after the damage.

I couldn't exactly narrow down why some situations cause a healing tag to appear and others don't, but the 2 triggers that cause it are

• Heal Adjust On Damage
• Heal Adjust After Damage

When I turn these two triggers off, the wrong healing tag no longer appear.

Do you have an explanation for this?
And what do I "miss out" if I turn off these two triggers?


***

If you want to see what I'm talking about, I attached my map. Just select the Pig Hero at the top lane (Bristleback), and press Q when enemies start appearing. You should soon also see some random healing text tag appear on enemies when they are damaged by the Q ability.

 

[Bribe]

In "Heal Add Unit" there is a condition that checks if the movement speed is not equal to 0. That's the one to remove.

Ideally, this system should just be filtering out "useless units" from being added to the pool - so spellcaster dummies/unit-as-projectile kind of stuff. So the conditions in that trigger should vary between maps.

I was hoping to use it to track the original owner of each unit.

You can do that while being kind to Unit Indexer. Custom values are used by the indexer to create array-friendly integers that are simply unique to that unit, so these integers are used as entry points into parallel arrays. Therefore, you'll need an array for tracking the original owning player, and use the custom value as the index point to slot into the array, rather than modifying the custom value directly.

The text tags will work - provided that your map isn't overwriting custom values and that you tailor the "Heal Add Unit" conditions appropriately.

 

[StangtennisGuru]

In "Heal Add Unit" there is a condition that checks if the movement speed is not equal to 0. That's the one to remove.

Ideally, this system should just be filtering out "useless units" from being added to the pool - so spellcaster dummies/unit-as-projectile kind of stuff. So the conditions in that trigger should vary between maps.



You can do that while being kind to Unit Indexer. Custom values are used by the indexer to create array-friendly integers that are simply unique to that unit, so these integers are used as entry points into parallel arrays. Therefore, you'll need an array for tracking the original owning player, and use the custom value as the index point to slot into the array, rather than modifying the custom value directly.

The text tags will work - provided that your map isn't overwriting custom values and that you tailor the "Heal Add Unit" conditions appropriately.

Well alright the conditions are simple enough I see, that should be fine now, but there's definitely something wrong in my map cause it seems both versions of HealEvent never trigger unless its manual healing from the Heal Unit trigger (and I'm not currently overwriting custom values, I've checked and I don't use it anywhere atm). And the healing amounts are pretty large so they should definitely not fall below the thresholds

 

[Bribe]

Well alright the conditions are simple enough I see, that should be fine now, but there's definitely something wrong in my map cause it seems both versions of HealEvent never trigger unless its manual healing from the Heal Unit trigger (and I'm not currently overwriting custom values, I've checked and I don't use it anywhere atm). And the healing amounts are pretty large so they should definitely not fall below the thresholds

Please send me your map, I'll see if I can find the culprit. I'm guessing there is a vJass lib somewhere in your map that conflicts with the custom value.

 

[StangtennisGuru]

Alright, it's a messy mid patch version and you'll probably have a stroke if you look at my triggers, but here it is with Heal Event imported.

Edit: Removed messy map version now that the problem's been found.

 

[Bribe]

Steps I took:
1) Downloaded and opened map
2) See that there are 1999 triggers that need to load (you might think it would be hard to find the problem at this point).
3) Object Manager > Functions (admittedly this normally takes a long time, but sheesh).
4a) Found two places in the code that are setting the custom value:

4b) Found this:
Unit - Set the custom value of ConfusionUnit[1] to (Player number of (Owner of ConfusionUnit[1]))
--This needs to be changed to use the parallel array that I mentioned.
4c) Found this:
Unit - Set the custom value of (Triggering unit) to (Player number of (Owner of (Triggering unit)))
--Same deal - needs to be refactored to use the parallel array with existing unit's custom value as the index.
5) Checking for Function Call references:

These are fine.
6a) Check for it in the war3map.j file - produce an error:

6b) View error:

6c) Select all and copy into Notepad++
7) Search for SetUnitUserData... two results found?? What about UnitIndex or Unit Event? Were those disabled?
8) Search for GetUnitUserData... found in Heal Event triggers, yep, as expected. But also found in Unit Event.
9) Checked Unit Event for where it would call SetUnitUserData - this part is missing!

Conclusions:

• You still have a couple of areas of your code to clean up the setting of the custom value (and I've now pointed out where those are in a screenshot).
• You need to update to the latest version of vJass Unit Event, because you're using a version I made prior to integrating Unit Indexer into it.

 

[StangtennisGuru]

Steps I took:
1) Downloaded and opened map
2) See that there are 1999 triggers that need to load (you might think it would be hard to find the problem at this point).
3) Object Manager > Functions (admittedly this normally takes a long time, but sheesh).
4a) Found two places in the code that are setting the custom value:
View attachment 440318
4b) Found this:
Unit - Set the custom value of ConfusionUnit[1] to (Player number of (Owner of ConfusionUnit[1]))
--This needs to be changed to use the parallel array that I mentioned.
4c) Found this:
Unit - Set the custom value of (Triggering unit) to (Player number of (Owner of (Triggering unit)))
--Same deal - needs to be refactored to use the parallel array with existing unit's custom value as the index.
5) Checking for Function Call references:
View attachment 440319
These are fine.
6a) Check for it in the war3map.j file - produce an error:
View attachment 440320
6b) View error:
View attachment 440327

6c) Select all and copy into Notepad++
7) Search for SetUnitUserData... two results found?? What about UnitIndex or Unit Event? Were those disabled?
8) Search for GetUnitUserData... found in Heal Event triggers, yep, as expected. But also found in Unit Event.
9) Checked Unit Event for where it would call SetUnitUserData - this part is missing!

Conclusions:

• You still have a couple of areas of your code to clean up the setting of the custom value (and I've now pointed out where those are in a screenshot).
• You need to update to the latest version of vJass Unit Event, because you're using a version I made prior to integrating Unit Indexer into it.

Alright thanks I'll take a look at it. Weird thing is I did check for SetUnitUserData by intentionally producing an error and couldn't find anything then, but oh well. I just used the Unit Event that was included here, guess that one only works when you also have Unit Indexer, but I'll try with the newest one now.

 

[Nikac95]

Excellent!