hashtable parrent issued order, value unit type?

[Pinzu]

I want to store the order "humanbarracks" in a hash, and then be able to load by using issued order the unit type.

Not sure if this is wrong.

call SaveInteger(hash, S2I("humanbarracks"),0,'hbar')

i = LoadInteger(hash, GetIssuedOrderId(), 0)

 

[Ceday]

S2I converts a number string to integer, integer i = S2I("521")
You need to use other order function that converts an order to integer, String2OrderIdBJ("humanbarracks")

 

[edo494]

StringHash may work too, but Ceday's solution is a lot, lot, lot better, because every order has fixed id, and the game can give it to you if you give it a string, meanwhile StringHash is just assed function with a chance of colliding

 

[Pinzu]

S2I converts a number string to integer, integer i = S2I("521")
You need to use other order function that converts an order to integer, String2OrderIdBJ("humanbarracks")

This is wrong, not sure exactly why, but i Load 0 instead of the unit type.

set i = LoadInteger(hash, GetIssuedOrderId(), 0)

call SaveInteger(hash, OrderId("humanbarracks"),0,'hbar')

and if it can't find a match it will return 0 right? Debug states this statement is correct.

 

[Pinzu]

Any idea whats wrong with the load?

 

[Ceday]

No it is not wrong, I told you to use BJ function but you tried to be cool and didn't use it.You can look into BJ function for more details.

 

[Pinzu]

No it is not wrong, I told you to use BJ function but you tried to be cool and didn't use it.You can look into BJ function for more details.

I certainly tried to no avail. Your BJ function works though.

 

[Dr Super Good]

Just to round off with the reason why the BJ was used...

function String2OrderIdBJ takes string orderIdString returns integer
    local integer orderId
    set orderId = OrderId(orderIdString)
    if (orderId != 0) then
        return orderId
    endif
    set orderId = UnitId(orderIdString)
    if (orderId != 0) then
        return orderId
    endif
    return 0
endfunction

There are two separate natives used to convert order strings into order id numbers. In this case it must be using the native "UnitId" instead of "OrderId". As such it should be possible to inline with "UnitId" for better performance.