Moderator
M
Moderator
16 Dec 2011
Bribe: The code looks very good now. Approved 3/5 (useful). Please apply the changes below for a better rating.
What I meant by referencing the "Level" variable was to change the code to be like this:
I also recommend instead of a variable named "LastCreatedUnit" you could use "TempKey" (temporary hashtable key).
You should reference your variable "TempUnit" instead of calling (Picked unit) so many times (in the effect trigger). Well, reference "PickedUnit" I guess. Why do you have two variables that point to the same unit? A bit strange. Well just leave it as it is if it's too confusing. It doesn't break the spell it just could use some work for best results.
Please use the custom script "set bj_wantDestroyGroup = true" instead of setting your "TempGroup" variable. Currently it doesn't but it "could" cause leaks in rare cases. Better to just use "Custom script: set bj_wantDestroyGroup = true" right before picking all units. This way you don't need an extra group variable too.
Bribe: The code looks very good now. Approved 3/5 (useful). Please apply the changes below for a better rating.
What I meant by referencing the "Level" variable was to change the code to be like this:
- Set Level = (Level of A000 for (Triggering unit))
- Set Tornado_Count = (Level x 3)
- Set Caster_Point = (Position of (Triggering unit))
- Set TriggeringPlayer = (Triggering player)
- Set Travel_Range = ((Real(Level)) x 250.00)
- Set Speed = 340.00
- Set Damage = ((Real(Level)) x 75.00)
I also recommend instead of a variable named "LastCreatedUnit" you could use "TempKey" (temporary hashtable key).
You should reference your variable "TempUnit" instead of calling (Picked unit) so many times (in the effect trigger). Well, reference "PickedUnit" I guess. Why do you have two variables that point to the same unit? A bit strange. Well just leave it as it is if it's too confusing. It doesn't break the spell it just could use some work for best results.
Please use the custom script "set bj_wantDestroyGroup = true" instead of setting your "TempGroup" variable. Currently it doesn't but it "could" cause leaks in rare cases. Better to just use "Custom script: set bj_wantDestroyGroup = true" right before picking all units. This way you don't need an extra group variable too.