H&S RPG Systems v1.1b

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

22:41, 18th Jul 2012
Magtheridon96:

Comments

• You're leaking the fog modifiers. They should be stored upon creation and then destroyed when you don't need them anymore.
• The "Wait" inside the ViewFeatTree trigger should be removed. If you need a delay, you need to use a different method for it.
• You're leaking a fog modifier in the trigger that disables vision over the area. This is bad. You should be using only one array of fog modifiers, meaning one for each player, and you should only enable these fog modifiers and disable them. Don't create/destroy lots of them.
• This is totally not MUI/MPI as you're using variables in inappropriate places where you can't guarantee the fact that they have a certain value. In order to rid this resource of problems, you need to read a couple of tutorials about making systems/spells MUI/MPI, using periodic triggers, using arrays, hashtables, and a lot of other things.
• It would've been quite better if the Primary/Secondary/etc... triggers were split into many different triggers. Usually, one trigger per spell is best because it's easier for you to go through them.

This is in need of a lot of work.
Maybe this will help.

 

[Noobsmoke]

First Comment ^^
Your system definitly needs improvment.
-Full of leaks
-Lot of useless models

Skill Management System
-Can be improved by using repetitive functions

Feat Tree System
-Isn't MPI

Helpful Links :
Things That Leak

 

[Almia]

Pls put code or triggers post

 

[Deleted member 177737]

Pls put code or triggers post

It isn't that hard to wait 2 seconds for a download to finish and open up the map yourself.

 

[dangles20]

It isn't that hard to wait 2 seconds for a download to finish and open up the map yourself.

Yes but some people don't like to do that because they do not have direct access to a world editor but they want to review the code.

 

[WindowsVistaSucks]

It isn't that hard to wait 2 seconds for a download to finish and open up the map yourself.

And its not hard to copy and paste your code either.

 

[sonofjay]

I really like the idea, I actually think that it was awesome, but the execution on coding is not that great. Improve the code more and I can see this getting 4/5 if not 5/5.

 

[Orcnet]

concept is bad-ass but I'm slow in reading triggers, perhaps I'll wait for someone good with codes to rate this, by the way cool

 

[Kingz]

Bad execution, use of units as buttons is cool considering it's a GUI resource.
However... the use of imports is too much, this could be trimmed down to 2-3 models and 2-3 textures.
This offers zero customization...

The main problem is... the system isn't dynamically generated it's generated in WE by you putting stuff on the ground.
Also the lack of obvious MUI and MPI support is a big minus.

Also this kind of stuff should be easy to make with Anachron's custom window library =\
Also if i don't get burdened by exams too much you guys can expect a vJass easy-to-use version of such a system in a month or so ^^

 

[Adiktuz]

Concept is really nice but fact that it isn't even MPI makes it not really that useful...

The feat tree system can be made using Anachron's Window as Kingz said or even by just modifying the core of -Kobas-'s hero selection system which is available in both GUI and vJASS versions...

lastly, not a lot of people would want to download a 1MB+ test map...

 

[Strider121]

I reduced map size as much as I could, but still feat tree background image occupies almost whole map size. I know that this system can be made better but this is just my first try to post my own made system so you don't mind if it's not perfect. And as for map that it isn't MPI, I think that anyone who wants can modify it to become MPI. I also want to notice that a complete look of feat tree and all hero abilities modified via "Skill Management System" can be adjusted at will.

Anyway, thanks you all for comments!!!