[GUI] Split Shot v1.01

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

20:09, 5th Apr 2010
The_Reborn_Devil:
You still got a leak in there MortAr-

• Set Targets = (Random 1 units from (Units within 50.00 of ArrowMovePos))

^^ Leaks

Other than that it looks ok.


Status: Rejected until updated
Rating: N/A

PM me or another mod once you've updated the spell to get it reviewed again. Have a nice day!

 

[MortAr]

Comment, rate, report bugs/errors via comments or via PM/VM.
Thank you.

 

[Etzer]

Please add the Triggers to description.

 

[MortAr]

Yea, added the triggers, sorry I forgot them in the first place.

 

[Etzer]

Looks good, but you forgot to remove ArrowGroup. (Call Remove Group)

 

[VoidLordXtreme]

i think its not needed to remove ArrowGroup since it would make the spell not MUI (i think)

if the group is removed the spell will not work anymore. its one global group so it wont leak.

the triggering looks very nice and its performs awesome ingame
i have to rate it a 5/5 good job

i might use it someday... i will give credits ofc.

 

[krisserz]

I don`t understand why you set all the arrow data (damage, range, etc.) inside for each...
You should put them before it and then only save data in for each...
That`s just useless counting of same thing again and again...

 

[88WaRCraFT3]

This trigger can be like

• Unit - A unit Starts the effect of an ability
  • Conditions
  • (Ability being cast) Equal to Split Shot
  • Actions
  • -------- ----------------------------------------------------------------------------------- --------
  • -------- Starting the loop for the spell. The level of the ability determines the number of arrows --------
  • -------- ----------------------------------------------------------------------------------- --------
  • For each (Integer Loop_Int) from 1 to ((Level of Split Shot for (Triggering unit)) x 3), do (Actions)
  • Loop - Actions
  • Set CastPos = (Position of (Triggering unit))
  • -------- ----------------------------------------------------------------------------------- --------
  • -------- All the configurations needed before 1 arrow is created --------
  • -------- ----------------------------------------------------------------------------------- --------
  • Set ArrowDamage = 100.00
  • Set ArrowRange = 600.00
  • Set ArrowSpeed = (ArrowRange x 0.03)
  • Set ArrowLifeTime = 1.50
  • Set AbilityLevel = (Level of (Ability being cast) for (Triggering unit))
  • Set ArrowAngle = ((Facing of (Triggering unit)) + (Random real number between 1.00 and 30.00))
  • Set ArrowFullDamage = (ArrowDamage x (Real(AbilityLevel)))
  • -------- ----------------------------------------------------------------------------------- --------
  • -------- Creating an arrow --------
  • -------- ----------------------------------------------------------------------------------- --------
  • Unit - Create 1 Arrow for (Owner of (Triggering unit)) at (CastPos offset by 50.00 towards ArrowAngle degrees) facing ArrowAngle degrees
  • Set ArrowLoop = (Last created unit)
  • -------- ----------------------------------------------------------------------------------- --------
  • -------- All the settings are saved for the UNIT into our hashtable --------
  • -------- ----------------------------------------------------------------------------------- --------
  • Hashtable - Save ArrowAngle as (Key angle) of (Key (Last created unit)) in SpellHashtable
  • Hashtable - Save ArrowFullDamage as (Key damage) of (Key (Last created unit)) in SpellHashtable
  • Hashtable - Save ArrowRange as (Key range) of (Key (Last created unit)) in SpellHashtable
  • Hashtable - Save ArrowSpeed as (Key speed) of (Key (Last created unit)) in SpellHashtable
  • Hashtable - Save ArrowLifeTime as (Key time) of (Key (Last created unit)) in SpellHashtable
  • -------- ----------------------------------------------------------------------------------- --------
  • -------- Finally we are read to run the loop trigger. --------
  • -------- ----------------------------------------------------------------------------------- --------
  • Unit Group - Add ArrowLoop to ArrowGroup
  • Custom script: call RemoveLocation (udg_CastPos)
  • Trigger - Turn on SplitShot Loop <gen>

This trigger

• SplitShot Cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Split Shot
  • Actions
    • -------- ----------------------------------------------------------------------------------- --------
    • -------- Starting the loop for the spell. The level of the ability determines the number of arrows --------
    • -------- ----------------------------------------------------------------------------------- --------
    • For each (Integer Loop_Int) from 1 to ((Level of Split Shot for (Triggering unit)) x 3), do (Actions)
      • Loop - Actions
        • Set CastPos = (Position of (Triggering unit))
        • Set TargPos = (Target point of ability being cast)
        • -------- ----------------------------------------------------------------------------------- --------
        • -------- All the configurations needed before 1 arrow is created --------
        • -------- ----------------------------------------------------------------------------------- --------
        • Set ArrowDamage = 100.00
        • Set ArrowRange = 1200.00
        • Set ArrowSpeed = (ArrowRange x 0.03)
        • Set ArrowLifeTime = 1.50
        • Set AbilityLevel = (Level of (Ability being cast) for (Triggering unit))
        • Set Angle = (Angle from CastPos to TargPos)
        • Set ArrowAngle = (Angle + (Random real number between 0.00 and 15.00))
        • Set ArrowFullDamage = (ArrowDamage x (Real(AbilityLevel)))
        • -------- ----------------------------------------------------------------------------------- --------
        • -------- Creating an arrow --------
        • -------- ----------------------------------------------------------------------------------- --------
        • Unit - Create 1 Arrow for (Owner of (Triggering unit)) at (CastPos offset by 50.00 towards ArrowAngle degrees) facing Angle degrees
        • Set ArrowLoop = (Last created unit)
        • -------- ----------------------------------------------------------------------------------- --------
        • -------- All the settings are saved for the UNIT into our hashtable --------
        • -------- ----------------------------------------------------------------------------------- --------
        • Hashtable - Save ArrowAngle as (Key angle) of (Key (Last created unit)) in SpellHashtable
        • Hashtable - Save ArrowFullDamage as (Key damage) of (Key (Last created unit)) in SpellHashtable
        • Hashtable - Save ArrowRange as (Key range) of (Key (Last created unit)) in SpellHashtable
        • Hashtable - Save ArrowSpeed as (Key speed) of (Key (Last created unit)) in SpellHashtable
        • Hashtable - Save ArrowLifeTime as (Key time) of (Key (Last created unit)) in SpellHashtable
        • -------- ----------------------------------------------------------------------------------- --------
        • -------- Finally we are read to run the loop trigger. --------
        • -------- ----------------------------------------------------------------------------------- --------
        • Unit Group - Add ArrowLoop to ArrowGroup
        • Custom script: call RemoveLocation (udg_CastPos)
        • Custom script: call RemoveLocation (udg_TargPos)
    • Trigger - Turn on SplitShot Loop <gen>

But i'm not realy sure, try it.

 

[MortAr]

I don`t understand why you set all the arrow data (damage, range, etc.) inside for each...
You should put them before it and then only save data in for each...
That`s just useless counting of same thing again and again...

You are right for the group, its a global and if its destroyed it will malfunction the whole spell. Im happy you like it.

I don`t understand why you set all the arrow data (damage, range, etc.) inside for each...
You should put them before it and then only save data in for each...
That`s just useless counting of same thing again and again...

If you put the settngs outside the loop, all arrows will have the same angle.

This trigger can be like

• Unit - A unit Starts the effect of an ability
  • Conditions
  • (Ability being cast) Equal to Split Shot
  • Actions
  • -------- ----------------------------------------------------------------------------------- --------
  • -------- Starting the loop for the spell. The level of the ability determines the number of arrows --------
  • -------- ----------------------------------------------------------------------------------- --------
  • For each (Integer Loop_Int) from 1 to ((Level of Split Shot for (Triggering unit)) x 3), do (Actions)
  • Loop - Actions
  • Set CastPos = (Position of (Triggering unit))
  • -------- ----------------------------------------------------------------------------------- --------
  • -------- All the configurations needed before 1 arrow is created --------
  • -------- ----------------------------------------------------------------------------------- --------
  • Set ArrowDamage = 100.00
  • Set ArrowRange = 600.00
  • Set ArrowSpeed = (ArrowRange x 0.03)
  • Set ArrowLifeTime = 1.50
  • Set AbilityLevel = (Level of (Ability being cast) for (Triggering unit))
  • Set ArrowAngle = ((Facing of (Triggering unit)) + (Random real number between 1.00 and 30.00))
  • Set ArrowFullDamage = (ArrowDamage x (Real(AbilityLevel)))
  • -------- ----------------------------------------------------------------------------------- --------
  • -------- Creating an arrow --------
  • -------- ----------------------------------------------------------------------------------- --------
  • Unit - Create 1 Arrow for (Owner of (Triggering unit)) at (CastPos offset by 50.00 towards ArrowAngle degrees) facing ArrowAngle degrees
  • Set ArrowLoop = (Last created unit)
  • -------- ----------------------------------------------------------------------------------- --------
  • -------- All the settings are saved for the UNIT into our hashtable --------
  • -------- ----------------------------------------------------------------------------------- --------
  • Hashtable - Save ArrowAngle as (Key angle) of (Key (Last created unit)) in SpellHashtable
  • Hashtable - Save ArrowFullDamage as (Key damage) of (Key (Last created unit)) in SpellHashtable
  • Hashtable - Save ArrowRange as (Key range) of (Key (Last created unit)) in SpellHashtable
  • Hashtable - Save ArrowSpeed as (Key speed) of (Key (Last created unit)) in SpellHashtable
  • Hashtable - Save ArrowLifeTime as (Key time) of (Key (Last created unit)) in SpellHashtable
  • -------- ----------------------------------------------------------------------------------- --------
  • -------- Finally we are read to run the loop trigger. --------
  • -------- ----------------------------------------------------------------------------------- --------
  • Unit Group - Add ArrowLoop to ArrowGroup
  • Custom script: call RemoveLocation (udg_CastPos)
  • Trigger - Turn on SplitShot Loop <gen>

This trigger

• SplitShot Cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Split Shot
  • Actions
    • -------- ----------------------------------------------------------------------------------- --------
    • -------- Starting the loop for the spell. The level of the ability determines the number of arrows --------
    • -------- ----------------------------------------------------------------------------------- --------
    • For each (Integer Loop_Int) from 1 to ((Level of Split Shot for (Triggering unit)) x 3), do (Actions)
      • Loop - Actions
        • Set CastPos = (Position of (Triggering unit))
        • Set TargPos = (Target point of ability being cast)
        • -------- ----------------------------------------------------------------------------------- --------
        • -------- All the configurations needed before 1 arrow is created --------
        • -------- ----------------------------------------------------------------------------------- --------
        • Set ArrowDamage = 100.00
        • Set ArrowRange = 1200.00
        • Set ArrowSpeed = (ArrowRange x 0.03)
        • Set ArrowLifeTime = 1.50
        • Set AbilityLevel = (Level of (Ability being cast) for (Triggering unit))
        • Set Angle = (Angle from CastPos to TargPos)
        • Set ArrowAngle = (Angle + (Random real number between 0.00 and 15.00))
        • Set ArrowFullDamage = (ArrowDamage x (Real(AbilityLevel)))
        • -------- ----------------------------------------------------------------------------------- --------
        • -------- Creating an arrow --------
        • -------- ----------------------------------------------------------------------------------- --------
        • Unit - Create 1 Arrow for (Owner of (Triggering unit)) at (CastPos offset by 50.00 towards ArrowAngle degrees) facing Angle degrees
        • Set ArrowLoop = (Last created unit)
        • -------- ----------------------------------------------------------------------------------- --------
        • -------- All the settings are saved for the UNIT into our hashtable --------
        • -------- ----------------------------------------------------------------------------------- --------
        • Hashtable - Save ArrowAngle as (Key angle) of (Key (Last created unit)) in SpellHashtable
        • Hashtable - Save ArrowFullDamage as (Key damage) of (Key (Last created unit)) in SpellHashtable
        • Hashtable - Save ArrowRange as (Key range) of (Key (Last created unit)) in SpellHashtable
        • Hashtable - Save ArrowSpeed as (Key speed) of (Key (Last created unit)) in SpellHashtable
        • Hashtable - Save ArrowLifeTime as (Key time) of (Key (Last created unit)) in SpellHashtable
        • -------- ----------------------------------------------------------------------------------- --------
        • -------- Finally we are read to run the loop trigger. --------
        • -------- ----------------------------------------------------------------------------------- --------
        • Unit Group - Add ArrowLoop to ArrowGroup
        • Custom script: call RemoveLocation (udg_CastPos)
        • Custom script: call RemoveLocation (udg_TargPos)
    • Trigger - Turn on SplitShot Loop <gen>

But i'm not realy sure, try it.

No, you are really wrong here, sir.

 

[krisserz]

If you put the settngs outside the loop, all arrows will have the same angle.

So keep the angle inside the loop but the rest is not needed here.

 

[Maker]

Do the "turn off" check only after removing a unit from the group.

Only load the timer, then check whether it is > 0 or not. Then load the other values, set the unit group and the new position if it is greater.

 

[Kala]

Cool spell =)

 

[Guishiu]

You know what would be nice that I haven't seen yet, this spell but it triggers when the unit attacks.

It would be like multi-shot but instead of the attacker being able to target 50 guys at once in all directions (something I always thought was stupid) the shooter would just launch mulitiple projectiles in the direction of attack. I suppose if I just took your trigger here and linked it to Critical Strike with a 100% chance and 0% multiplier it could do this?

=D

 

[Doom_AngeaL]

Looks nice altogether. I'll use this in my map I'm working on, for a ranger-type hero. But I see a leak.

• Set Targets = (Random 1 units from (Units within 50.00 of ArrowMovePos))

 

[MortAr]

Looks nice altogether. I'll use this in my map I'm working on, for a ranger-type hero. But I see a leak.

• Set Targets = (Random 1 units from (Units within 50.00 of ArrowMovePos))

If you want you can fix it by yourself, I'm way too busy IRL to update the spell.

 

[Doom_AngeaL]

If you want you can fix it by yourself, I'm way too busy IRL to update the spell.

Touche; I can't trig for my life anywho, just presenting the case( Didn't know if you noticed or someone else told you yet.)

 

[SilverLeaf]

*cough*
(Line: 1) (Word: 4) Unit Group Leak
(Random 1 units from (Units within 50.00 of ArrowMovePos))
(Random 1 units from ^Leak
(Suggested Fix) Set MyUnitGroup = (Units within 50.00 of ArrowMovePos))
(Suggested Fix) (Random 1 units from MyUnitGroup ArrowMovePos))
(Suggested Fix) Custom script: call DestroyGroup(udg_MyUnitGroup)

Scan Complete
Location leaks: 0
Special Effect leaks: 0
Lightning leaks: 0
Unit Group leaks: 1
Player Group leaks: 0

Summary
Total Leaks: 1
Unremoved Variables: 0
Scan duration: 0 seconds
Total Lines Scanned: 1
Total Words Scanned: 9
*cough*
Someone didnt use leakcheck

 

[Hornacken]

the arrows only fligh to the left side of the point where the ability is beiing cast

 

[IronForge]

yes, of course. You could change it yourself to fire in whatever angle you want. 0 is straight ahead. I set it to -15 to 15

 

[abcde]

Hi nice spell also I want to use it in my map but I have a question why does
Set Targets = (Random 1 units from (Units within 50.00 of ArrowMovePos)) it leaks?
Please tell me how to fix that

 

[Legal_Ease]

This is a good idea, but there is an issue with flying height. The arrows zoom up and over terrain like a flying unit. It's not realistic and can easily be fixed. This spell seems a bit hurried and not well thought out. I am surprised no one else has done it since it is a dota classic. It could be fine tuned to be really sweet, but right now it's just so so.

 

[polatgeyik]

At times, shots are fired a few units to the left of my intended target, I even experience this in one out of every two shots.

 

[Pyrogasm]

At times, shots are fired a few units to the left of my intended target, I even experience this in one out of every two shots.

The angle computation for each arrow is massively biased to the left:

• Set ArrowAngle = ((Facing of (Triggering unit)) + (Random real number between 1.00 and 30.00))

You can change this logic to make the spread work however you want it to. Could be deterministic, lower variance, variance both + and -, or something else that suits your needs.