GUI Spell Setup

[mckill2009]

I do not know where to put this coz this is only a suggestion for the rule of GUI spell submissions, whenever I import something. object first then triggers, it's a pain the the ass to put the correct SPELLID to the trigger, why coz it's messed up if you have many other custom abilities in your map, didn't get me?

This [thread=151395]Spell[/thread] for example and many others, when I import it to my map, it displays like this;

Hidden

• Sphere I Spell Init
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Great Possesion
  • Actions
    • -------- ================= --------
    • -------- Sets the location of units --------
    • Set Sloc[1] = (Position of (Triggering unit))
    • Set Sloc[2] = (Position of (Target unit of ability being cast))
    • -------- ================= --------
    • -------- Sets all values, which are for later use - to see what the values do, check the trigger comment --------
    • Set SphereValue[1] = ((Integer((Distance between Sloc[1] and Sloc[2]))) + 300)
    • -------- You can change the values below --------
    • Set SphereValue[2] = ((Level of Great Possesion for (Triggering unit)) x (Intelligence of (Triggering unit) (Include bonuses)))
    • Set SphereValue[3] = ((20 + (10 x (Level of Great Possesion for (Triggering unit)))) + ((Intelligence of (Triggering unit) (Include bonuses)) x 2))
    • Set SphereValue[4] = ((((Level of Great Possesion for (Triggering unit)) x 25) / 3) + ((Intelligence of (Triggering unit) (Include bonuses)) / 2))
    • Set SphereValue[5] = (1 + (Level of Great Possesion for (Triggering unit)))

The "Great Possesion" spell is in my map but it's not the correct spell for this...so I have to change ALL the SphereValue to the correct spell...really it's a pain in the ass, imagine if you'll change more or the clicks in levels...

Solution:
It cannot be avoided but can be minimize by making a variable at setup to store that particular spell then change ONLY the variable value...

Hidden

• Sphere I Map Init
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- ================= --------
    • -------- Spell AbilityID --------
    • Set SP = Chaotic Sphere

• Sphere I Spell Init
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to SP
  • Actions
    • -------- ================= --------
    • -------- Sets the location of units --------
    • Set Sloc[1] = (Position of (Triggering unit))
    • Set Sloc[2] = (Position of (Target unit of ability being cast))
    • -------- ================= --------
    • -------- Sets all values, which are for later use - to see what the values do, check the trigger comment --------
    • Set SphereValue[1] = ((Integer((Distance between Sloc[1] and Sloc[2]))) + 300)
    • -------- You can change the values below --------
    • Set SphereValue[2] = ((Level of SP for (Triggering unit)) x (Intelligence of (Triggering unit) (Include bonuses)))
    • Set SphereValue[3] = ((20 + (10 x (Level of SP for (Triggering unit)))) + ((Intelligence of (Triggering unit) (Include bonuses)) x 2))
    • Set SphereValue[4] = ((((Level of SP for (Triggering unit)) x 25) / 3) + ((Intelligence of (Triggering unit) (Include bonuses)) / 2))
    • Set SphereValue[5] = (1 + (Level of SP for (Triggering unit)))

Now, I'd like to request to implement this as a rule that a setup must be created, not only for spells ability objects but for ALL custom objects, like buffs and units...

NOTE:
If anyone can fix this problem without setup, this thread maybe removed...

EDIT:
Also, I already checked and uncheked the 'Automatically create unknown variables while pasting trigger data' (which doesnt really relates objects btw)

 

[Maker]

I require people to add that into importing instructions and also recommend them to use a variable for units and abilities in my reviews.

A lot of people do not realize that the raw codes can change between maps. This is a good suggestion, but I'm not sure if we can require people to do that.

 

[Ralle]

Yes, it is indeed a good idea. I don't mind if the moderators begin enforcing this.

 

[mckill2009]

so better to add this as a requirement or move this in the tutorial's section?

 

[Adiktuz]

I thought it was already a rule... anyway, its better off to put it as a rule and also put it into the GUI tutorial.... It's a good triggering practice anyway...

 

[Ralle]

I will add this to the spells section rules.

 

[Ralle]

How do you like this new rule?

• Spells must be easy to import, use variables for ability names so they are easy to replace, require as few changes possible when importing.

 

[Maker]

Ability name is a string, and there is an event response for that. GetObjectName in jass. We don't really care about that

We care about the ability's raw code, GetSpellAbilityId. It is an integer. However in GUI there is the ability variable type for it.

And often dummy units are created inside the code, they would also need variables used for them. So let' not make this apply to abilities only.

 

[Ralle]

Good point, but later in the text I generalised it to make it as easy to import as possible.

 

[Maker]

It still says "use variables for ability names" which is not what we want and might just add confusion.

It could be rephrased to "use variables for abilities". Which then again could be chaged to "use variables for object editor data, for example for abilities and unit types". Or something that conveys the same message.

 

[mckill2009]

Not only abilitie's raw code but ALL that's in the object editor that needs to be imported by a particular spell/system...

Units and buffs for example, some spells use custom unit effects and buffs, it will have the same problems as abilities...

 

[Ralle]

It still says "use variables for ability names" which is not what we want and might just add confusion.

It could be rephrased to "use variables for abilities". Which then again could be chaged to "use variables for object editor data, for example for abilities and unit types". Or something that conveys the same message.

I have added the text you suggested.

 

[Magtheridon96]

• Spell and System triggers/JASS code must allow easy configuration of abilities, items, units, buffs and the like via constant variables set on map initialization in one isolated trigger and/or global variable block.

Feel free to improve that :v

edit
Oh, nevermind, this thing's been done already