[ GUI ] Moving With Arrow Keys v.2.0

[Moderator]

18:17, 7th Dec 2009
TriggerHappy:

Review for Spell

We do not need any more of these. There are already like 5 of them.

Status

Rejected

 

[WherewolfTherewolf]

Well so far the triggering looks fine and for that its a +, but the overall concept is pretty tired and already done many times in Jass that cause less delay then GUI. Though It seems like a good system I'm not sure its going to get approved simply for the fact that the concept is nothing new.

 

[Tige_R]

you are right.
this system was approved before.
but removed coz 1.24 version.

 

[real138]

Looks good:

No leaks that i could see.
nice documentation.
good thing its down from 70 triggers @_@
not a new idea though.

so ill give it a 4/5 gj
Idea: 2
Documentation: 5
Efficiency: 5
Leak removal: 5
4.25/5 = 4/5

 

[Tige_R]

thanks For the Feedback

 

[WherewolfTherewolf]

How could a movement system which you have well condensed here possibly require 70 triggers?


Anyways, you might want to consider throwing in camera control while your at it (basically move the camera with the unit to get a third or first person perspective, could be easily added into your move trigger) to give your system some more appeal (and to account for the masses of lazy people who wouldn't do this themselves).

 

[Tige_R]

How could a movement system which you have well condensed here possibly require 70 triggers?

this is was my first thing i have created in WC3 , i was a noob xD , didn't even read how to create a spell , it was like 10 triggers for each player.
but now i am good.

 

[Kingz]

I guess you should add some more stuff if you ask me, i got some ideas for it that would make it really nice:

-trails, if you are moving with cursors and have this enabled, moving through shallow water would cause some effects to be spawned(water splashing). Could aply for dirt also.

-adding strafe on/off option, meaning you can use some keys to strafe your character.

-adding camera option as WherewolfTherewolf suggested, possibly an option that is turned on/off easily.

-if i think of something else i will let you know.

If you need help with that PM me.

EDIT:
This system had more than 70 trigs as far as i remember, you used to use 9*12 + 3 triggers in the system, totaling a bunch of 111 triggers.

 

[hell gate]

here is the short version of the player press .... or relaise .... : (JASS)

Arrows

function Trig_Arrows_LEFT_DOWN takes nothing returns nothing
	set udg_KM_Left[GetPlayerId(GetTriggerPlayer())+1] = true
endfunction

function Trig_Arrows_LEFT_UP takes nothing returns nothing
	set udg_KM_Left[GetPlayerId(GetTriggerPlayer())+1] = false
endfunction

function Trig_Arrows_RIGHT_DOWN takes nothing returns nothing
	set udg_KM_Right[GetPlayerId(GetTriggerPlayer())+1] = true
endfunction

function Trig_Arrows_RIGHT_UP takes nothing returns nothing
	set udg_KM_Right[GetPlayerId(GetTriggerPlayer())+1] = false
endfunction

function Trig_Arrows_DOWN_DOWN takes nothing returns nothing
	set udg_KM_Down[GetPlayerId(GetTriggerPlayer())+1] = true
endfunction

function Trig_Arrows_DOWN_UP takes nothing returns nothing
	set udg_KM_Down[GetPlayerId(GetTriggerPlayer())+1] = false
endfunction

function Trig_Arrows_UP_DOWN takes nothing returns nothing
	set udg_KM_Up[GetPlayerId(GetTriggerPlayer())+1] = true
endfunction

function Trig_Arrows_UP_UP takes nothing returns nothing
	set udg_KM_Up[GetPlayerId(GetTriggerPlayer())+1] = false
endfunction

function Trig_Arrows_CreateTrigger takes code actionFunc, playerevent eventId returns nothing
	local trigger t = CreateTrigger()
	local integer PlayerId = 0
	call TriggerAddAction(t, actionFunc)
	loop
		exitwhen PlayerId > 11
		call TriggerRegisterPlayerEvent(t, Player(PlayerId), eventId)
		set PlayerId = PlayerId + 1
	endloop
	set t = null
endfunction

//===========================================================================
function InitTrig_Arrows takes nothing returns nothing
	call Trig_Arrows_CreateTrigger(function Trig_Arrows_LEFT_DOWN, EVENT_PLAYER_ARROW_LEFT_DOWN)
	call Trig_Arrows_CreateTrigger(function Trig_Arrows_LEFT_UP, EVENT_PLAYER_ARROW_LEFT_UP)
	call Trig_Arrows_CreateTrigger(function Trig_Arrows_RIGHT_DOWN, EVENT_PLAYER_ARROW_RIGHT_DOWN)
	call Trig_Arrows_CreateTrigger(function Trig_Arrows_RIGHT_UP, EVENT_PLAYER_ARROW_RIGHT_UP)
	call Trig_Arrows_CreateTrigger(function Trig_Arrows_DOWN_DOWN, EVENT_PLAYER_ARROW_DOWN_DOWN)
	call Trig_Arrows_CreateTrigger(function Trig_Arrows_DOWN_UP, EVENT_PLAYER_ARROW_DOWN_UP)
	call Trig_Arrows_CreateTrigger(function Trig_Arrows_UP_DOWN, EVENT_PLAYER_ARROW_UP_DOWN)
	call Trig_Arrows_CreateTrigger(function Trig_Arrows_UP_UP, EVENT_PLAYER_ARROW_UP_UP)
endfunction

 

[Kingz]

First of all that is inneficent jass, second you used user defined globals == bad.

Making such systems in Jass is a piece of cake, i dunno why you posted that reply here hellgate

 

[real138]

he wanted to prove that you can do it with jass much shorter eh lol

 

[WherewolfTherewolf]

There's no challenge in making an efficient Arrow Key movement in Jass, GUI is where the fun is at.

-Yeah Strafe should be something standard with arrow key movement, it's good for FPS concepts, puzzles, rpg's and pretty much any other concept that includes a third person camera.

 

[real138]

haha true jass is too easy to do that

 

[Tige_R]

sry for the late answer

-adding strafe on/off option, meaning you can use some keys to strafe your character.

sry but what do u mean by that? xD [my bad English >.<]

-trails, if you are moving with cursors and have this enabled, moving through shallow water would cause some effects to be spawned(water splashing). Could aply for dirt also.

i have tried to make trails but i think its cant be done:

1.there its no terrain for the water so i cant add splash :/
2.there its no Good Special effect for Terrains like dirt.

i think i found a good special effect for lava xD

-adding camera option as WherewolfTherewolf suggested, possibly an option that is turned on/off easily.

i have added a way to turn it on/off

 

[Kingz]

1.there its no terrain for the water so i cant add splash :/

You could check unit pathing for water afaik.

2.there its no Good Special effect for Terrains like dirt.

Sure there is

EDIT:

Strafe = moving left or right with the keys, not rotating.
It should be toggleable if you ask me.

 

[GoGoTauren]

strafing would be being able to move sideways and backwards with your character facing the same direction
itd be really cool if you could add that... like wherewolf said it could be useful for heaps of games with a first person camera.

Also, could you make the camera height match the height of the unit when it's moving over higher ground? itd be much more useful for my map ^^

 

[LordAragorn]

Bug?

The System works only for red not for blue....
pls fix that =)
need it for my map