[GUI] Dynamic Kill Scoreboard

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

13:44, 17th Jul 2012
Magtheridon96:

Comments

Currently, this isn't very modular.
I think you shouldn't handle assists and kills.
You should allow the user to configure an update trigger.
In that trigger, he would assign the new values for kills, assists, deaths, and all kinds of things.
To make this more configurable, you should use a hashtable.
In the hashtable, you would use the first key as a player index and the second as an index for whatever you want to store.
(For example, if 1 -> Kills and 2 -> Deaths, then the keys 5,2 would point to Player 5's deaths.)
Also, there are null icons showing up in the multiboard. You should only show icons where it's needed.

See, a multiboard system needs to allow users to create their very own multiboard.
This is in need of a major update.

If you can actually pull this off and make a "Make-Your-Own" Multiboard system, then it would get a 4.1/5 from me.

Thank you for the submission.
Good luck.

 

[Magtheridon96]

You don't need to use the "leaves with defeat events", the "leaves" events will suffice.
Also, there's no linked list in there o-o
You don't need one though.

 

[shadowvzs]

You don't need to use the "leaves with defeat events", the "leaves" events will suffice.
Also, there's no linked list in there o-o
You don't need one though.

updated

about linked list, i thought linked list when u make this
index = index +1
data1[index] = blabla
data2[index] = blabla
data3[index] = blabla

and i use it for order the multiboard for correct order also for remove player. this easier than check everyplayer, if example have 3 user player then i check 3 player

 

[Noobsmoke]

QUOTE: "- system detect the highest damage dealer, so killer is who dealed the highest damage and not who last hited the boss"

Healers are going to kill you

 

[shadowvzs]

QUOTE: "- system detect the highest damage dealer, so killer is who dealed the highest damage and not who last hited the boss"

Healers are going to kill you

if killer do atleast 1 dmg then he get assist too but be serious, what game where the healer the killer? mostly in mmorpg example allways have healer+tank+damage dealer. since this not about drop and exp share, i think its ok, mainly because mostly i guess have less game where healer allways just heal somebody at boss and do 0 damage.

in my map i made damage based experience, there i check if assisters are ally of killer, then assisters also get similiar exp but i guess here this useless.

 

[Magtheridon96]

Actually:

set index = index + 1
set data1[index] = x
set data2[index] = y
set data3[index] = z

is a simple array.

A linked list is:

set index = allocateIndex()

set next[index] = 0
set prev[index] = prev[0]
set next[prev[0]] = index
set prev[0] = index

And it's only useful for fast iteration in Jass.
Here, you wouldn't benefit much from using a linked list.

 

[shadowvzs]

Actually:

set index = index + 1
set data1[index] = x
set data2[index] = y
set data3[index] = z

is a simple array.

A linked list is:

set index = allocateIndex()

set next[index] = 0
set prev[index] = prev[0]
set next[prev[0]] = index
set prev[0] = index

And it's only useful for fast iteration in Jass.
Here, you wouldn't benefit much from using a linked list.

allocatindex function just increase the index by 1, right?
next and prev is global or local?
what is prev[0] ? is 0 or last stored index? (how i hate the this multiple array index things )

ah, then seems isnt linked list just array job what i made, other side u got any downside with my trigger working?

 

[Magtheridon96]

No, it doesn't increase it by 1, it finds an index either by adding 1 if there are no instances to recycle, but if there is something to recycle, it would just use that.

This is what we call Dynamic Indexing.

To allocate an index, all you need is an integer array and an integer (recycler[] and count)

You find an index like this:

set index = recycler[0]

if index == 0 then
    set count = count + 1
    set index = count
else
    set recycler[0] = recycler[index]
endif

You recycle an index (meaning deallocate) like this:

set recycler[index] = recycler[0]
set recycler[0] = index

You would loop from 1 to count to iterate through all instances.
This isn't the best solution when you're allocating a lot of instances, then deallocating a lot, but trust me, it's fine.

 

[Adiktuz]

the real killer is always the one who deals the killing blow...

at the very least you can add the option to configure the killer part so the user can choose if it will be the real killer or the one who dealt most damage...

 

[shadowvzs]

the real killer is always the one who deals the killing blow...

at the very least you can add the option to configure the killer part so the user can choose if it will be the real killer or the one who dealt most damage...

if u ever player mmorpg like perfect world, muonline there not the killing blow important, the most of damage, what the mob drop (if attacker dont was in party/squade) then the highest damage dealer could pick, this way u avoid the kill steal, example when u attack a mob longer than coming somebody and last hit the mob its fair if he get the kill only coz he last hitted? i doubt

anyway u can customize the points in settings for last hit and kill also the column names, so u can rename to highest damage, as u want, there is the settings trigger

You would loop from 1 to count to iterate through all instances.
This isn't the best solution when you're allocating a lot of instances, then deallocating a lot, but trust me, it's fine.

then where have adcantage from it? (a bit annoying when sombody post vjass then i cant decide what was global and what was local )

so overall its something like this?

function Trig_increase_Actions takes nothing returns nothing
set udg_index = allocate()
set udg_next[udg_index] = 0
set udg_prev[udg_index] = udg_prev[0]
set udg_next[udg_prev[0]] = udg_index
set udg_prev[0] = udg_index
endfunction

//===========================================================================
function InitTrig_increase takes nothing returns nothing
    set gg_trg_increase = CreateTrigger(  )
    call TriggerRegisterPlayerChatEvent( gg_trg_increase, Player(0), "1", true )
    call TriggerAddAction( gg_trg_increase, function Trig_increase_Actions )
endfunction

function Trig_rnd_decrease_Actions takes nothing returns nothing
call deallocate(GetRandomInt(0,udg_index))
endfunction

//===========================================================================
function InitTrig_rnd_decrease takes nothing returns nothing
    set gg_trg_rnd_decrease = CreateTrigger(  )
    call TriggerRegisterPlayerChatEvent( gg_trg_rnd_decrease, Player(0), "2", true )
    call TriggerAddAction( gg_trg_rnd_decrease, function Trig_rnd_decrease_Actions )
endfunction

function allocate takes nothing returns integer
local integer this = udg_prev[0]
  if this == 0 then
        set udg_index = udg_index + 1
        return udg_index
  endif
set udg_prev[0] = udg_prev[this]
return this
endfunction

function deallocate takes integer this returns nothing
    set udg_prev[this] = udg_prev[0]
    set udg_prev[0] = this
endfunction

 

[Magtheridon96]

._.
No.

I just realized you don't need a linked list or indexing ._.

 

[shadowvzs]

._.
No.

I just realized you don't need a linked list or indexing ._.

y but i am curios, ok its off, and isnt about this multiboard just i try understand again