GUI Damage Detection Problem

[Palooo3]

Hello Guys, So I have tried to make a block chance based on hero's items.
Block = Reduce incoming damage by 50% (does not count spells, only normal attacks.)
I have several problems here.
I am not sure if it blocks damage and I don't know a way how to decet it.
Whenever hero block damage I want floating text around him saying "Block"


Note: I'm using https://www.hiveworkshop.com/forums...1016/?prev=search=damage%20engine&d=list&r=20


Setup Items

• BlockDatabase
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Hashtable - Create a hashtable
    • Set IBlock_Table = (Last created hashtable)
    • Set IBlock_IType = Block + 85%
    • Custom script: set udg_IBlock_I1 = udg_IBlock_IType
    • Hashtable - Save 85 as 0 of IBlock_I1 in IBlock_Table
    • Set IBlock_IType = Block + 5%
    • Custom script: set udg_IBlock_I1 = udg_IBlock_IType
    • Hashtable - Save 5 as 0 of IBlock_I1 in IBlock_Table

Setting Damage

• Block
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • DamageEventOverride Equal to False
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (DamageEventTarget is A Hero) Equal to True
      • Then - Actions
        • Set IBlock_I2 = 0
        • For each (Integer A) from 1 to 6, do (Actions)
          • Loop - Actions
            • Set IBlock_IType = (Item-type of (Item carried by DamageEventTarget in slot (Integer A)))
            • Custom script: set udg_IBlock_I1 = udg_IBlock_IType
            • Set IBlock_I2 = (IBlock_I2 + (Load 0 of IBlock_I1 from IBlock_Table))
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Random integer number between 1 and 100) Less than or equal to IBlock_I2
          • Then - Actions
            • Set DamageEventOverride = True
            • Set DamageEventAmount = (DamageEventAmount x 0.50)
            • Floating Text - Create floating text that reads Block! above DamageEventTarget with Z offset 50.00, using font size 10.00, color (100.00%, 5.00%, 10.00%), and 0.00% transparency
            • Floating Text - Set the velocity of (Last created floating text) to 75.00 towards 90.00 degrees
            • Floating Text - Change (Last created floating text): Disable permanence
            • Floating Text - Change the lifespan of (Last created floating text) to 3.50 seconds
            • Floating Text - Change the fading age of (Last created floating text) to 1.40 seconds
          • Else - Actions

 

[Maker]

You should take the second if/then/else out of the else.
You should do the bloc valu counting with Unit acquires/loses and item triggers, and only load the value in this trigger.
The system will block spells also since you can't tell whether damage came from a spell or normal attack unless you trigger all spells.

 

[Palooo3]

Is there a way how to make list of spells wich don't affect block?
And put in condition: Damage event source not equal to <check every spell in spell list>?

 

[Bribe]

If you want to detect if the damage came from a spell then you will need to TRIGGER all spell damage in your map, and do this for each "Unit - Damage Target" line:

• Set DamageEventType = DamageTypeSpell
• Unit - Cause PoopUnit to damage DeadUnit for 100.00 of ...

 

[Palooo3]

would this work?

• ABC
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Storm Bolt
  • Actions
    • Set DamageEventType = DamageTypeSpell
    • Unit - Cause (Triggering unit) to damage (Target unit of ability being cast), dealing 500.00 damage of attack type Spells and damage type Normal

• Block
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • DamageEventOverride Equal to False
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (DamageEventSource is A Hero) Equal to True
        • DamageEventType Not equal to DamageTypeSpell
      • Then - Actions
        • Set IBlock_I2 = 0
        • For each (Integer A) from 1 to 6, do (Actions)
          • Loop - Actions
            • Set IBlock_IType = (Item-type of (Item carried by DamageEventSource in slot (Integer A)))
            • Custom script: set udg_IBlock_I1 = udg_IBlock_IType
            • Set IBlock_I2 = (IBlock_I2 + (Load 0 of IBlock_I1 from IBlock_Table))
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Random integer number between 1 and 100) Less than or equal to IBlock_I2
          • Then - Actions
            • Set DamageEventOverride = True
            • Set DamageEventAmount = (DamageEventAmount x 0.50)
            • Game - Display to (All players) the text: (String(DamageEventAmount))
            • Floating Text - Create floating text that reads Block! above DamageEventSource with Z offset 50.00, using font size 10.00, color (100.00%, 5.00%, 10.00%), and 0.00% transparency
            • Floating Text - Set the velocity of (Last created floating text) to 75.00 towards 90.00 degrees
            • Floating Text - Change (Last created floating text): Disable permanence
            • Floating Text - Change the lifespan of (Last created floating text) to 3.50 seconds
            • Floating Text - Change the fading age of (Last created floating text) to 1.40 seconds
          • Else - Actions

 

[Bribe]

Looks solid to me.

 

[Palooo3]

Thank you so much

 

[Arhowk]

lag...

anyway, you dont need to trigger all spell damage in your map.

library UK012
function DamageEngine_HookSpell takes unit source, widget target, real amount, boolean b1, boolean b2, attacktype at, damagetype dt, weapontype wt returns nothing
    set udg_DamageEventType = udg_DamageTypeSpell
endfunction

function DamageEngine_HookSpellBJ takes unit c, unit t, real amt, attacktype attype, damagetype dmgtype returns nothing
    set udg_DamageEventType = udg_DamageTypeSpell
endfunction

hook UnitDamageTarget DamageEngine_HookSpell
hook UnitDamageTargetBJ DamageEngine_HookSpellBJ
endlibrary

will automatically detect wether the damage dealt was spell or not

 

[Bribe]

Yeah, if you are using Jass NewGen Pack, that is easier. But you still have to trigger all spell damage, because the system will think Object Editor damage is physical.

 

[Palooo3]

I don't use any object editor damage, all is set to 0. I'm using damage based on hero attributes/items and for creeps it is random number between x and y + something if conditions are true and so on.

 

[Bribe]

Well then you have a smarter approach. I was thinking of doing something like that in WarChasers 2, but I have trouble deciding how I want to scale the tooltips.

 

[Arhowk]

Yeah, if you are using Jass NewGen Pack, that is easier. But you still have to trigger all spell damage, because the system will think Object Editor damage is physical.

I dont think you should ever NOT use JNGP.

And no you dont have to trigger all spell damage. If you've ever played Vampirism Beast, i copied their rending claws ability but i wanted it to only happen on attack so i put that script in my map and it was always correct on wether it was smart attack damage or spell damage

I don't use any object editor damage, all is set to 0. I'm using damage based on hero attributes/items and for creeps it is random number between x and y + something if conditions are true and so on.

So use my script and set the damage type to magic..

 

[Bribe]

If you use the Damage Engine that I wrote, it will think object editor-created damage is the same as physical attack damage. Unless you are still referring to the 0-damage trick.

 

[Arhowk]

Im telling you, i use it in my map to distinguish between smart attack damage and spell damage and it works flawlessly for all the spells ive made so far

 

[Bribe]

Oh I know why, if you use 0 as object editor damage then the event won't even fire, because a 0-damage event uses "DamageEvent Equal to 2.00". Then you won't even have to check to see where the damage came from, if the damage is 0 in the first place, because the event won't even go off.

 

[Palooo3]

So what do you suggest me to do, I need only normal attacks detecting damage, every spell damage is triggered by me. All I need from your system is to sometimes decercase normal damage, never spell damage, I do it myself..

 

[Bribe]

Yeah, as long as the object editor abilities don't deal any damage, and you set "DamageEventType = DamageTypeSpell" before every Unit - Damage Target statement, your script will work just fine.

 

[Arhowk]

Use my script and when u trigger the damage, set it to Magic damage.

if your triggering EVERY DAMN SPELL in the game, than you can just set damagetypespell before

 

[Bribe]

...if he is using JNGP.

 

[Arhowk]

...if he is using JNGP.

...because everyone should use JNGP

 

[Bribe]

...but not everyone is. And to expect everyone to do it is pretty harsh. Especially since it doesn't work on OS X/Linux.

 

[shadowvzs]

ok atm i also dont use jngp yet, i think i will use only at end only for terrain, coz i already made few vjass system in normal jass and dont got nothing what i cant write in normal jass and exist in vjass

i triggered every magical spell on my map so need only damage type thing at magic map coz i set dmgeventype to 0 at end in set dmg trigger, so it is allways 0 at when i dont set other value before the dmg and 0 in my case allways physical

(1=reflect and dot, 2 magic )