(GUI) Bounty Controller

[Daffa]

This is an amusing way to extend bounty from what Warcraft III offered. Well done!

 

[HerlySQR]

This is an amusing way to extend bounty from what Warcraft III offered. Well done!

Thank you very much.

 

[Daffa]

Does this support only gold? I think lumber should also be covered of it is not supported, yet.

 

[HerlySQR]

Does this support only gold? I think lumber should also be covered of it is not supported, yet.

Lumber is supported, just I don't have the visual effect like gold.

 

[HerlySQR]

Question: Is there a library that saves the data of the texttags?, If not, I will create it.
Another question: If I use the function CreateTextTag() have I edit it inmediatly or it gets deleted or something?

 

[HerlySQR]

Updated, see the Changelog.

 

[Lt_Hawkeye]

There's this library by Mypad for texttags [vJASS] - [Library] Text Tag

 

[HerlySQR]

There's this library by Mypad for texttags [vJASS] - [Library] Text Tag

Well thx, but that is not what I asked, but I have a question, is there a way to undo the SetTextTagLifeSpan? or is just easy as set it to 0?

 

[Lt_Hawkeye]

You can try using the SetTextTagPermanent native.

 

[HerlySQR]

You can try using the SetTextTagPermanent native.

If I wanna undo set it again to false and again add it a life span, is the previous eliminated?

 

[Lt_Hawkeye]

Yes, that should do it.

 

[HerlySQR]

Yes, that should do it.

Well, basically the lifespan is not the remaining life of the texttag, is the age it must have to get elimanted, so for that I have to set a lifespan with a big number to the text don't get deleted if I set its permanence to false.

PD: Updated (see the ChangeLog) and Lua version added (thank you @Uncle and @Tasyen).

 

[HerlySQR]

UPDATED (see the ChangeLog).

 

[HerlySQR]

UPDATED (see the Changelog) and this is a too important one

PD: pls tell me if there is some problem with my system.

PD2: if someone was too fast to downloaded it, pls do it again because I missed things.

 

[MyPad]

In its current state, the Bounty Controller system works like a charm. There aren't any major issues encountered while testing the system,
but it is worth mentioning to the user that the system overrides the built-in bounty system, so that the user can take that into account
when designating which players (in addition to neutral hostile) can have units which give bounty.

Spoiler: Code

The function SetPlayerFlagBJ can be replaced with a direct call to SetPlayerState, albeit with the following argument
parameters:

// The native function used by SetPlayerFlagBJ
native SetPlayerState takes player whichplayer, playerstate whichstate, integer state returns nothing
// Line to copy
call SetPlayerState(whichplayer, PLAYER_STATE_GIVES_BOUNTY, 0)

The temporary variables TempX, TempY, and TempZ have generic names. This might have an impact
on importing this system on certain maps which might contain variables with the same name. I suggest
adding a prefix or a suffix identifier so that no name collisions occur.

In the Lua version, you might want to declare the closure function within CopyForce as its own function.
From what I've heard, closures when created dynamically are notoriously difficult to reclaim as usable
memory.

Status:

Approved​

 

[HerlySQR]

@MyPad Thank you.

but it is worth mentioning to the user that the system overrides the built-in bounty system, so that the user can take that into account
when designating which players (in addition to neutral hostile) can have units which give bounty.

The comment section warns you that you must have deactiveted the normal bounties, it just left warn it in the bundle.

The function SetPlayerFlagBJ can be replaced with a direct call to SetPlayerState, albeit with the following argument
parameters

I can do that if I need update the map.

The temporary variables TempX, TempY, and TempZ have generic names.

They are variables just for the test map, you shouldn't import them.

In the Lua version, you might want to declare the closure function within CopyForce as its own function.
From what I've heard, closures when created dynamically are notoriously difficult to reclaim as usable
memory.

What do you mean?

 

[MyPad]

@MyPad Thank you.

The comment section warns you that you must have deactiveted the normal bounties, it just left warn it in the bundle.

I can do that if I need update the map.

They are variables just for the test map, you shouldn't import them.

What do you mean?

As for the closure part, the suggested code change will look like this:

-- New (former closure function declared as external func)
function callbackex()
    bar()
end
function foo()
    DoFunc(callbackex, otherparam)
end

-- Old
function foo()
    DoFunc(function()
        bar()
    end, otherparam)
end

Since that particular function will be called multiple times, I suppose it would be better to just declare the closure function explicitly rather than generate copies of the same function throughout the game.

 

[HerlySQR]

As for the closure part, the suggested code change will look like this:

-- New (former closure function declared as external func)
function callbackex()
    bar()
end
function foo()
    DoFunc(callbackex, otherparam)
end

-- Old
function foo()
    DoFunc(function()
        bar()
    end, otherparam)
end

Since that particular function will be called multiple times, I suppose it would be better to just declare the closure function explicitly rather than generate copies of the same function throughout the game.

Ah that, I would do that, but 2 diferent functions use it, so I can't make that function anonymus (Is that new/old in the wrong place?).

 

[HerlySQR]

Thinking well, this system more than "GUI-Friendly" is more just for GUI, I made a pure code version (You can see it in the top of the bundle).

 

[HerlySQR]

I realise that my system works in that way a player group is created and destroyed everytime a unit dies (or is used BountHold and BountyRelease), its ok or have I to fix it?