GUI and JASS IsDestTree v1.3

[Moderator]

19:32, 25th Sep 2013
PurgeandFire: Approved!

 

[Rheiko]

glad someone can convert Jass to GUI
nice job there
a little present from me
+REP

 

[Daffa]

for anyone who is wondering abut the permission, it can be found here

 

[Almia]

Uhh, The InitTrig function I suggested must be the init function. Rename the trigger to IsDestTree or rename the init function to the init function you use in the code. I told you it is the most optimized script yet you added a "fail" function, a useless function XD

Other than that, good job

Btw, make sure to notify them that they must only implement one of the systems(GUI and JASS), because the unit's handler may be lost due to the fact that One of them replaces the older harvester

 

[Daffa]

it seems I misunderstood, I'll try to fix that (u know, my Jass sucks)

good point, I'll update them at once.

EDIT :

I was so careless, I called the Initial Function which screw stuffs.
Fixed.

Updating...

EDIT 2 :

Updated! I'm sure both works properly now (tested the Jass Version, it works now!)

 

[PurgeandFire]

You should set TreeKill back to "False" after killing the destructible. Otherwise it can cause issues if you leave it up to the user.

E.g. Let's say you have some knockback trigger that kills trees. You set TreeKill = true in that trigger. Meanwhile, some other trigger fires that groups destructables and checks if any of them are trees. Since TreeKill is still set to True, it will kill those destructables even if the user didn't set TreeKill to true right then.

 

[Daffa]

Okay, thanks for the info PurgeandFire
I'll update them after school (in 6/7 hours I hope).

Anyway, is there any other flaws I left beside that and what Almia's stated before?

 

[Almia]

Add Locust Ability to the Peasant. Hiding Units are still not protected.

Custom script : call UnitAddAbility(udg_DestChecker, 'Aloc')

 

[Daffa]

Okay, I'll add it

 

[Rheiko]

fix the flaws, bro
btw, why this?

Moderators

This System is marked as NO RATING like Mag's GUI AutoFly and Almia's IsDestTree

 

[Daffa]

As it should be the same as Original IsDestTree by Almia, it's not fair if this got rated and that one isn't.

 

[Rheiko]

i see, fair and square.. keep it up, man

 

[Magtheridon96]

Delete this entirely:

//===========================================================================
function InitTrig_IsDestTree_JASS takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerAddAction( t, function InitTrig_IsDestTree )
    set t = null
endfunction

It does absolutely nothing.

 

[Daffa]

Isn't that the structure for JASS Initialization? This is not VJASS, unless Plain JASS can have this block removed.

 

[Magtheridon96]

Any function that starts with InitTrig will be called inside of one of the initialization functions that runs inside function main.

Currently, your InitTrig_IsDestTree function is running on map initialization and initializing the library just fine, then you have this other useless function:

//===========================================================================
function InitTrig_IsDestTree_JASS takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerAddAction( t, function InitTrig_IsDestTree )
    set t = null
endfunction

That just creates a trigger, adds an action to it and does nothing after that. All it's doing is leaking memory

 

[Daffa]

I see, so it will read the InitTrig_IsDestTree and runs that function as Map Init begin, I'll fix this along with the rest of the issues today, was busy that I forgot to update it yesterday.

EDIT :

Forgot to post, UPDATED!

 

[Almia]

I was pointing that out a long time ago Daffa, but you ignored it.

 

[Daffa]

Sorry, because I skip some stuffs you mention

 

[Daffa]

*necromancy + bumpy bump + update*
Guys, I'm intending to update this thanks to BPower IsDestTree, which is adding the harvest ability for security.