Resource System Graphic Support Filter (Maps)

[Remixer]

Update the Graphics support filter on map search. Currently ticking one of the fields makes the system include the maps that have only that mode enabled, while I would argue the logical function should be that if that selected graphics mode is supported, it will be included (thus maps that support both SD and HD would be visible if one of them is ticked). Currently leaving them both unticked is the same as ticking them both. Should users also be able to exclude maps of a selected graphics style somehow (in case both are supported)?

 

[Ralle]

What exactly are you missing? Sorry if I’m being thick.

 

[Remixer]

What exactly are you missing? Sorry if I’m being thick.

Imagine a user who doesn't have reforged, and instead can only play with classic graphics. He would like to see maps that are supporting SD graphics - it does not matter if the maps also have a support for HD mode.

Filtering for this should occur by ticking "SD" field, but now, what happens instead is that the Hive will display maps that are supported ONLY by SD graphics mode, hiding all the maps that support SD and HD mode.

 

[Ralle]

I just had a look at the code:

        // Graphics support
        $graphics = $this->getFilter($filters, 'graphics');
        if ($graphics) {
            $sd = !empty($graphics['sd']);
            $hd = !empty($graphics['hd']);
            $sum = $sd + $hd;
            // We ignore it if both are ticked
            if ($sum && $sum != 2) {
                $graphicsInt = [];
                if ($sd && $hd) {
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_SD_AND_HD;
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_NONE;
                } elseif ($sd) {
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_SD_ONLY;
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_NONE;
                } elseif ($hd) {
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_HD_ONLY;
                }
                $query->withMetadata('graphics_mode', $graphicsInt);
            }
        }

So what you want is probably to always include this line:

$graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_SD_AND_HD;

So hybrid maps are never hidden.

 

[Remixer]

So hybrid maps are never hidden.

I see the logic in the code, but it seems to be still lacking the option to achieve the filter so that it includes all maps that have support for SD.
If I tick no field, I will see all maps, regardless of graphics support.
If I tick SD, I will see maps that have support only for SD graphics.
If I tick HD, I will see maps that have support only for SD graphics.
If I tick both, I will see maps that have support fort both graphic styles.

But, what I want to see is SD+HD and SD, which seems impossible to filter for now. I hope I am explaining it correctly, not trying to be thick here either.

I would imagine there are also people who want to play only with HD graphics so they would want to filter out maps that are SD only (so filter for SD+HD and HD.

Edit: (Perhaps what you meant by including SD+HD was exactly what I just explained above, so users could indeed tick SD+HD + SD)

 

[Ralle]

If I tick HD, I will see maps that have support only for SD graphics.

I think this was an error.

Edit: (Perhaps what you meant by including SD+HD was exactly what I just explained above, so users could indeed tick SD+HD + SD)

That’s it exactly. I believe it’s how the flags in-game work. That’s what I’m working with here.

This would be the change:

        // Graphics support
        $graphics = $this->getFilter($filters, 'graphics');
        if ($graphics) {
            $sd = !empty($graphics['sd']);
            $hd = !empty($graphics['hd']);
            $sum = $sd + $hd;
            // We ignore it if both are ticked
            if ($sum && $sum != 2) {
                $graphicsInt = [];
                if ($sd && $hd) {
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_SD_AND_HD;
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_NONE;
                } elseif ($sd) {
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_SD_AND_HD;
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_SD_ONLY;
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_NONE;
                } elseif ($hd) {
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_SD_AND_HD;
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_HD_ONLY;
                }
                $query->withMetadata('graphics_mode', $graphicsInt);
            }
        }

I'm still not sure about this one:

if ($sd && $hd) {

Typically people expect more results by selecting all options, but this one reduces.

 

[Remixer]

I think this was an error.

It was indeed.

This would be the change:

I guess that works, though it would not let people filter for HD+SD + HD maps. Optimally there could be third option HD+SD, so players could tick for hybrids and individual support - such Hybrid+SD support.

Typically people expect more results by selecting all options, but this one reduces.

At the same time it's redundant to have two same options (empty and both ticked).

 

[Ralle]

Oh I am checking if $sum != 2. That means that if ($sd && $hd) { is never hit.

 

[Remixer]

Oh I am checking if $sum != 2. That means that if ($sd && $hd) { is never hit.

I thought you realized already before and didn't even mention it.

 

[Ralle]

I might need more feedback on this.

        // Graphics support
        $graphics = $this->getFilter($filters, 'graphics');
        if ($graphics) {
            $sd = !empty($graphics['sd']);
            $hd = !empty($graphics['hd']);
            // We ignore it if both are ticked
            if ($sd || $hd) {
                $graphicsInt = [];
                if ($sd && $hd) {
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_SD_AND_HD;
                } elseif ($sd) {
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_SD_AND_HD;
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_SD_ONLY;
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_NONE;
                } elseif ($hd) {
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_SD_AND_HD;
                    $graphicsInt[] = Warcraft3Map::GRAPHICS_MODE_HD_ONLY;
                }
                $query->withMetadata('graphics_mode', $graphicsInt);
            }
        }

If you tick both SD and HD, you only get hybrid maps and no pre-Reforged maps (They are never HD).

If you tick SD, you get SD maps as well as hybrid maps and pre-Reforged maps.

If you tick HD, you get HD maps as well as hybrid maps, no pre-Reforged maps.

 

[Remixer]

I would say that it is most common that people look for maps that are playable regardless of graphics mode.

And then, second most probable case is that they look for map types supported by specific graphics mode.

Only after those two people look exclusively SD or HD maps, but that's just my hunch.

I guess it is not possible to implement third tick field for including hybrids maps.

So
[ ✓ ] SD and HD
[ ✓ ] SD only
[ - ] HD only

Would display hybrid maps as well as SD-only maps.

 

[Ralle]

I feel like the version I presented above makes the most sense.

Don't forget if you tick nothing, you find everything.

 

[Remixer]

I feel like the version I presented above makes the most sense.

Don't forget if you tick nothing, you find everything.

Yeah, the solution you mentioned above covers the current issue of being unable to see hybrid maps together with individual support, which I think is the main 'issue'.

Thanks for the attention on this topic.

 

[Ralle]

I just spoke with @MindWorX about this. It seems confusing for it to be checkboxes, it would be better if it was radio boxes:

So you can pick ONE:

All: No filter
SD: Pre-reforged, Hybrid, SD
HD: Hybrid, HD

That seems way more clean. What do you think @Remixer?

 

[Remixer]

I guess from functional perspective there is little difference between having them radio or checkbox.
The only difference I could think is:
No selected: All maps.
SD selected: Pre-Reforged, Hybrid, SD
HD selected: Hybrid, HD
SD and HD selected: Only hybrid

But I have to say that that iteration would not be any more clear for users, so ultimately I think they might as well be radio buttons.

I still emphasize that the biggest fix is to make the filter inclusive, rather than exclusive.