[JASS] faster ?

[deathismyfriend]

whats faster

TriggerRegisterEnterRectSimple
TriggerRegisterEnterRegion
TriggerRegisterEnterRegionSimple

or if there is anything else faster ? thx

 

[rulerofiron99]

The purple one. (TriggerRegisterEnterRegion)

Purple = native
Red = BJ, a function

Natives are always faster than calling a function.

If you look in JASSCraft, you'll see that both of the other functions simply set some variables and call TriggerRegisterEnterRegion.

 

[Ceday]

If you use regions which you placed via world editor use TriggerRegisterEnterRectSimple, because it is simple.

 

[Maker]

There it is for you to see.

function TriggerRegisterEnterRegionSimple takes trigger trig, region whichRegion returns event
    return TriggerRegisterEnterRegion(trig, whichRegion, null)
endfunction

Regions in GUI are called rects in jass.

A rect is an area that has four 90° corners. A region can consist of one or more rects.

TriggerRegisterEnterRectSimple "converts" the given rect into a region so it can be used with TriggerRegisterEnterRegion.

 

[deathismyfriend]

ok lol thx i knew about the rects and stuff i mustve missed the thing when i was looking in the jngp function thing lol thx tho

 

[edo494]

TriggerRegisterEnterRectSimple leaks,

function TriggerRegisterEnterRectSimple takes trigger trig, rect r returns event
    local region rectRegion = CreateRegion()
    call RegionAddRect(rectRegion, r)
    return TriggerRegisterEnterRegion(trig, rectRegion, null)
endfunction

the region is leaked every time you call it

 

[Maker]

the region is leaked every time you call it

Not necessarily, there's GetTriggeringRegion()

 

[PurgeandFire]

He means that the local isn't nulled.

Although, it shouldn't be much of a big deal unless you either (A) spam regions or (B) want to remove the regions for whatever reason (which would also make that event no longer fire)

But yeah it is a leak nonetheless.

 

[deathismyfriend]

umm i have this

function InitTrig_Hero_Spawns_All takes nothing returns nothing
    set gg_trg_Hero_Spawns_All = CreateTrigger(  )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Blood_Mage )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Far_Seer )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Dreadlord )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Naga_Sea_Witch )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Beastmaster )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Firelord )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Priestess_of_the_Moon )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Warden )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Archmage )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Mountain_King )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Blademaster )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Death_Knight )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Crypt_Lord )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Illidan_evil )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Dark_Ranger )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Pit_Lord )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Demon_Hunter )
    call TriggerRegisterEnterRectSimple( gg_trg_Hero_Spawns_All, gg_rct_Nefarius_Paladin )
    call TriggerAddAction( gg_trg_Hero_Spawns_All, function Trig_Hero_Spawns_All_Actions )
endfunction

how would i make it so this doesnt leak ? using triggerregisterenterregion ? I have multiples of these so I need to know how multiples can be fixed and how to set them up