[Extension] Unit Event

[Nestharus]

I'm not hooking RemoveUnit, lol.


And yes, it's important to me to check between decay, explode, and remove. I have made spells that actually worked off of decay before.

 

[Bribe]

What spells run off of decay? I thought once it fires that event it's too late to be revived?

 

[Magtheridon96]

What spells run off of decay? I thought once it fires that event it's too late to be revived?

When a unit decays, create a dummy unit at it's position with the model of the Spirit Tower projectile and increase the flying height of that dummy unit so it looks like the unit's soul is ascending

 

[Bribe]

That's about the only thing that makes any sense.

But something so specific should just require its own resource.

The decay detection requires this script to use even more LUA and uses a timer which
is also not 100% guaranteed to detect if it's a decay or a removal.

 

[Nestharus]

I used it for a spell that created demon portals from afflicted units upon decay.

 

[Magtheridon96]

Well, if the decay detection is taking up most of the resource's code, it should be it's own resource called OnDecay Event

 

[Nestharus]

It hardly takes up any code


It does add the Lua script tho

 

[Bribe]

It does add the Lua script tho

- Which tends to be more of a deterrent than any length of code, regardless of how good
the tutorials are.

 

[Bribe]

Something just occurred to me, if the DecayEvent is prolonged with
something like UnitSuspendDecay, it can really increase the chances
that the corpse was removed via RemoveUnit after the 88 second (or
whatever) cutoff period. What is wrong with hooking RemoveUnit?
The RemoveUnit hook could not possibly be called enough times to
produce lag.

Hooking RemoveUnit would also help you to deindex units properly
when they are paused, in a transport and then removed, because
your Unit Indexer still bugs when this happens.

 

[Nestharus]

Because RemoveUnit causes 3 trigger evaluations to fire instead of 2 in the event of RemoveUnit native call.

There are cases where people need to remove mass units, especially in maze maps. This 50% decrease in speed can cause massive freeze.



I doubt many maps use UnitSuspendDecay.

 

[Bribe]

I doubt even more heavily that maps will need mass RemoveUnit
will cause any lag compared to the mass lag caused by actually
creating that many units at once.

 

[Nestharus]

Actually... it does matter


I had a map long ago and when I had an early version of this system that hooked RemoveUnit, it caused mass low fps (like 0). When I got rid of RemoveUnit hook and used timer, it ran at 60 fps.


So the RemoveUnit hook request is denied. I worked hard to get rid of it because it made one of my maps unplayable (a map I never finished, but w/e).

 

[Nestharus]

Non Lua Version Up

 

[Nestharus]

Updated non Lua version map to have latest UnitIndexer.

 

[Switch33]

            loop
                call TriggerRegisterPlayerUnitEvent(death,Player(i),EVENT_PLAYER_UNIT_DEATH,null)
                exitwhen 0==i
                set i=i-1
            endloop

Could be replaced with:

            call RegisterPlayerUnitEvent(EVENT_PLAYER_UNIT_DEATH, function OnDeath)

using RegisterPlayerUnitEvent ofc.

Heck you could even make UnitIndexer use it as well probably; but it's probably not that much of a speed boost.

 

[Adiktuz]

btw, the non-LUA link doesn't work anymore...

 

[Nestharus]

It does now

 

[Adiktuz]

oh.. thanks...

 

[Nestharus]

Removed death event and moved made this use RegisterPlayerUnitEvent = )

 

[Switch33]

Why did you remove the death event though anyway?

 

[Nestharus]

Because RegisterPlayerUnitEvent already provides it with EVENT_PLAYER_UNIT_DEATH : p


It was silly =)

 

[vuongkkk]

A little thing bothers me now.

//! i makechange(current, "uabi", "Aloc,Avul," .. indexval <<<<< What are ".. indexval" and "Aloc,Avul,"???

Why have a Unknown(A!!!) in uabi of Unit Event in the AuraStruct demo map???

 

[Nestharus]

You need UnitIndexer to be installed before UnitEvent and you need to install both via Lua if you're going to install 1 via Lua.

 

[vuongkkk]

I'm not well-know about lua. What if i only copy triggers, the unit event and ability indexer from your demo map to my map?

 

[Nestharus]

then you can't use the Lua and you need to modify the unit event unit to have the unit indexer defend ability.

 

[Nestharus]

Was just notified that the unit in the map had an unknown ability. This is the Unit Indexer ability. I have re-uploaded the map to make it so that it has the UnitIndexer ability in the map. If you do not edit it to have the correct UnitIndexer ability for your map, the system decay event will not work and will fire incorrectly as a RemoveUnit event.

The Lua code does add the ability to the unit, but as Lua doesn't appear to work on newer machines, you'll just have to remember to edit the ability on the unit to the UnitIndexer ability.

edit
I have just modified the code in the Lua version and the code in the map to automatically add the UnitIndexer ability, so don't worry about editing it now, just update if you aren't using the Lua version : ).

 

[Nestharus]

Updated

changed GetFilterUnit to GetTriggerUnit

 

[Nestharus]

Changed GetTriggerUnit back to GetFilterUnit