[Trigger] Expected endif?

[Yngwie]

I'm trying to fix a leak and have searched the forums found out how to and here is what I have...

Recreate on Death
Events
Unit - A unit Dies
Conditions
((Triggering unit) is Summoned) Equal to False
Actions
Wait 8.00 seconds
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
((Owner of (Dying unit)) Current lumber) Equal to 0
Then - Actions
Set SpawnPoint = (Random point in (Playable map area))
Unit - Create 1 Hero for (Triggering player) at SpawnPoint facing Default building facing degrees
Camera - Lock camera target for (Triggering player) to (Last created unit), offset by (0.00, 0.00) using Default rotation
Custom script: Call RemoveLocation(udg_SpawnPoint)
Else - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
((Owner of (Dying unit)) Current lumber) Equal to 1
Then - Actions
Set SpawnPoint = (Random point in (Playable map area))
Unit - Create 1 Hero2 for (Triggering player) at SpawnPoint facing Default building facing degrees
Camera - Lock camera target for (Triggering player) to (Last created unit), offset by (0.00, 0.00) using Default rotation
Custom script: Call RemoveLocation(udg_SpawnPoint)
Else - Actions

"Hero" and "Hero2" are put in place of the heroes name just for the site. It is a unit not a variable.

When I try to save the game it gives me the expected endif error.
Help please

 

[Just_Spectating]

must be something about your custom scripts

 

[Yngwie]

It is, this is what everyone says to use to fix leaks.

Set SpawnPoint = (Random point in (Playable map area))
Unit - Create 1 Hero for (Triggering player) at SpawnPoint facing Default building facing degrees
Camera - Lock camera target for (Triggering player) to (Last created unit), offset by (0.00, 0.00) using Default rotation
Custom script: Call RemoveLocation(udg_SpawnPoint)

I don't see the problem? If I use this I get an error and it wont play in wc3.

 

[HappyTauren]

• Recreate on Death
• Events
• Unit - A unit Dies
• Conditions
• ((Triggering unit) is Summoned) Equal to False
• Actions
• Wait 8.00 seconds
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• ((Owner of (Dying unit)) Current lumber) Equal to 0
• Then - Actions
• Set SpawnPoint = (Random point in (Playable map area))
• Unit - Create 1 Hero for (Triggering player) at SpawnPoint facing Default building facing degrees
• Camera - Lock camera target for (Triggering player) to (Last created unit), offset by (0.00, 0.00) using Default rotation
• Custom script: Call RemoveLocation(udg_SpawnPoint)
• Else - Actions
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• ((Owner of (Dying unit)) Current lumber) Equal to 1
• Then - Actions
• Set SpawnPoint = (Random point in (Playable map area))
• Unit - Create 1 Hero2 for (Triggering player) at SpawnPoint facing Default building facing degrees
• Camera - Lock camera target for (Triggering player) to (Last created unit), offset by (0.00, 0.00) using Default rotation
• Custom script: Call RemoveLocation(udg_SpawnPoint)
• Else - Actions

Screenshot the error it gives you.

 

[Yngwie]

The only thing I can think of is maybe SpawnPoint should not be a Point?

Here is ss.

 

[Diablo-dk]

You wrote "Call" instead of "call". Jass is case sensitive.

 

[Yngwie]

XD Thanks Diablo!

 

[Yngwie]

What about removing array variables?
I tried this but got Error Expected '('

• Custom script: call RemoveLocation(udg_SpawnPoint[(Player numer of (Picked player))])

 

[Preskooldude]

A) You spelt number wrong

B) It should be:

• Custom script: call RemoveLocation( udg_SpawnPoint[ GetConvertedPlayerId( GetEnumPlayer() ) ]

or something like that. JASS uses functions, not sentances.

 

[I34w90_238j]

You dont understand? look: You can use "Create 1 Hero at (random point in (playable area))" instead of using a variable, which means region, not a point (region=4 points)"

 

[I34w90_238j]

And try not to use any scripts, only GUI to have no errors.

 

[PurplePoot]

And try not to use any scripts, only GUI to have no errors.

Actually, technically, GUI has tons of code errors in the forms of inefficiencies . Also, you can't deleak with pure GUI.

And pre, GetConvertedPlayerId() is ebol (bj!!!). Use GetPlayerId()+1

 

[I34w90_238j]

Can anybody answer me what is maximum array for variable?

 

[PurplePoot]

8191 (or maybe 8190, I can never remember)

 

[Just_Spectating]

i think diablo DK already solved his problem

 

[I34w90_238j]

And my last question which doesn't lets me sleep: I cant make "gate model" be vertical, not horizontal (default). More, it doesnt have path for vertical gate. Does "gate model" have "required animation names"? (in RoC Editor)

 

[PurplePoot]

Nah, he didn't. He solved one of them, then Yngwie brought up another. Preskool sort of answered it, but used a bj =/

By the way, kkots, he uses the variable to avoid leaks.

Besides, really, who cares? In alot of cases, other things can be pointed out other than the initial problem, and plus the initial answer can be improved (not in this case, since it wasn't a question of style, it was a typo)

kkots -- you can rotate the model with triggers, or make a new gate model. I have an edited "vertical gate" lying around somewhere on my computer.

However, please, in the future, make your own threads instead of hijacking other threads (unless your question relates to the topic of the thread)

Oh, by the way, here's the model (don't remember who made it, or if I did somehow):

 

[I34w90_238j]

Sorry for invading and thank you very much.

 

[Yngwie]

Thankyou everyone. What is a BJ? Using

• Custom script: call RemoveLocation( udg_SpawnPoint[ GetConvertedPlayerId( GetEnumPlayer() ) ]

is bad? Also using this I get error ><

 

[HappyTauren]

function GetConvertedPlayerId takes player whichPlayer returns integer
    return GetPlayerId(whichPlayer) + 1
endfunction

thats BJ, non-native.

 

[Yngwie]

How would I use that with a normal trigger? The rest of it is not coded.

 

[HappyTauren]

call RemoveLocation( udg_SpawnPoint[GetPlayerId( GetEnumPlayer()) + 1 )

• Custom Script:call RemoveLocation( udg_SpawnPoint[GetPlayerId( GetEnumPlayer()) + 1 )

 

[Yngwie]

I get this error.

btw sorry to be so much trouble >< and thankyou all for your help I really appreciate it!

 

[PurplePoot]

HT forgot the closing array bracket.

call RemoveLocation( udg_SpawnPoint[GetPlayerId( GetEnumPlayer()) + 1] ) should work

 

[Yngwie]

Okay PurplePoot you are definately my hero! Thank you soo much!

 

[HappyTauren]

HT forgot the closing array bracket.

xP Can't believe it, you WTFPWNTED me again xP

 

[Just_Spectating]

JASS is not my thing, unsubscribing thiss