[JASS] exit in FirstOfGroup loops

[kStiyl]

Is it okay to exit in mid of FirstOfGroup loop?
since GroupEnum clears the group everytime

(the group I'm using is global and permanent)

                //! runtextmacro GroupMacro("u", "x", "y", "325")
                    if IsEnemy(u, globalUnit) then
                        set x = GetUnitX(u)
                        set y = GetUnitY(u)
                        set u = null
                        exitwhen true
                    endif 
                //! runtextmacro GroupMacroEnd()

 

[Nestharus]

GroupEnum what?


If you exit mid first of group loop, you need to do a GroupClear() at the end.

 

[kStiyl]

GroupEnum what?


If you exit mid first of group loop, you need to do a GroupClear() at the end.

GroupEnumUnitsInRange <-
Is there a reason why I have to use GroupClear? I'm just wondering
It's from Bribe's GroupMacro

    //! textmacro GroupMacro takes UNIT, X, Y, RANGE
        call GroupEnumUnitsInRange(G, $X$, $Y$, $RANGE$ + 75, null)
        loop
            set $UNIT$ = FirstOfGroup(G)
            exitwhen ($UNIT$ == null)
            call GroupRemoveUnit(G, $UNIT$)
            if IsUnitInRangeXY($UNIT$, $X$, $Y$, $RANGE$) then
    //! endtextmacro

 

[Troll-Brain]

If you ask about an eventual leak, there is none, and yes each GroupEnum clears the group before eventually add units, so yes it's ok.

 

[Nestharus]

You said you are using a first of group loop... first of group clears the group as you loop through... if you exit early, then you haven't looped through the entire group, thus you haven't cleared the entire group.


A first of group loop is different from a group enumeration loop... in a group enumeration loop, there is no exitwhen true.. it doesn't make sense to have that loop inside. exitwhen true would do absolutely nothing. A premature return would just end the current iteration and go on to the next one, similar to continue.

 

[kStiyl]

would appreciate it if you tell me what the leak is.. i don't want leaks in my map XD

I'm sorry I did not make it clear. I was asking if this would cause any leaks

 

[Nestharus]

The leaks depend on what you are doing.... you are being extremely confusing right now. You say you are using a first of group loop but talk as though you are just doing an enumeration.


As troll stated, the group will clear before a group enumeration ; ), so only temporary pointer leaks.

 

[kStiyl]

I'm trying to use FirstOfGroup so I can just pick one random unit that matches filter and leave prematurely, so I don't have to loop through whole group and remove them one by one
As long as i don't have permanent leaks, i'm fine with it (the group is used a lot anyway)

 

[Nestharus]

As troll said, no perma leaks. Only a temporary pointer leak ^)^.


If you are worried, try this script out

struct testtest extends array
    private static method onInit takes nothing returns nothing
        local unit u = CreateUnit(Player(0), 'hpea', 0, 0, 0)
        local group g = CreateGroup()
        
        call GroupEnumUnitsInRange(g, 0, 0, 260, null)
        
        call SetUnitPosition(u, 1000, 1000)
        set u = CreateUnit(Player(0), 'hfoo', 0, 0, 0)
        
        call GroupEnumUnitsInRange(g, 0, 0, 260, null)
        
        loop
            set u = FirstOfGroup(g)
            exitwhen null == u
            call GroupRemoveUnit(g, u)
            call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,GetUnitName(u))
        endloop
    endmethod
endstruct

As you see, the peasant will not be in the group after the second enumeration ;p.

 

[kStiyl]

your comment suddenly changes
thank you

 

[Nestharus]

your comment suddenly changes
thank you

shhhhhh, that's because I forgot this line in my first test, haha
call SetUnitPosition(u, 1000, 1000)

 

[mckill2009]

maybe this...

set I = 0 //global integer variable
call GroupEnumUnitsInRange(G, 0, 0, 99999, null)
    loop
       set u = FirstOfGroup(G)
       exitwhen u==null
       set I = I + 1
       if I > 2 then
           call GroupClear(G)
       else
           call GroupRemoveUnit(G, u)
       endif
    endloop

 

[Troll-Brain]

It is not necessary, as long the same group will be reused soon or later.