[Trigger] Event Trigger Leaks

[dgriff]

Hi. This code is used for various damage-detection functions. Do I need to store these triggers and then manually destroy them once their unit is destroyed?

• addunittakesdamage
  • Events
    • Unit - A unit enters (Entire map)
  • Conditions
  • Actions
    • Trigger - Add to proximity agitation <gen> the event (Unit - (Entering unit) Takes damage)
    • Trigger - Add to snare <gen> the event (Unit - (Entering unit) Takes damage)
    • Trigger - Add to ko <gen> the event (Unit - (Entering unit) Takes damage)
    • Trigger - Add to arrowhit <gen> the event (Unit - (Entering unit) Takes damage)

Edit: Did some tests. It does indeed leak a lot. 40,000 units created->removed->nulled while this trigger was in effect caused a memory usage increase of about 50-60 mb.

 

[MortAr]

Try these:

• Init
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Set Point = (Center of (Playable map area))
    • Set DamageGroup = (Units within 99999.00 of Point matching (((Matching unit) is alive) Equal to True))
    • Unit Group - Pick every unit in DamageGroup and do (Actions)
      • Loop - Actions
        • Trigger - Add to <Trigger> the event (Unit - (Picked unit) Takes damage)
    • Custom script: call RemoveLocation (udg_Point)
    • Custom script: call DestroyGroup (udg_DamageGroup)

And:

• Detection
  • Events
    • Unit - A unit enters (Entire map)
  • Conditions
  • Actions
    • Trigger - Add to <Trigger> the event (Unit - (Triggering unit) Takes damage)

 

[dgriff]

Thanks for the response, but my question wasn't how do I use that trigger, rather it was how do I stop that trigger from leaking.

This is why it leaks: Every time an event is added to those damage-detection triggers, that event is there forever. So if you have 40,000 units over the course of a game, there are going to be 40,000 events for each of those triggers. This is going to cause a huge memory leak.

My questions are 1) how do I remove an event from a trigger and 2) how do I store an event. There isn't a hashtable function SaveEventHandle(...) because initially I wanted to just use a unit's handleid as a key in a hashtable to retrieve that unit's own damage event.

Any ideas?

 

[meOme]

You can't remove events from triggers.

But I've read somewhere (can't find it right now, sorry) that you can destroy triggers with Jass and create a new one (that only has the events you want).

 

[Yixx]

Dont destroy triggers.
Think about it, why didnt blizzard make a GUI function to destroy trigger?
Because it is bugged! It can fuck up your handle stack, which might be a hard word for you, but it is serious and fucks up the whole game..
Dont destroy triggers,
There is nothing you can do about the leaks, except for using an advanced vJass Damage System..

 

[MortAr]

Store the units into a group, add a condition to the trigger that detecs the damage "Unit is in Group" then make a second trigger that detecs if a unit from that group dies, and if its, remove it from the group.

The damage trigger will stay clear.

 

[Justify]

Dont destroy triggers.
Think about it, why didnt blizzard make a GUI function to destroy trigger?
Because it is bugged! It can fuck up your handle stack, which might be a hard word for you, but it is serious and fucks up the whole game..
Dont destroy triggers,
There is nothing you can do about the leaks, except for using an advanced vJass Damage System..

Have you ever had problems with this?
All people mention it, but most of them have never faced this rare problem. The only thing to care about is, that no instanc of the trigger is running while destroying it, meaning to wait and not destroy itself. Dota uses MANY dynamic triggers, and although Dota sucks sooooo heavily and Frogs methods are sooooo bad, it works.

 

[Yixx]

Have you ever had problems with this?
All people mention it, but most of them have never faced this rare problem. The only thing to care about is, that no instanc of the trigger is running while destroying it, meaning to wait and not destroy itself. Dota uses MANY dynamic triggers, and although Dota sucks sooooo heavily and Frogs methods are sooooo bad, it works.

No i have not had problems with it, because i dont make maps..
But if you want to risk your game getting fucked up, go ahead..

 

[sadvisor]

Dont destroy triggers.
Think about it, why didnt blizzard make a GUI function to destroy trigger?
Because it is bugged! It can fuck up your handle stack, which might be a hard word for you, but it is serious and fucks up the whole game..
Dont destroy triggers,
There is nothing you can do about the leaks, except for using an advanced vJass Damage System..

It never "fucked up" any of my maps.
And i have a lot of triggers ending with this line:

• Custom script: call DestroyTrigger(GetTriggeringTrigger())

 

[TriggerHappy]

And i have a lot of triggers ending with this line:

Then you're doing it wrong. Destroying triggers can cause bugs.

If you're going to be doing damage detection in GUI, I would suggest this one.

 

[dgriff]

Ok I looked at TriggerHappy's link and the code DOES destroy triggers. It basically makes a detect damage trigger for each unit that is on the map and then destroys that trigger when the unit is gone.

 

[azlier]

It's either DestroyTrigger or leaks. There is no other alternative.

DestroyTrigger only bugs under certain conditions.