Eternal Purge - DPS/Slow v2

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

19 Dec 2011
Bribe: Why are you forcing the unit to constantly be attacking? The taunt doesn't make sense. Well if you are going to keep it delete the "prevent orders" trigger because telling it to attack every 0.5 seconds is enough.

You should only check if the group is empty after removing a unit from the group.

You should add some comments to your code and tell people how to configure it. for example I can tell that the "12" integer keeps the buff going for 6 seconds, however you should allow it to be easily modified based on something like the ability level, for example.

The spell is way too simple to get approved. You need to add more stuff. Currently someone could easily make this in just object editor.

 

[Maker]

Damn, Bribe. y u so fast?

*Set the hashtable into a variable, use the variable instead of last created hashtable
*The looping trigger shoudn't be always on
*You should flush the child hashtables

 

[Inflicted]

lol i got bored and did this in 10 mins

felt like posting it here lmao.

*Set the hashtable into a variable, use the variable instead of last created hashtable

isnt that fairly obvious if somebody wants to use it?
Then they can use their own hashtable and edit it in.

*The looping trigger shoudn't be always on

yeah read the moderators comment.

*You should flush the child hashtables

kay, i need to learn that :/

Thank you tho.

--

EDIT: Fair point on the Unit Group, will edit and re-post. ty.

 

[Bribe]

Maker is a mod as well

You should be setting a variable to the hashtable yourself. It helps to make the system easy to copy into a map.

Use [trigger][/trigger] tags, not code tags.

 

[Inflicted]

done, will upload in a sec.

yeah not quite sure what the codes are here. Sorry about that, just took a guess at 'code' tags. [wc3] did not work

--

EDIT: Are there any leaks?

Currently someone could easily make this in just object editor.

I'm quite sure this is not possible to make in the OE. :/

Unless there is some hidden spell that I don't know of. I can't think of anything that uses % missing hp. :?

--

EDIT2:

Is this the correct use of Flushing Child Hashtables?
Kindof like clearing leaks? Not entirely sure..

• purge dps
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in EP_UnitGroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Load (Key (Picked unit)) of 1 from EP_Hash) Greater than 0
          • Then - Actions
            • Unit - Cause (Load (Key (Picked unit)) of 0 in EP_Hash) to damage (Picked unit), dealing ((100.00 - (Percentage life of (Picked unit))) x 3.00) damage of attack type Spells and damage type Magic
            • Hashtable - Save ((Load (Key (Picked unit)) of 1 from EP_Hash) - 1) as (Key (Picked unit)) of 1 in EP_Hash
          • Else - Actions
            • Unit Group - Remove (Picked unit) from EP_UnitGroup
            • Hashtable - Clear all child hashtables of child (Key (Picked unit)) in EP_Hash <---
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in EP_UnitGroup) Equal to 0
      • Then - Actions
        • Trigger - Turn off (This trigger)
      • Else - Actions

 

[SpectreD]

lol i got bored and did this in 10 mins

felt like posting it here lmao.

u should prob spend more time on your spells if u want approval

 

[Inflicted]

u should prob spend more time on your spells if u want approval

blah blah blah, i lack creativity. And i only recently learned hashtables, and wanted to post here to see if I was doing everything correctly.

Besides the best way to learn is to try make things, learn from your mistakes etc.

And I learned something about flushingg child hashtables. So it's never a loss.

Only question I have left, (aimed at one of the mods) Should I remove this thread?

 

[Bribe]

Well if you have an idea that you want constructive criticism on you can share your code/thoughts in the Triggers & Scripts forum: http://www.hiveworkshop.com/forums/triggers-scripts-269/. Typically the Spells section is for finished or mostly finished work and not so much for asking for advice how to make it better.

You don't have to delete your spell. Spells are only soft-deleted anyway, meaning they stay on the server whether or not it was deleted. I can put this in the "Rejected" category if you have no plans to update it, and if you do update it or plan to I can change its status then.

 

[Inflicted]

ty for the link. I have a few idea's as to how i will update it

---

EDIT: Updated. Added taunt and damage reduction.