error message upon saving due to multiboard(i guess)

Noctosphere · May 29, 2016

So, I never had any error message like that before. The only thing I did that was different from map I made before is the uses of Custom Script.
I followed this tutorial : http://www.hiveworkshop.com/forums/general-mapping-tutorials-278/all-about-multiboards-84942/
The custom script is in the section about how to make the multiboard to appear for specified player.
Here's the error message :

EDIT: Sorry for that long script, all you had to know (i think) was : Line 1564: Missing: Endblock

If you know what it means, please let me know, also is there a way to fix this? If there is anything to fix...

DD_legionTN · May 29, 2016

Post your code so that people could see the problem directly.

From the error "missing endblock", basically what i could think of from your instance would be, you forgot put "endif" in your code.

Noctosphere · May 29, 2016

well, here, this is the only place where I used the custom script

Board Creation
- Events
  - Time - Elapsed game time is 0.01 seconds
- Conditions
- Actions
  - Multiboard - Create a multiboard with 2 columns and 6 rows, titled (Income - + T1_name)
  - Set T1IncomeBoard = (Last created multiboard)
  - Multiboard - Set the width for T1IncomeBoard item in column 1, row 1 to 15.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 1, row 2 to 15.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 1, row 3 to 15.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 1, row 4 to 15.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 1, row 5 to 15.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 1, row 6 to 15.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 2, row 1 to 8.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 2, row 2 to 8.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 2, row 3 to 8.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 2, row 4 to 8.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 2, row 5 to 8.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 2, row 6 to 8.00% of the total screen width
  - Multiboard - Create a multiboard with 2 columns and 6 rows, titled (Income - + T2_name)
  - Set T2IncomeBoard = (Last created multiboard)
  - Multiboard - Set the width for T2IncomeBoard item in column 1, row 1 to 15.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 1, row 2 to 15.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 1, row 3 to 15.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 1, row 4 to 15.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 1, row 5 to 15.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 1, row 6 to 15.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 2, row 1 to 8.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 2, row 2 to 8.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 2, row 3 to 8.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 2, row 4 to 8.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 2, row 5 to 8.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 2, row 6 to 8.00% of the total screen width
  - Multiboard - Set the text for T1IncomeBoard item in column 1, row 2 to (Name of Player 1 (Red))
  - Multiboard - Set the text for T1IncomeBoard item in column 1, row 3 to (Name of Player 2 (Blue))
  - Multiboard - Set the text for T1IncomeBoard item in column 1, row 4 to (Name of Player 3 (Teal))
  - Multiboard - Set the text for T1IncomeBoard item in column 1, row 5 to (Name of Player 4 (Purple))
  - Multiboard - Set the text for T1IncomeBoard item in column 1, row 6 to (Name of Player 5 (Yellow))
  - Multiboard - Set the text for T2IncomeBoard item in column 1, row 2 to (Name of Player 6 (Orange))
  - Multiboard - Set the text for T2IncomeBoard item in column 1, row 3 to (Name of Player 7 (Green))
  - Multiboard - Set the text for T2IncomeBoard item in column 1, row 4 to (Name of Player 8 (Pink))
  - Multiboard - Set the text for T2IncomeBoard item in column 1, row 5 to (Name of Player 9 (Gray))
  - Multiboard - Set the text for T2IncomeBoard item in column 1, row 6 to (Name of Player 10 (Light Blue))
  - Multiboard - Set the color for T1IncomeBoard item in column 1, row 2 to (100.00%, 0.00%, 0.00%) with 0.00% transparency
  - Multiboard - Set the color for T1IncomeBoard item in column 1, row 3 to (0.00%, 0.00%, 100.00%) with 0.00% transparency
  - Multiboard - Set the color for T1IncomeBoard item in column 1, row 4 to (0.00%, 100.00%, 100.00%) with 0.00% transparency
  - Multiboard - Set the color for T1IncomeBoard item in column 1, row 5 to (100.00%, 0.00%, 100.00%) with 0.00% transparency
  - Multiboard - Set the color for T1IncomeBoard item in column 1, row 6 to (100.00%, 100.00%, 0.00%) with 0.00% transparency
  - Multiboard - Set the color for T2IncomeBoard item in column 1, row 2 to (100.00%, 50.00%, 0.00%) with 0.00% transparency
  - Multiboard - Set the color for T2IncomeBoard item in column 1, row 3 to (0.00%, 100.00%, 0.00%) with 0.00% transparency
  - Multiboard - Set the color for T2IncomeBoard item in column 1, row 4 to (100.00%, 50.00%, 50.00%) with 0.00% transparency
  - Multiboard - Set the color for T2IncomeBoard item in column 1, row 5 to (50.00%, 50.00%, 50.00%) with 0.00% transparency
  - Multiboard - Set the color for T2IncomeBoard item in column 1, row 6 to (50.00%, 50.00%, 100.00%) with 0.00% transparency
  - Multiboard - Hide all multiboards
  - Custom script: if ( GetLocalPlayer() == Player(0) ) then
  - Multiboard - Show T1IncomeBoard
  - Custom script: endf
  - Custom script: if ( GetLocalPlayer() == Player(1) ) then
  - Multiboard - Show T1IncomeBoard
  - Custom script: endf
  - Custom script: if ( GetLocalPlayer() == Player(2) ) then
  - Multiboard - Show T1IncomeBoard
  - Custom script: endf
  - Custom script: if ( GetLocalPlayer() == Player(3) ) then
  - Multiboard - Show T1IncomeBoard
  - Custom script: endf
  - Custom script: if ( GetLocalPlayer() == Player(4) ) then
  - Multiboard - Show T1IncomeBoard
  - Custom script: endf
  - Custom script: if ( GetLocalPlayer() == Player(5) ) then
  - Multiboard - Show T2IncomeBoard
  - Custom script: endf
  - Custom script: if ( GetLocalPlayer() == Player(6) ) then
  - Multiboard - Show T2IncomeBoard
  - Custom script: endf
  - Custom script: if ( GetLocalPlayer() == Player(7) ) then
  - Multiboard - Show T2IncomeBoard
  - Custom script: endf
  - Custom script: if ( GetLocalPlayer() == Player(8) ) then
  - Multiboard - Show T2IncomeBoard
  - Custom script: endf
  - Custom script: if ( GetLocalPlayer() == Player(9) ) then
  - Multiboard - Show T2IncomeBoard
  - Custom script: endf

DD_legionTN · May 29, 2016

Custom script: endf

you wrote wrong. It is "endif", change it and it would be fine.

Chaosy · May 29, 2016

I'll just point out that you can shorten the code and make it 1/3 of the current size by using loops and using one getlocalplayer per team.

Noctosphere · May 31, 2016

Alright, thanls, worked.
@chaosy Can you show me the script you are talking about (the getlocalplayer one)

Chaosy · May 31, 2016

Custom Scipt set p = GetLocalPlayer() <--- not needed but shorter texet and it's slightly faster.
Custom script: if (p == Player(0) and p == Player(1) and p == Player(2) and p == Player(3) and p == Player(4)) then
Multiboard - Show T1IncomeBoard
Custom script: endf

Noctosphere · May 31, 2016

Chaosy said:
Custom Scipt set p = GetLocalPlayer() <--- not needed but shorter texet and it's slightly faster.
Custom script: if (p == Player(0) and p == Player(1) and p == Player(2) and p == Player(3) and p == Player(4)) then
Multiboard - Show T1IncomeBoard
Custom script: endf

AND or OR?
I'm not an expert but, won't it make it look if the player is 1 2 3 4 5 at the same time? which is impossible, right?

Noctosphere · May 31, 2016

Okay, so, I just tried with "or" instead of "and" and I get another error upon saving.

Undeclared variable p
Comparing two variable of different primitive type (except real and integer) is not allowed

Chaosy · May 31, 2016

because you did not have a local player variable named p.

Noctosphere · May 31, 2016

okay... So I just created a variable named "p" in the variable tab of "player" type. And when I save, I get the same two error message...

Chaosy · May 31, 2016

that's a GUI variable that's why.
You have to use udg_p instead of p in that case.

This is what I'd look like:
(it looks weird, but I just added the lines so..)

Board Creation
- Events
  - Time - Elapsed game time is 0.01 seconds
- Conditions
- Actions
  - Custom script: local Player p = GetLocalPlayer()
  - Multiboard - Create a multiboard with 2 columns and 6 rows, titled (Income - + T1_name)
  - Set T1IncomeBoard = (Last created multiboard)
  - Multiboard - Set the width for T1IncomeBoard item in column 1, row 1 to 15.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 1, row 2 to 15.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 1, row 3 to 15.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 1, row 4 to 15.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 1, row 5 to 15.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 1, row 6 to 15.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 2, row 1 to 8.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 2, row 2 to 8.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 2, row 3 to 8.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 2, row 4 to 8.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 2, row 5 to 8.00% of the total screen width
  - Multiboard - Set the width for T1IncomeBoard item in column 2, row 6 to 8.00% of the total screen width
  - Multiboard - Create a multiboard with 2 columns and 6 rows, titled (Income - + T2_name)
  - Set T2IncomeBoard = (Last created multiboard)
  - Multiboard - Set the width for T2IncomeBoard item in column 1, row 1 to 15.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 1, row 2 to 15.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 1, row 3 to 15.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 1, row 4 to 15.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 1, row 5 to 15.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 1, row 6 to 15.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 2, row 1 to 8.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 2, row 2 to 8.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 2, row 3 to 8.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 2, row 4 to 8.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 2, row 5 to 8.00% of the total screen width
  - Multiboard - Set the width for T2IncomeBoard item in column 2, row 6 to 8.00% of the total screen width
  - Multiboard - Set the text for T1IncomeBoard item in column 1, row 2 to (Name of Player 1 (Red))
  - Multiboard - Set the text for T1IncomeBoard item in column 1, row 3 to (Name of Player 2 (Blue))
  - Multiboard - Set the text for T1IncomeBoard item in column 1, row 4 to (Name of Player 3 (Teal))
  - Multiboard - Set the text for T1IncomeBoard item in column 1, row 5 to (Name of Player 4 (Purple))
  - Multiboard - Set the text for T1IncomeBoard item in column 1, row 6 to (Name of Player 5 (Yellow))
  - Multiboard - Set the text for T2IncomeBoard item in column 1, row 2 to (Name of Player 6 (Orange))
  - Multiboard - Set the text for T2IncomeBoard item in column 1, row 3 to (Name of Player 7 (Green))
  - Multiboard - Set the text for T2IncomeBoard item in column 1, row 4 to (Name of Player 8 (Pink))
  - Multiboard - Set the text for T2IncomeBoard item in column 1, row 5 to (Name of Player 9 (Gray))
  - Multiboard - Set the text for T2IncomeBoard item in column 1, row 6 to (Name of Player 10 (Light Blue))
  - Multiboard - Set the color for T1IncomeBoard item in column 1, row 2 to (100.00%, 0.00%, 0.00%) with 0.00% transparency
  - Multiboard - Set the color for T1IncomeBoard item in column 1, row 3 to (0.00%, 0.00%, 100.00%) with 0.00% transparency
  - Multiboard - Set the color for T1IncomeBoard item in column 1, row 4 to (0.00%, 100.00%, 100.00%) with 0.00% transparency
  - Multiboard - Set the color for T1IncomeBoard item in column 1, row 5 to (100.00%, 0.00%, 100.00%) with 0.00% transparency
  - Multiboard - Set the color for T1IncomeBoard item in column 1, row 6 to (100.00%, 100.00%, 0.00%) with 0.00% transparency
  - Multiboard - Set the color for T2IncomeBoard item in column 1, row 2 to (100.00%, 50.00%, 0.00%) with 0.00% transparency
  - Multiboard - Set the color for T2IncomeBoard item in column 1, row 3 to (0.00%, 100.00%, 0.00%) with 0.00% transparency
  - Multiboard - Set the color for T2IncomeBoard item in column 1, row 4 to (100.00%, 50.00%, 50.00%) with 0.00% transparency
  - Multiboard - Set the color for T2IncomeBoard item in column 1, row 5 to (50.00%, 50.00%, 50.00%) with 0.00% transparency
  - Multiboard - Set the color for T2IncomeBoard item in column 1, row 6 to (50.00%, 50.00%, 100.00%) with 0.00% transparency
  - Multiboard - Hide all multiboards
  - Custom script: if (p == Player(0) and p == Player(1) and p == Player(2) and p == Player(3) and p == Player(4)) then
    - Multiboard - Show T1IncomeBoard
  - Custom script: endf
    - Custom script: if ( GetLocalPlayer() == Player(5) ) then
    - Multiboard - Show T2IncomeBoard
    - Custom script: endf
    - Custom script: if ( GetLocalPlayer() == Player(6) ) then
    - Multiboard - Show T2IncomeBoard
    - Custom script: endf
    - Custom script: if ( GetLocalPlayer() == Player(7) ) then
    - Multiboard - Show T2IncomeBoard
    - Custom script: endf
    - Custom script: if ( GetLocalPlayer() == Player(8) ) then
    - Multiboard - Show T2IncomeBoard
    - Custom script: endf
    - Custom script: if ( GetLocalPlayer() == Player(9) ) then
    - Multiboard - Show T2IncomeBoard
    - Custom script: endf

Noctosphere · Jun 1, 2016

Well, here's the trigger I made with the script you gave me

Board Creation
- Events
  - Time - Elapsed game time is 0.01 seconds
- Conditions
- Actions
  - Multiboard - Create a multiboard with 3 columns and 6 rows, titled (Income - + T1_name)
  - Set T1IncomeBoard = (Last created multiboard)
  - For each (Integer A) from 1 to 6, do (Actions)
    - Loop - Actions
      - Multiboard - Set the width for T1IncomeBoard item in column 1, row (Integer A) to 15.00% of the total screen width
      - Multiboard - Set the width for T1IncomeBoard item in column 2, row (Integer A) to 8.00% of the total screen width
      - Multiboard - Set the width for T1IncomeBoard item in column 3, row (Integer A) to 8.00% of the total screen width
  - Multiboard - Create a multiboard with 3 columns and 6 rows, titled (Income - + T2_name)
  - Set T2IncomeBoard = (Last created multiboard)
  - For each (Integer A) from 1 to 6, do (Actions)
    - Loop - Actions
      - Multiboard - Set the width for T2IncomeBoard item in column 1, row (Integer A) to 15.00% of the total screen width
      - Multiboard - Set the width for T2IncomeBoard item in column 2, row (Integer A) to 8.00% of the total screen width
      - Multiboard - Set the width for T2IncomeBoard item in column 3, row (Integer A) to 8.00% of the total screen width
  - Multiboard - Set the text for T1IncomeBoard item in column 1, row 2 to (Name of Player 1 (Red))
  - Multiboard - Set the text for T1IncomeBoard item in column 1, row 3 to (Name of Player 2 (Blue))
  - Multiboard - Set the text for T1IncomeBoard item in column 1, row 4 to (Name of Player 3 (Teal))
  - Multiboard - Set the text for T1IncomeBoard item in column 1, row 5 to (Name of Player 4 (Purple))
  - Multiboard - Set the text for T1IncomeBoard item in column 1, row 6 to (Name of Player 5 (Yellow))
  - Multiboard - Set the text for T2IncomeBoard item in column 1, row 2 to (Name of Player 6 (Orange))
  - Multiboard - Set the text for T2IncomeBoard item in column 1, row 3 to (Name of Player 7 (Green))
  - Multiboard - Set the text for T2IncomeBoard item in column 1, row 4 to (Name of Player 8 (Pink))
  - Multiboard - Set the text for T2IncomeBoard item in column 1, row 5 to (Name of Player 9 (Gray))
  - Multiboard - Set the text for T2IncomeBoard item in column 1, row 6 to (Name of Player 10 (Light Blue))
  - Multiboard - Set the color for T1IncomeBoard item in column 1, row 2 to (100.00%, 0.00%, 0.00%) with 0.00% transparency
  - Multiboard - Set the color for T1IncomeBoard item in column 1, row 3 to (0.00%, 0.00%, 100.00%) with 0.00% transparency
  - Multiboard - Set the color for T1IncomeBoard item in column 1, row 4 to (0.00%, 100.00%, 100.00%) with 0.00% transparency
  - Multiboard - Set the color for T1IncomeBoard item in column 1, row 5 to (100.00%, 0.00%, 100.00%) with 0.00% transparency
  - Multiboard - Set the color for T1IncomeBoard item in column 1, row 6 to (100.00%, 100.00%, 0.00%) with 0.00% transparency
  - Multiboard - Set the color for T2IncomeBoard item in column 1, row 2 to (100.00%, 50.00%, 0.00%) with 0.00% transparency
  - Multiboard - Set the color for T2IncomeBoard item in column 1, row 3 to (0.00%, 100.00%, 0.00%) with 0.00% transparency
  - Multiboard - Set the color for T2IncomeBoard item in column 1, row 4 to (100.00%, 50.00%, 50.00%) with 0.00% transparency
  - Multiboard - Set the color for T2IncomeBoard item in column 1, row 5 to (50.00%, 50.00%, 50.00%) with 0.00% transparency
  - Multiboard - Set the color for T2IncomeBoard item in column 1, row 6 to (50.00%, 50.00%, 100.00%) with 0.00% transparency
  - Multiboard - Hide all multiboards
  - Custom script: set p = GetLocalPlayer()
  - Custom script: if (p == Player(0) or p == Player(1) or p == Player(2) or p == Player(3) or p == Player(4)) then
  - Multiboard - Show T1IncomeBoard
  - Custom script: endif
  - Custom script: set p = GetLocalPlayer()
  - Custom script: if (p == Player(5) or p == Player(6) or p == Player(7) or p == Player(8) or p == Player(9)) then
  - Multiboard - Show T2IncomeBoard
  - Custom script: endif

It's with this one that I get this error message

Chaosy · Jun 1, 2016

My bad, I made a slight spelling mistake. It should be "player" and not "Player"
also you only need the set p = GetLocalPlayer() once.

I saved this and it works.

Melee Initialization
- Events
  - Map initialization
- Conditions
- Actions
  - Custom script: local player p = GetLocalPlayer()
  - Custom script: if (p == Player(0) and p == Player(1) and p == Player(2) and p == Player(3) and p == Player(4)) then
  - Custom script: endif
  - Custom script: if (p == Player(5) and p == Player(6) and p == Player(7) and p == Player(8) and p == Player(9)) then
  - Custom script: endif

Noctosphere · Jun 1, 2016

Well, I get the same first error message :
Undeclared variable p
but the second one got changed to :
Undeclared function player

Chaosy · Jun 1, 2016

Because you don't have the local variable created (see my example). If you want to use a GUI one use udg_playerVariable instead.

Noctosphere · Jun 1, 2016

okay, changed the script
set p = GetLocalPlayer()
to
local player p = GetLocalPlayer()
and now I get another error message, a single one this time :
locals are only supported at the top of the function
does that means I need to put it at the beginning of my trigger's action?

EDIT : I've put the variable declaration at the beginning of my Trigger's action and now I get the error message :
Undeclared function player

Chaosy · Jun 1, 2016

local player p = GetLocalPlayer() needs to be at the very top (because jass is stupid, other programming languages do not require this)

So, yes.

Noctosphere · Jun 1, 2016

As I said in my edit, I get a new error message :
Undeclared function player

Chaosy · Jun 1, 2016

what.
Just send me the map and I'll do it

Noctosphere · Jun 1, 2016

Chaosy · Jun 1, 2016

Oh. I found the issue, you and me misunderstood each other slightly.
When I said replace Player with player, I meant the local line. Not the if bla bla.

However when testing the map not all values are shown correctly, so there are still issues elsewhere.

Noctosphere · Jun 1, 2016

you mean I should replace GetLocalPlayer() to GetLocalplayer()
?

Chaosy · Jun 1, 2016

No.
I originally wrote "local Player p = GetLocalPlayer()" instead of "local player p = GetLocalPlayer()"
Which was a mistake, told you to fix it but you misunderstood what I meant

Noctosphere · Jun 1, 2016

oh okay, thanks for the map, works now...
But what do you mean by not all values are shown correctly?

Chaosy · Jun 1, 2016

The player names are not there for example.

Noctosphere · Jun 1, 2016

like, players name in the multiboard?
if that's it, well, I should be okay to fix that on my own, thanks a lot

Chaosy · Jun 1, 2016

Yeah.

Noctosphere · Jun 1, 2016

well, looks like the map is corrupted now...
When I try to test it through the map editor, nothing happens, War3 doesn't open at all.
And when I open war3, I go in single player, custom game, and when I select the map, the player panel isnt shown at all. You know, the panel where you select which slot is computer, which one is closed, etc

Dr Super Good · Jun 1, 2016

If the map still opens in the editor it is not corrupt.

Noctosphere · Jun 1, 2016

Well, I can't open it in war3

Dr Super Good · Jun 1, 2016

WC3 will not be able to open maps that have not saved properly (eg compile error) or that have a file path/file name that is too long.

error message upon saving due to multiboard(i guess)

Attachments

Attachments

Similar threads