Elemental Wave [MUI] v1.7.1

[Moderator]

14:30 June 30, 2013
Magtheridon96: Approved.

 

[DivineLight]

I forgot to move it

 

[~DARK~]

My eyes irrtated by screen so much shiny

 

[DivineLight]

My eyes irrtated by screen so much shiny

buy some eyeglasses

 

[Losam]

Sounds good. It is made in which programming language? vJass, GUI / Triggers ... show the Triggers of his appeal.

Losam's Resources:

• [thread=228426]Storm's Call[/thread]
• [thread=224367]Stun System[/thread]
• [thread=235663]Counter Helix[/thread]
• [thread=227374]Combat System[/thread]

 

[gorillabull]

something about this spell makes me think it leaks

 

[DivineLight]

yeah, it leaks old man, that's why this spell is not approved yet

 

[Losam]

LOL.Whenever you put a new work, it remains unapproved by the second order from a moderator, relax.

 

[DivineLight]

oh yea, i'm relax

 

[deathismyfriend]

u need to remove points 1 and 2 in the cast trigger. also u dont need the unDamageGroup

u should store picked unit into a variable and use the variable instead.

rule of thumb anything u use twice or more store into a variable for efficiency and speed.

 

[Losam]

You need post comments for each trigger line.

 

[DivineLight]

Updated:

u need to remove points 1 and 2 in the cast trigger. also u dont need the unDamageGroup

u should store picked unit into a variable and use the variable instead.

rule of thumb anything u use twice or more store into a variable for efficiency and speed.

if i remove points 1 and 2 in the cast trigger, how could i detect target point of ability being cast then?
what variable?

 

[deathismyfriend]

u need to destroy the points at the end of the trigger like u do for point[3]

u store picked unit into a unit variable... if u dont understand look at my tutorial things a guier should know. it shows u how to store the calls into variables for efficiency and speed

u dont need unDamageGroup

 

[DivineLight]

oh sorry i forgot to destroy the points.. i'm getting error xD
thanks for your help
oh, i don't quite understand your tutorial.. what should i do with the variables?

 

[deathismyfriend]

when u fix the things dont forget to update the triggers that are being shown. i never dl spells so cant help unless i see the triggers lol

 

[DivineLight]

sure, Updated
i'm not change the unDamageGroup due to my stupidity to understand your words; store picked unit into a variable and use the variable instead

 

[FRENGERS]

Carrion Swarm ^ .. ^

 

[DivineLight]

Crushing Wave ^=^

 

[deathismyfriend]

to store picked unit to a variable u do it like this...
change this

• Unit Group - Pick every unit in DamageGroup and do (Actions)
  • Loop - Actions
    • Unit - Cause Caster[Current_Index] to damage (Picked unit), dealing Damage[(Level of Ability for Caster[Current_Index])] damage of attack type Spells and damage type Normal
    • Special Effect - Create a special effect attached to the chest of (Picked unit) using SFX[2]
    • Special Effect - Destroy (Last created special effect)
    • Unit Group - Add (Picked unit) to UndamageGroup

to this and remove unDamageGroiup since its not even used for anything

• Unit Group - Pick every unit in DamageGroup and do (Actions)
  • Loop - Actions
    • Set tempUnit = (picked unit)
    • Unit - Cause Caster[Current_Index] to damage tempUnit, dealing Damage[(Level of Ability for Caster[Current_Index])] damage of attack type Spells and damage type Normal
    • Special Effect - Create a special effect attached to the chest of tempUnit using SFX[2]
    • Special Effect - Destroy (Last created special effect)

that is how u store it and use the variable. just like u do for points and other things.

then remove this line

• Unit Group - Remove all units of UndamageGroup from UndamageGroup

 

[FRENGERS]

Fushion!! ^..^

 

[DivineLight]

deathismyfriend
oh, i see.. i'll fix it

FRENGERS
you're twisted my friend ~.~"

Edited:
deathismyfriend
when i tried it the Damage is looping :'(

remove unDamageGroiup since its not even used for anything

you wrong, i forgot to mention this to you:
unDamageGroup is used to Check whether the units is already take the Damage or not.
If Units is already take the Damage it will added to unDamageGroup to prevent the Damage looping
every units in unDamageGroup cannot be damaged.. since it's showed in here

• Set DamageGroup = (Units within AoE[(Level of Ability for Caster[Current_Index])] of Point[1] matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of (Owner of Caster[Current_Index])) Equal to True) and (((Matching unit) is A structure) not Equal to True) and (((Matching unit) is in unDamageGroup) Equal to False)

this also to prevent the Damage looping.. that's why i used this method

 

[Losam]

I believe that you can use (and should), the index for a single variable (like Loc [1] and Loc [2]), and saves variable declaration.

 

[DivineLight]

give me example, please?

 

[deathismyfriend]

did u update the triggers ?

 

[DivineLight]

i did it already (next time i update this, i should write Update!! in description)

 

[deathismyfriend]

u never changed the picked unit like i showed u

 

[DivineLight]

i already changed the picked unit like u showed me
but like i explained before the Damage is looping.. so..?

 

[deathismyfriend]

then u forgot to update the triggers u have posted lol. like i said i dont dl the spells.

 

[DivineLight]

sorry, my bad...
Updated

 

[deathismyfriend]

if u updated the triggers on here then u never stored picked unit like i showed...
see

• Unit Group - Pick every unit in DamageGroup and do (Actions)
• Loop - Actions
• Unit - Cause Caster[Current_Index] to damage (Picked unit), dealing Damage[(Level of Ability for Caster[Current_Index])] damage of attack type Spells and damage type Normal
• Special Effect - Create a special effect attached to the chest of (Picked unit) using SFX[2]
• Special Effect - Destroy (Last created special effect)
• Unit Group - Add (Picked unit) to UndamageGroup

 

[DivineLight]

no, i already stored picked unit like u showed...

 

[deathismyfriend]

u missed it here.

• Special Effect - Create a special effect attached to the chest of (Picked unit) using SFX[2]

and with a temp unit u dont need the array. just make it tempUnit

 

[DivineLight]

ok, fixed

 

[deathismyfriend]

tempUnit should not be part of the spell. change tempUnit[ current index] to tempUnit.

u need to follow the temp variable rule. temp variables are only temporary. urs are not temporary.

u need to change the names of all of ur variables as they can be used in something else and be overwritten. follow the proper naming on the spell submission thread.

also dont de-index tempUnit its a temp variable it doesnt need to be de-indexed at all nor should it be an array

 

[DivineLight]

like this?

Elemental Wave Loop

[trigger=Elemental Wave Loop]Elemental Wave Loop
Events
Time - Every 0.03 seconds of game time
Conditions
Actions
For each (Integer Current_Index) from 1 to Max_Index, do (Actions)
Loop - Actions
Set Point[1] = (Position of Dummy[Current_Index])
Set Point[2] = (Point[1] offset by (Speed[Current_Index] x 0.03) towards Angle[Current_Index] degrees)
Unit - Move Dummy[Current_Index] instantly to Point[2]
Special Effect - Create a special effect at Point[1] using SFX[1]
Special Effect - Destroy (Last created special effect)
Set DamageGroup = (Units within AoE[(Level of Ability for Caster[Current_Index])] of Point[1] matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of (Owner of Caster[Current_Index])) Equal to True) and (((Matching unit) is A structur
Unit Group - Pick every unit in DamageGroup and do (Actions)
Loop - Actions
Set TempUnit = (Picked unit)
Unit - Cause Caster[Current_Index] to damage TempUnit, dealing Damage[(Level of Ability for Caster[Current_Index])] damage of attack type Spells and damage type Normal
Special Effect - Create a special effect attached to the chest of TempUnit using SFX[2]
Special Effect - Destroy (Last created special effect)
Unit Group - Add TempUnit to UndamageGroup
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
DestroyTree Equal to True
Then - Actions
Destructible - Pick every destructible within AoE[(Level of Ability for Caster[Current_Index])] of Point[1] and do (Actions)
Loop - Actions
Destructible - Kill (Picked destructible)
Else - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Dummy[Current_Index] is dead) Equal to True
Then - Actions
Unit Group - Remove all units of UndamageGroup from UndamageGroup
Unit - Remove Dummy[Current_Index] from the game
Set Dummy[Current_Index] = Dummy[Max_Index]
Set Dummy[Max_Index] = No unit
Set Caster[Current_Index] = Caster[Max_Index]
Set Caster[Max_Index] = No unit
Set Angle[Current_Index] = Angle[Max_Index]
Set Angle[Max_Index] = 0.00
Set Current_Index = (Current_Index - 1)
Set Max_Index = (Max_Index - 1)
Else - Actions
Custom script: call DestroyGroup(udg_DamageGroup)
Custom script: call RemoveLocation(udg_Point[1])
Custom script: call RemoveLocation(udg_Point[2])
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
Max_Index Equal to 0
Then - Actions
Trigger - Turn off (This trigger)
Else - Actions
[/trigger]

 

[deathismyfriend]

yes thats better.

 

[DivineLight]

Update

deathismyfriend
Thnks

 

[Daffa]

Remove the point array, use 3 point variable instead, for easier setup

 

[DivineLight]

yes, sure

 

[Daffa]

• Action Error
  • -------- This will determined how far Water Elemental is summoned --------
  • Set EW_Animation = attack
  • -------- What you want your Water Elemental do when it's moving? --------
  • Set EW_Animation_Speed = 50.00

I think you are using wrong comment on wrong action
I think It should be :

• -------- What you want your Water Elemental do when it's moving? --------
• Set EW_Animation = attack
• ------- This will determined how far Water Elemental is summoned --------
• Set EW_Animation_Speed = 50.00

 

[DivineLight]

no i use comment after action to explained what it does..

 

[Daffa]

I see, that's good enough then.

 

[DivineLight]

just waiting when this spell is approved T.T

 

[Map Designer]

Already 3 coment pages and not approved? -___-

 

[DivineLight]

just need to fix things then this will be approved^^

 

[Twilight]

I am not much of a Spell reviewer, but it looks epic to me.
_____________________________________________________
Rating:
4/5

 

[DivineLight]

thanks

 

[Twilight]

your welcome

 

[DivineLight]

update!!