[Solved] Does this unit group leak?

[HuanAk]

Hi, I got a question :

if you remove units from game, do it automatic clean up any group it belong to ?

for example:
- CreepGroup is global variable
- Creep will add to this group when it spawn
- creep will remove from game after it die (eg, corpse will dispear after 1 second)

so, do I still need to remove dying creep from CreepGroup ?
or destory CreepGroup at the end of every round ?

or I don't have to because I already removed units from game, so it will automatic clean up any group it belong to ?

 

[Pharaoh_]

You had better check when a unit dies and if it's in that CreepGroup, Unit Group - Remove (Triggering unit) from CreepGroup.

By the way, no, it doesn't leak this way.

 

[HuanAk]

You had better check when a unit dies and if it's in that CreepGroup, Unit Group - Remove (Triggering unit) from CreepGroup.

By the way, no, it doesn't leak this way.

Thank, another question:

if I do something like this, do it cause any problem or anything bad :

// clean up group at the end without check which group they belong to
Unit Group - Remove (Triggering unit) from CreepGroup.
Unit Group - Remove (Triggering unit) from GroupA.
Unit Group - Remove (Triggering unit) from GroupB.
Unit Group - Remove (Triggering unit) from GroupC.

or similar : // remove ability without check if they have that ability
unit - remove ability (ability_name) from pick unit

 

[Pharaoh_]

No, there's no need to worry about that.

 

[HuanAk]

thank

all good now, +1 rep

 

[Bannar]

Group should be destroyed only if you need them temporary or the instance in which they have been used in has finished. Otherwise, if you make use of global group which is created just to store all creeps spawned it should be not destroyed anytime. In case if you do, you're forced to write:

set udg_someDestroyedGroup = CreateGroup()

Or use one of GetUnits(...) functions to be able to use it again.

Things that leak - may be usefull. But consider that using bj_wantDestroyGroup method to destroy groups leaves leaks in you are enumerating units via Units-of-Type function. In this case create and destroy group manually.

 

[HuanAk]

Group should be destroyed only if you need them temporary or the instance in which they have been used in has finished. Otherwise, if you make use of global group which is created just to store all creeps spawned it should be not destroyed anytime. In case if you do, you're forced to write:

set udg_someDestroyedGroup = CreateGroup()

Or use one of GetUnits(...) functions to be able to use it again.

Things that leak - may be usefull. But consider that using bj_wantDestroyGroup method to destroy groups leaves leaks in you are enumerating units via Units-of-Type function. In this case create and destroy group manually.

I see, I didn't know about CreateGroup() part,

I was though destory group is same as empty unit in group. that is why I worry about group may leaked if I didn't empty it.

 

[Zwiebelchen]

so, do I still need to remove dying creep from CreepGroup ?

Nope, you dont need to manually remove the units from CreepGroup. It doesn't leak, it just leaves something called "shadow reference", which is a bug with WC3, but nothing really serious to worry about. However, you should Remove the group itself in case it is empty.