Does this trigger have any leaks?

X-Death · Aug 8, 2013

Is this knockback trigger leak free?

Dash Knockback
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Dash
- Actions
  - Set Dash_Caster = (Triggering unit)
  - Set Dash_Target = (Target unit of ability being cast)
  - Set Dash_Location = (Position of Dash_Caster)
  - Trigger - Turn on Dash Push <gen>
  - Wait 1.00 game-time seconds
  - Trigger - Turn off Dash Push <gen>
  - Custom script: call RemoveLocation(udg_Dash_Location)

Dash Push
- Events
  - Time - Every 0.04 seconds of game time
- Conditions
- Actions
  - Unit - Move Dash_Target instantly to (Dash_Location offset by ((Distance between Dash_Location and (Position of Dash_Target)) + 5.00) towards (Angle from Dash_Location to (Position of Dash_Target)) degrees)

Daffa · Aug 8, 2013

Yes, the offset in the second trigger leaks, remember that offset creates another location

X-Death · Aug 8, 2013

How would I go about removing that leak? And what would the custom script for removing it be?

deathismyfriend · Aug 8, 2013

first store position of dash into a variable.

then store the offset point

then remove with DestroyLocation()

Daffa · Aug 8, 2013

@DIMF
thanks

deathismyfriend · Aug 8, 2013

Daffa the Mage said:
@DIMF
thanks

np bud

jonhysone · Aug 8, 2013

Translating DIMF's idea :

Set Dash = (Position Of Caster)
Set TempPoint = (Distance between Dash_Location and Dash) + 5.00) towards (Angle from Dash_Location to Dash) degrees)
Unit - Move Dash_Target instantly to TempPoint
Custom script: call RemoveLocation(udg_TempPoint)
Custom script: call RemoveLocation(udg_Dash)

. That's if you didn't understand .

pOke · Aug 8, 2013

deathismyfriend said:
first store position of dash into a variable.

then store the offset point

then remove with DestroyLocation()

Maybe I'm wrong but just to stop any misinformation

Custom script: call RemoveLocation(udg_YourPointVariable)

SA Dashie · Aug 8, 2013

Are you going to want to use this on more than one unit in the map at once. Cause if two units within that wait use it the spell will bug.

Edit: If you use this.

jonhysone said:
Translating DIMF's idea :

Set Dash = (Position Of Caster)

Set TempPoint = (Distance between Dash_Location and Dash) + 5.00) towards (Angle from Dash_Location to Dash) degrees)

Unit - Move Dash_Target instantly to TempPoint

Custom script: call RemoveLocation(udg_TempPoint)

Custom script: call RemoveLocation(udg_Dash)

. That's if you didn't understand .

With this solution it won't bug as much although your trigger will still suffer being turned off if another unit uses the same spell at once at the wrong point.

deathismyfriend · Aug 9, 2013

ooo wow i didnt even notice that this wasnt an instant spell.

@X-death
this needs to be indexed to work for more than one unit.
If u dont know how to do that look at my tutorial things a GUIer should know.

@poke
yes it is RemoveLocation()
sry about that

@jonhysone
just use tempPoint1 and tempPoint2

X-Death · Aug 9, 2013

deathismyfriend said:
ooo wow i didnt even notice that this wasnt an instant spell.

@X-death
this needs to be indexed to work for more than one unit.
If u dont know how to do that look at my tutorial things a GUIer should know.

@poke
yes it is RemoveLocation()
sry about that

@jonhysone
just use tempPoint1 and tempPoint2

I need help making my trigger(s) indexed/MUI. How would I set it up?

jonhysone · Aug 9, 2013

I need help making my trigger(s) indexed/MUI. How would I set it up?

If you want your spell MUI . You need to create a hashtable and saving variables in the hashtable for each player . Or , Using Death's idea which is indexing , You need you variables arrayed but you need to recreate your triggers because they will be off after adding arrays . For Example :

Set Player_Number = (Player Number of (Owner of(Triggering Unit)))
Set Caster[Player_Number] = (Triggering Unit)

X-Death · Aug 9, 2013

Is there a tutorial or something? I don't quite understand how to apply this to my ability.

I don't think using Hashtables for players will work, because each player could possibly own up to 3 of the same unit.

BloodDrunk · Aug 9, 2013

Chapter 12: How to Index

Follow that chapter and it'll make your spell fully MUI and efficient

X-Death · Aug 9, 2013

The_blood said:
Chapter 12: How to Index

Follow that chapter and it'll make your spell fully MUI and efficient

I've read it over. The reason why I don't understand it is because a lot of those variables do not apply to my spell. And I don't know how to differentiate between the tutorial and my spell. It isn't clear and in detail enough.

deathismyfriend · Aug 9, 2013

jonhysone said:
If you want your spell MUI . You need to create a hashtable and saving variables in the hashtable for each player . Or , Using Death's idea which is indexing , You need you variables arrayed but you need to recreate your triggers because they will be off after adding arrays . For Example :

Set Player_Number = (Player Number of (Owner of(Triggering Unit)))

Set Caster[Player_Number] = (Triggering Unit)

using hashtables is slower than indexing.

the blood linked the chapter in my tutorial that will teach u how to index and make things mui

edit:

the chapter how to index is a template thats how u should structure it to make it MUI.
the variables can be changed. Just follow the structure

X-Death · Aug 9, 2013

deathismyfriend said:
using hashtables is slower than indexing.

the blood linked the chapter in my tutorial that will teach u how to index and make things mui

edit:

the chapter how to index is a template thats how u should structure it to make it MUI.
the variables can be changed. Just follow the structure

I'll give it a shot. Sec, then.

deathismyfriend · Aug 9, 2013

X-Death said:
I'll give it a shot. Sec, then.

if u have a hard time post the trigger and ill see what u need to change to fix it.

X-Death · Aug 9, 2013

deathismyfriend said:
if u have a hard time post the trigger and ill see what u need to change to fix it.

Question. You never mentioned creating an Integer variable named "tempInt". Do I just create it, and I don't need to set the variable?

deathismyfriend · Aug 9, 2013

temp variables like tempInt are standard temporary variables that can be used in all triggers.

just create a tempInt variable with no initialization.

X-Death · Aug 9, 2013

deathismyfriend said:
temp variables like tempInt are standard temporary variables that can be used in all triggers.

just create a tempInt variable with no initialization.

Wow, I think I got it working. Is this correct? The only thing I haven't done is remove any leaks.

Deathismyfriend, you're a very good teacher/tutorial writer/code mentor.

What's leaking, and how do I remove them?

Dash Knockback
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Dash
- Actions
  - Set maxIndexDash = (maxIndexDash + 1)
  - Set casterUnitsIndexDash[maxIndexDash] = (Triggering unit)
  - Set targetUnitsIndexDash[maxIndexDash] = (Target unit of ability being cast)
  - Set locationUnitsIndexDash[maxIndexDash] = (Position of casterUnitsIndexDash[maxIndexDash])
  - Set timeLeftDash[maxIndexDash] = 23
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - maxIndexDash Equal to 1
    - Then - Actions
      - Trigger - Turn on Dash Push <gen>
    - Else - Actions

Dash Push
- Events
  - Time - Every 0.01 seconds of game time
- Conditions
- Actions
  - For each (Integer tempInt) from 1 to maxIndexDash, do (Actions)
    - Loop - Actions
      - Unit - Move targetUnitsIndexDash[tempInt] instantly to (locationUnitsIndexDash[tempInt] offset by ((Distance between locationUnitsIndexDash[tempInt] and (Position of targetUnitsIndexDash[tempInt])) + 5.00) towards (Angle from locationUnitsIndexDash[tempInt] to (Position of targetUnitsIndexDash[tempInt])) degrees)
      - Set timeLeftDash[tempInt] = (timeLeftDash[tempInt] - 1)
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        timeLeftDash[tempInt] Equal to 0
        
        Then - Actions
        
        Set casterUnitsIndexDash[tempInt] = casterUnitsIndexDash[maxIndexDash]
        
        Set casterUnitsIndexDash[tempInt] = No unit
        
        Set targetUnitsIndexDash[tempInt] = targetUnitsIndexDash[maxIndexDash]
        
        Set targetUnitsIndexDash[maxIndexDash] = No unit
        
        Set maxIndexDash = (maxIndexDash - 1)
        
        Set tempInt = (tempInt - 1)
        
        Else - Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - maxIndexDash Equal to 0
    - Then - Actions
      - Trigger - Turn off (This trigger)
    - Else - Actions

deathismyfriend · Aug 9, 2013

this leaks a lot (locationUnitsIndexDash[tempInt] offset by ((Distance between locationUnitsIndexDash[tempInt] and (Position of targetUnitsIndexDash[tempInt])) + 5.00)

indexing and de-indexing looks good.

this leaks also Set locationUnitsIndexDash[maxIndexDash] = (Position of casterUnitsIndexDash[maxIndexDash])

X-Death · Aug 9, 2013

What are the custom scripts for all the leaks, and where do I place them?

deathismyfriend · Aug 9, 2013

look at the things that leak tutorial there is a link to it at the bottom of my tutorial.

u need to first store the locations into a variable then use the variable in the gui actions then use the custom script: call RemoveLocation( udg_tempPoint)

X-Death · Aug 9, 2013

deathismyfriend said:
look at the things that leak tutorial there is a link to it at the bottom of my tutorial.

u need to first store the locations into a variable then use the variable in the gui actions then use the custom script: call RemoveLocation( udg_tempPoint)

Deathismyfriend, I found an error of inefficiency in your tutorial for indexing.

Set maxIndexDash = (maxIndexDash - 1)

Apparently there is a more efficient way for checking the Maximum? My knockback ability is breaking with your tutorial applied.

Deathismyfriend, this is what's happening.

Player 1 and Player 2 use the knockback ability close to the same time.

Player 1 uses the knockback ability, the Maximum gets set to 1.
Player 2 uses the knockback ability, the Maximum gets set to 2.
Ability for Player 1 finishes, Maximum gets set back to 1, but the ability is still in motion for Player 2 using the angle from 1.

THIS is why it's breaking. How can I resolve this issue?

Maker · Aug 9, 2013

You make the instance at max index to take the place of the expired instance. Reduce max by one and then reduce the loop integer by one so that the reindexed instance gets run.

deathismyfriend · Aug 9, 2013

Show me your triggers plz.

Also it is not the cause of inefficiency if the max index doesn't get reduced then it will eventually hit the op-limit or the array limit.

X-Death · Aug 9, 2013

Deathismyfriend, how do I prevent this issue from happening?

Here are my triggers:

Dash Initialize
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Dash
- Actions
  - Set maxIndexDash = (maxIndexDash + 1)
  - Set casterUnitsIndexDash[maxIndexDash] = (Triggering unit)
  - Set targetUnitsIndexDash[maxIndexDash] = (Target unit of ability being cast)
  - Set locationUnitsIndexDash[maxIndexDash] = (Position of casterUnitsIndexDash[maxIndexDash])
  - Set timeLeftDash[maxIndexDash] = 22
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - maxIndexDash Equal to 1
    - Then - Actions
      - Trigger - Turn on Dash Knockback <gen>
    - Else - Actions

(Initially Off)

Dash Knockback
- Events
  - Time - Every 0.04 seconds of game time
- Conditions
- Actions
  - For each (Integer tempInt) from 1 to maxIndexDash, do (Actions)
    - Loop - Actions
      - Unit - Move targetUnitsIndexDash[tempInt] instantly to (locationUnitsIndexDash[tempInt] offset by ((Distance between locationUnitsIndexDash[tempInt] and (Position of targetUnitsIndexDash[tempInt])) + 5.00) towards (Angle from locationUnitsIndexDash[tempInt] to (Position of targetUnitsIndexDash[tempInt])) degrees)
      - Set timeLeftDash[tempInt] = (timeLeftDash[tempInt] - 1)
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        timeLeftDash[tempInt] Equal to 0
        
        Then - Actions
        
        Set casterUnitsIndexDash[tempInt] = casterUnitsIndexDash[maxIndexDash]
        
        Set casterUnitsIndexDash[tempInt] = No unit
        
        Set targetUnitsIndexDash[tempInt] = targetUnitsIndexDash[maxIndexDash]
        
        Set targetUnitsIndexDash[maxIndexDash] = No unit
        
        Set maxIndexDash = (maxIndexDash - 1)
        
        Set tempInt = (tempInt - 1)
        
        Else - Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - maxIndexDash Equal to 0
    - Then - Actions
      - Trigger - Turn off (This trigger)
    - Else - Actions

deathismyfriend · Aug 9, 2013

this leaks a lot.

(locationUnitsIndexDash[tempInt] offset by ((Distance between locationUnitsIndexDash[tempInt] and (Position of targetUnitsIndexDash[tempInt])) + 5.00)

u are never de-indexing this variable. This will cause ur whole trigger to bug up.
Set timeLeftDash[maxIndexDash]

Maker · Aug 9, 2013

X-Death said:
Set casterUnitsIndexDash[tempInt] = casterUnitsIndexDash[maxIndexDash]

Set casterUnitsIndexDash[tempInt] = No unit

Set targetUnitsIndexDash[tempInt] = targetUnitsIndexDash[maxIndexDash]

Set targetUnitsIndexDash[maxIndexDash] = No unit

Set maxIndexDash = (maxIndexDash - 1)

Set tempInt = (tempInt - 1)

First you correctly reindex the last to replace the expiring one, but then you set the variables to No unit for some reason. Don't do that.

X-Death · Aug 9, 2013

Maker, I was just following deathismyfriend's tutorial. He does that in his tutorial.

Deathismyfriend,

So, in the second trigger, change this variable:

timeLeftDash[tempInt] Equal to 0

to

timeLeftDash[maxIndexDash] Equal to 0

???

I made this change, but the issue is still occurring. And I will take care of leaks last. I want to make it work first of all.

deathismyfriend · Aug 9, 2013

u need to de-index all counters here also.

Set casterUnitsIndexDash[tempInt] = casterUnitsIndexDash[maxIndexDash]
Set casterUnitsIndexDash[tempInt] = No unit
Set targetUnitsIndexDash[tempInt] = targetUnitsIndexDash[maxIndexDash]
Set targetUnitsIndexDash[maxIndexDash] = No unit
Set maxIndexDash = (maxIndexDash - 1)
Set tempInt = (tempInt - 1)

like this

Set casterUnitsIndexDash[tempInt] = casterUnitsIndexDash[maxIndexDash]
Set casterUnitsIndexDash[tempInt] = No unit
Set targetUnitsIndexDash[tempInt] = targetUnitsIndexDash[maxIndexDash]
Set targetUnitsIndexDash[maxIndexDash] = No unit
Set timeLeftDash[tempInt] = Set timeLeftDash[maxIndexDash]
Set timeLeftDash[maxIndexDash] = 0
Set maxIndexDash = (maxIndexDash - 1)
Set tempInt = (tempInt - 1)

@Maker
i always say to null the objects when they arent used. In spells who know when that index will be used again it might not be for a long time so its better to null them IMO.

X-Death · Aug 9, 2013

deathismyfriend, it appears to be working now.

It bugs if I have 'timeLeftDash[tempInt] Equal to 0' set to 'timeLeftDash[maxIndexDash] Equal to 0' like you suggested though. Is it okay if I leave the array as 'tempInt'?

Here are my triggers.

Dash Knockback
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Dash
- Actions
  - Set maxIndexDash = (maxIndexDash + 1)
  - Set casterUnitsIndexDash[maxIndexDash] = (Triggering unit)
  - Set targetUnitsIndexDash[maxIndexDash] = (Target unit of ability being cast)
  - Set locationUnitsIndexDash[maxIndexDash] = (Position of casterUnitsIndexDash[maxIndexDash])
  - Set timeLeftDash[maxIndexDash] = 23
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - maxIndexDash Equal to 1
    - Then - Actions
      - Trigger - Turn on Dash Push <gen>
    - Else - Actions

Dash Push
- Events
  - Time - Every 0.04 seconds of game time
- Conditions
- Actions
  - For each (Integer tempInt) from 1 to maxIndexDash, do (Actions)
    - Loop - Actions
      - Unit - Move targetUnitsIndexDash[tempInt] instantly to (locationUnitsIndexDash[tempInt] offset by ((Distance between locationUnitsIndexDash[tempInt] and (Position of targetUnitsIndexDash[tempInt])) + 5.00) towards (Angle from locationUnitsIndexDash[tempInt] to (Position of targetUnitsIndexDash[tempInt])) degrees)
      - Set timeLeftDash[tempInt] = (timeLeftDash[tempInt] - 1)
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        timeLeftDash[tempInt] Equal to 0
        
        Then - Actions
        
        Set casterUnitsIndexDash[tempInt] = casterUnitsIndexDash[maxIndexDash]
        
        Set casterUnitsIndexDash[tempInt] = No unit
        
        Set targetUnitsIndexDash[tempInt] = targetUnitsIndexDash[maxIndexDash]
        
        Set targetUnitsIndexDash[maxIndexDash] = No unit
        
        Set timeLeftDash[tempInt] = timeLeftDash[maxIndexDash]
        
        Set timeLeftDash[maxIndexDash] = 0
        
        Set maxIndexDash = (maxIndexDash - 1)
        
        Set tempInt = (tempInt - 1)
        
        Else - Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - maxIndexDash Equal to 0
    - Then - Actions
      - Trigger - Turn off (This trigger)
    - Else - Actions

deathismyfriend · Aug 9, 2013

it looks to be right now.
Also u should use the timer as 0.03 not 0.04

X-Death · Aug 9, 2013

Okay.

Hmm, actually there is still one slight issue.

For some reason, if two units use it both close to the same time, one of the targeted units will not go the correct angle all the way. It will be pushed back a bit, but then move to the right or left. Does this have something to do with the offset?

deathismyfriend · Aug 9, 2013

this has something to do with the instant move GUI action.

To counter this u need to use SetUnitX/Y
there is a chapter in my tutorial that covers how to use SetUnitX/Y and why it is preferable to be used.

X-Death · Aug 9, 2013

Ah, I didn't even need to do that. I changed the function a bit. This works flawlessly.

Unit - Move targetUnitsIndexDash[tempInt] instantly to ((Position of targetUnitsIndexDash[tempInt]) offset by 8.00 towards (Facing of casterUnitsIndexDash[tempInt]) degrees)

deathismyfriend · Aug 9, 2013

except that it leaks 2 locations every time it's used

Vinz · Aug 9, 2013

jonhysone said:
If you want your spell MUI . You need to create a hashtable and saving variables in the hashtable for each player . Or , Using Death's idea which is indexing , You need you variables arrayed but you need to recreate your triggers because they will be off after adding arrays . For Example :

Set Player_Number = (Player Number of (Owner of(Triggering Unit)))

Set Caster[Player_Number] = (Triggering Unit)

Ahem. Speaking of MUI.

Oops I was late. It was already page 3.

SA Dashie · Aug 10, 2013

Change this

Unit - Move targetUnitsIndexDash[tempInt] instantly to ((Position of targetUnitsIndexDash[tempInt]) offset by 8.00 towards (Facing of casterUnitsIndexDash[tempInt]) degrees)

To this.

Set tmpPointA = (Position of targetUnitsIndexDash[tempInt])
Set tmpPointB = (tmpPointA offset by 8.00 towards (Facing of casterUnitsIndexDash[tempInt]) degrees))
Custom script: call RemoveLocation(tmpPointA)
Unit - Move (Triggering unit) instantly to tmpPointB
Custom script: call RemoveLocation(tmpPointB)

Trust me, especialy because it is run periodically this much it will be noticed when the game goes on by someone playing it if used enough times without removing the leak.

Edit: Oh wait you've made a completely new thread that already solved this...

Does this trigger have any leaks?

Similar threads