[JASS] Does this short code cause memory leak?

[Geshishouhu]

Hi, all, does this cause leak?

...........
    local g = CreateGroup()
    set g = GetUnitsOfPlayerAll(Player(0)
    .......
    call DestroyGroup(g)
    set g = null
...............

 

[Vinz]

It depends on what the called function does. Yes, in this case, it does leak. You create a group in a variable then the BJ proceeds to create another in the same variable without destroying it. You don't have to initialize 'g'.

 

[Bannar]

function GetUnitsOfPlayerMatching takes player whichPlayer, boolexpr filter returns group
    local group g = CreateGroup()
    call GroupEnumUnitsOfPlayer(g, whichPlayer, filter)
    call DestroyBoolExpr(filter)
    return g
endfunction

function GetUnitsOfPlayerAll takes player whichPlayer returns group
    return GetUnitsOfPlayerMatching(whichPlayer, null)
endfunction

So yeah, your code leaks.

Instead of setting local group to new group handle (CreateGroup) and then resetting it to function return value (leak comes from there, you havent destoyed previously allocated handle object) you should do:

local group g = GetUnitsOfPlayerAll(Player(0))

 

[Vinz]

or;

local group g = CreateGroup()
call GroupEnumUnitsOfPlayer(g, Player, null)

 

[Geshishouhu]

Thanks for both of you. +Rep