Does this Leak and is it MUI

[daemoth]

hey guys im trying to create cast bars for my new RPG im using this system made by licheus but randomly having issues. Could someone with more experience check for leaks and see if its usable for multiple heroes (my game will have between 3-5 heroes using it at a time each owned by a separate player)

 

[WaterKnight]

You save the data in simple global variables. As soon as a 2nd cast takes place before the first one is finished, the variables are overwritten. It is required to assign memory specifically to the cast instance/to the caster, so it does not possibly collide.

 

[daemoth]

You save the data in simple global variables. As soon as a 2nd cast takes place before the first one is finished, the variables are overwritten. It is required to assign memory specifically to the cast instance/to the caster, so it does not possibly collide.

ill be honest i'm just coming back after like 5 years not making maps and i'm feeling pretty stupid and rusty would you mind uploading a fixed version of the map or explaining in a little more detail i don't quite understand. :S thank you

edit: i think i somewhat might understand maybe not but heres a shot if i used this system and made a trigger / variable set for each spell would it work?
I should also mention each player will only have 1 hero using the spell bar system

 

[WaterKnight]

Then you may make it MPI (player-bound). Make the variables arrays and provide the player's number as index each time.

 

[daemoth]

Then you may make it MPI (player-bound). Make the variables arrays and provide the player's number as index each time.

not gonna lie this is slightly over my head mind linking an example

 

[WaterKnight]

• Set Abil_SheepStrike_Target[(Player number of (Owner of (Triggering unit)))] = (Target point of ability being cast)

Player - Player Number

 

[daemoth]

• Set Abil_SheepStrike_Target[(Player number of (Owner of (Triggering unit)))] = (Target point of ability being cast)

Player - Player Number

so just add that to the one line and im good to go?

 

[WaterKnight]

For each write/read variable line. The

• (Player number of (Owner of (Triggering unit)))

yields a different value for each player/owner of the unit in question. Therefore every player gains another element of the array as storage. If the unit you want to bind the data to is not the Triggering unit in the specific case, of course you need to adjust it to match.

If you do not know what an array is, you can easily browse the internet as it's a very common and simple data structure.

 

[daemoth]

For each write/read variable line. The

• (Player number of (Owner of (Triggering unit)))

yields a different value for each player/owner of the unit in question. Therefore every player gains another element of the array as storage. If the unit you want to bind the data to is not the Triggering unit in the specific case, of course you need to adjust it to match.

If you do not know what an array is, you can easily browse the internet as it's a very common and simple data structure.

so i do it for every line with an array in it that involves triggering unit?
and if i do this do i still need to create new arrays for every spell
sorry im so noob i know what an array is but i dont know how to work them 100% yet.

 

[Vinz]

It depends if you need to create arrays for every spell. If they're instant, no. If they include waits, you can use Mag's wait indexing. If they include loops, you can either make it MPI with player number arrays or MUI with dynamic indexing.