Do locals leak

[Arhowk]

title.

e/ sorry if im being vague, but i mean it in both instances (using a plain local and not nulling it and assigning a leaking function to a local and not destroying/nulling it)

 

[Magtheridon96]

Yes.
Locals always leak unless they are of type:

- integer
- real
- boolean
- string
- code

Some say triggers and players don't leak as well, but you should null them anyways just to stay on the safe side.

 

[Troll-Brain]

http://www.wc3c.net/showthread.php?t=81872

 

[Magtheridon96]

Oh, one other thing:

function temp takes nothing returns nothing
    local location l
    if (boolean expression) then
        set l = something
        // do stuff with l
        call RemoveLocation(l)
        set l = null
    endif
    // we don't null l here because it won't be equal to anything, and thus it won't leak
endfunction

Handles would only leak if they actually have a value

 

[WaterKnight]

Not all handles leak. Agents leak. They are the ones that count references.

 

[Magtheridon96]

Yeah, that's correct, but I'm used to using the term handles :/

 

[WaterKnight]

Non-agent handles are local-only relevant objects and constants.

local image i = CreateImage(...)

call DestroyImage(i)

call CreateImage(...)

After the last line, the variable i will contain the new, lower image because you do not need to nullify the variable here. The id will still be returned and it keeps pointing on the address.

local image b
local image i = CreateImage(...)

call DestroyImage(i)

set b = CreateImage(...)

if (b == i) then
    call BJDebugMsg("that's the case")
endif

 

[Arhowk]

Okay, i understand, but i dont understand something else.

    call TriggerAddCondition( gg_trg_Respawn_Copy, Condition( IsNeutralHostile ) )

Is a line of the code. but when i save, it says

Cannot convert integer to boolean

    call TriggerAddCondition(gg_trg_Respawn_Copy, Condition((1)))

Why is it compiling to 1? Yes theres a trigger above thats called isNeutralHostile

i also have a second problem

local unit group GetUnits = GetUnitsInRectMatching(GetPlayableMapRect(), Condition(function IsNeutralHostile))

(these errors might have something to do with that function)

converts to

local unit group  = GetUnitsInRectMatching(GetPlayableMapRect(), Condition(function IsNeutralHostile))

and than yells at em because theres no name for the variable...

 

[WaterKnight]

vJass gives each function a number. Write

call TriggerAddCondition( gg_trg_Respawn_Copy, Condition( function IsNeutralHostile ) )

instead or vJass also allows

call TriggerAddCondition( gg_trg_Respawn_Copy, function IsNeutralHostile )

by automatically converting it to the above.

 

[Arhowk]

that fixed that problem, but i still have the ug problem

 

[Magtheridon96]

call TriggerAddCondition(gg_trg_Respawn_Copy, Condition(function IsNeutralHostile))

Is the correct form of the line.

edit
Posted too late :L

 

[Arhowk]

ok fixed the second problem, the variable type is group not unit group -.-