Disarm System v1.0.4

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

IcemanBo: http://www.hiveworkshop.com/forums/spells-569/disarm-system-v1-0-4-a-260483/index4.html#post2638876

Older

15:54, 10th Jan 2015
IcemanBo: http://www.hiveworkshop.com/forums/spells-569/disarm-system-v1-0-3-a-260483/index3.html#post2638495

 

[Vinz]

Suggestion; put the configuration info into trigger comments in the Config trigger. The last three triggers in the description also show the same trigger (Disarm Att).

 

[ukn0wnD3str0y3r]

Suggestion; put the configuration info into trigger comments in the Config trigger. The last three triggers in the description also show the same trigger (Disarm Att).

Yes i updated the trigger description already ^^
EDIT: do you mean put the configuration into trigger at Map Initialization?

 

[Vinz]

Okay. I advice against using a Silence to disarm a unit, since it is AoE and is tricky. I suggest Drunken Haze.

I also suggest global dummy.

 

[ukn0wnD3str0y3r]

Okay. I advice against using a Silence to disarm a unit, since it is AoE and is tricky. I suggest Drunken Haze.

I also suggest global dummy.

the AoE of silence i set to 0.10 it will also affected very very very near's enemy? how about 0.01, okay i will try Drunken Haze.

Whats a global dummy?

 

[Vinz]

The one that you use for all instances.

Clever buff removal though, I was expecting ability casts every <interval>.

 

[ukn0wnD3str0y3r]

The one that you use for all instances.

Clever buff removal though, I was expecting ability casts every <interval>.

What do you mean casts every <interval>?

 

[Vinz]

Ordering a dummy to cast the disarm spell every <specified interval>. You did it cleverly though.

 

[ukn0wnD3str0y3r]

Ordering a dummy to cast the disarm spell every <specified interval>. You did it cleverly though.

So should i thanks or what? xD
EDIT: oh yah, can i ask if i have a true sight ability that show in ability section, if i disabled it. will the icon remove and true sight still can work?

 

[Callahan]

There's a way to do this without dummy caster.
You can add cargo hold to targeted unit and remove it at the end duration.

 

[ukn0wnD3str0y3r]

There's a way to do this without dummy caster.
You can add cargo hold to targeted unit and remove it at the end duration.

Why do they need cargo hold?

 

[chobibo]

IIRC, that disables a unit's ability to attack.

 

[GywGod133]

In example of your Normal Attack Trigger is not good method

Why? is not totally detect the damage
only a event if the unit try to attack you

so no damage detection here...

In Hiveworkshop have GUI DDS
So you can use this..

Should be remove this...

• Set DS_Unit1[DS_X] = No unit
• Set DS_Unit2[DS_X] = No unit
• Set DS_Dummy[DS_X] = No unit

This method... the variable replace to another variable

if the first variable is done, the first variable become a second variable

so dont null it

 

[Callahan]

In example of your Normal Attack Trigger is not good method

Why? is not totally detect the damage
only a event if the unit try to attack you

so no damage detection here...

In Hiveworkshop have GUI DDS
So you can use this..

Nothing prevent the user from using GDD event with his system.People should stop critisizing example trigger as it is useless.
Only core triggers matters like loop , init and configuration.

Why do they need cargo hold?

The ability disable attack of the unit that has it.
You could temporarly give cargo hold to the targeted unit.
Right now this system is a dummy cast silence system which is simple and specific but since you make the effect duration triggered it turns out complicated for what it is.
Especially that you can set the duration in object editor and wont need loop trigger that way.

 

[ukn0wnD3str0y3r]

In example of your Normal Attack Trigger is not good method

Why? is not totally detect the damage
only a event if the unit try to attack you

so no damage detection here...

In Hiveworkshop have GUI DDS
So you can use this..

Should be remove this...

• Set DS_Unit1[DS_X] = No unit
• Set DS_Unit2[DS_X] = No unit
• Set DS_Dummy[DS_X] = No unit

This method... the variable replace to another variable

if the first variable is done, the first variable become a second variable

so dont null it

The normal attack example is just an example that show the disarm system works so if other user wanted customize it with GDD or DDS also can done it easily... it just an example

The ability disable attack of the unit that has it.
You could temporarly give cargo hold to the targeted unit.
Right now this system is a dummy cast silence system which is simple and specific but since you make the effect duration triggered it turns out complicated for what it is.
Especially that you can set the duration in object editor and wont need loop trigger that way.

I wanted people to set the disarm duration by they own that they like it. Example he wants it to be random number between .33 to .66 to be the duration and so... people can done the duration by himself

 

[Vinz]

About true sight, it won't work. Put it in a disabled spellbook.

 

[ukn0wnD3str0y3r]

About true sight, it won't work. Put it in a disabled spellbook.

Put a true sight into a disabled spellbook and it will still work without showing the icon?

 

[GywGod133]

Put a true sight into a disabled spellbook and it will still work without showing the icon?

yep....

 

[ukn0wnD3str0y3r]

Umm... can I ask if at every starting trigger i don't use dummy caster and changed it to add "Cargo Hold" to the targeted unit and remove at the end of loop trigger. Will this still be a disarm too?

EDIT: Owh, its work i solved it, so should i remove the dummy caster and change to cargo hold in next verison?

 

[Lender]

if u think it works better then yes no need for a caster is a good thing I guess

 

[ukn0wnD3str0y3r]

if u think it works better then yes no need for a caster is a good thing I guess

Okay im working on it now

 

[ukn0wnD3str0y3r]

Updated~
Verison 1.0.1

 

[Kazeon]

You can do this without any dummy units or spells. Use this script:

• Custom script: call UnitRemoveAbility(u, 'AAtk')

When duration ends, regain the attack ability:

• Custom script: call UnitAddAbility(u, 'AAtk')

So far, I can't spot any disadvantage out of it.

I suggest you to make this a bit more elegant: user don't need to re-create dummy units everytime they want to disarm. How?

• Then - Actions
  • Set DS_X = (DS_X + 1)
  • Set DS_Unit1[DS_X] = Disarm_Caster
  • Set DS_Unit2[DS_X] = Disarm_Target
  • -------- The Disarm Boolean. True = stacking, False = no stacking --------
  • -------- Create the dummy unit and cast the disarm --------
  • Unit - Create 1 Disarm_Dummy for (Owner of DS_Unit1[DS_X]) at (Position of DS_Unit2[DS_X]) facing Default building facing degrees
  • Set DS_Dummy[DS_X] = (Last created unit)
  • Unit - Add Disarm_DummySpell to DS_Dummy[DS_X]
  • Unit - Add a 1.00 second Generic expiration timer to DS_Dummy[DS_X]
  • Unit - Order DS_Dummy[DS_X] to Neutral Dark Ranger - Silence (Position of DS_Unit2[DS_X])
  • -------- Duration of Disarm --------
  • Set DS_Duration[DS_X] = Disarm_Duration
  • Set DS_DurationCurrent[DS_X] = Disarm_DurationCurrent
  • -------- Start the Loop --------
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • DS_X Equal to 1
    • Then - Actions
      • Trigger - Turn on Disarm Timer <gen>
    • Else - Actions

Move the whole block to another trigger (this is going to be your disarm trigger). Then create another non-array variables. This is just an example how user can disarm a unit:

• set "duration" = 3.00
• set "target" = (Attacked unit)
• Custom script: call TriggerEvaluate(your disarm trigger)

Everytime user evaluates your trigger, a new instance of disarm is created, DS_Duration will inherits variable "duration" and DS_Unit (or the target) will inherits variable "target". Using this way, you just need one dummy caster for the whole game (created at map init), and neat and more convincing.

Hope you understand. However, you also missed some:
- (Position of (....)) leaks
- DS_Unit1 is unneeded
- You can only use one "duration" variable. Substract it by 0.03, when reaches 0 => recycle your variables
- Your periodical trigger is not based on variable Disarm_Loop

 

[chobibo]

Custom script: call UnitRemoveAbility(u, 'AAtk')
When duration ends, regain the attack ability:
Custom script: call UnitAddAbility(u, 'AAtk')

So far, I can't spot any disadvantage out of it.

That only disables attack but does not re-enable it. And it's also not 'AAtk' but 'Aatk'.


@OP: Don't use it, doesn't work.

 

[ukn0wnD3str0y3r]

You can do this without any dummy units or spells. Use this script:

• Custom script: call UnitRemoveAbility(u, 'AAtk')

When duration ends, regain the attack ability:

• Custom script: call UnitAddAbility(u, 'AAtk')

So far, I can't spot any disadvantage out of it.

I suggest you to make this a bit more elegant: user don't need to re-create dummy units everytime they want to disarm. How?

• Then - Actions
  • Set DS_X = (DS_X + 1)
  • Set DS_Unit1[DS_X] = Disarm_Caster
  • Set DS_Unit2[DS_X] = Disarm_Target
  • -------- The Disarm Boolean. True = stacking, False = no stacking --------
  • -------- Create the dummy unit and cast the disarm --------
  • Unit - Create 1 Disarm_Dummy for (Owner of DS_Unit1[DS_X]) at (Position of DS_Unit2[DS_X]) facing Default building facing degrees
  • Set DS_Dummy[DS_X] = (Last created unit)
  • Unit - Add Disarm_DummySpell to DS_Dummy[DS_X]
  • Unit - Add a 1.00 second Generic expiration timer to DS_Dummy[DS_X]
  • Unit - Order DS_Dummy[DS_X] to Neutral Dark Ranger - Silence (Position of DS_Unit2[DS_X])
  • -------- Duration of Disarm --------
  • Set DS_Duration[DS_X] = Disarm_Duration
  • Set DS_DurationCurrent[DS_X] = Disarm_DurationCurrent
  • -------- Start the Loop --------
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • DS_X Equal to 1
    • Then - Actions
      • Trigger - Turn on Disarm Timer <gen>
    • Else - Actions

Move the whole block to another trigger (this is going to be your disarm trigger). Then create another non-array variables. This is just an example how user can disarm a unit:

• set "duration" = 3.00
• set "target" = (Attacked unit)
• Custom script: call TriggerEvaluate(your disarm trigger)

Everytime user evaluates your trigger, a new instance of disarm is created, DS_Duration will inherits variable "duration" and DS_Unit (or the target) will inherits variable "target". Using this way, you just need one dummy caster for the whole game (created at map init), and neat and more convincing.

Hope you understand. However, you also missed some:
- (Position of (....)) leaks
- DS_Unit1 is unneeded
- You can only use one "duration" variable. Substract it by 0.03, when reaches 0 => recycle your variables
- Your periodical trigger is not based on variable Disarm_Loop

Thanks for your advices ^^ but isn't it same if i add duration .03 and subtract .03?

Oh wait, i think i get something... if subtract then i can remove one variable "DS_DurationCurrent"?

EDIT: oh yah, and now i removed the dummy caster and replace it by Cargo Hold ability ^^

 

[Vinz]

A problem with Cargo Hold might be if the target has another Cargo Hold with Cargo Capacity, and a Load ability.

 

[ukn0wnD3str0y3r]

A problem with Cargo Hold might be if the target has another Cargo Hold with Cargo Capacity, and a Load ability.

Then dont target the unit xD lol

 

[Vinz]

It's a reason why Drunken Haze is betterer.

 

[ukn0wnD3str0y3r]

Awww but... Cargo Hold is still work as a 'disarm' right... so maybe make 2 types of disarm?
Disarm 1 - cant disarm unit with cargo hold and load? (Cars)
Disarm 2 - disarm every unit
xD

 

[Vinz]

Perhaps.

 

[Callahan]

Cargo is better.It just add and remove ability.
Dummy caster create point, create dummy, remove point, make dummy use ability, remove dummy.It's much slower.
Beside if user want to disarm a unit that use cargo normaly then you just need to make a custom cargo ability different from the one used by trigger.

 

[Vinz]

Dummy caster create point, create dummy, remove point, make dummy use ability, remove dummy.It's much slower.

I was suggesting a global disarm dummy though.

That could work. I initially thought it would add up like Critical Strike.

 

[ukn0wnD3str0y3r]

Updated: Verison 1.0.2
-Remove the 'DS_DurationCurrent' Variables
-Loop changed from +.03 to -.03
-Added another hero to show that this system is MUI

 

[Vinz]

-Added another hero to show that this system is MUI

You can make the ability CD very low too, if you wanna showcase that.

 

[IcemanBo]

Currently the system may cause wrong results, if a unit gets targeted again, while it's already a target by an other instance.

If duration1 ends, the unit's attack will be enabled again, even duration2 is still running.

 

[Vinz]

Alright, then perhaps check per loop if the unit has the cargo ability.

 

[ukn0wnD3str0y3r]

Currently the system may cause wrong results, if a unit gets targeted again, while it's already a target by an other instance.

If duration1 ends, the unit's attack will be enabled again, even duration2 is still running.

Thanks for your advice! i'll fix right after that, so is there anymore problem? except the loop

EDIT: and can i ask the ITE need to put at before duration subtract or after duration == 0?

 

[IcemanBo]

Null the effect[lastIndex] in your deindex part.

"Time - Every 0.03 seconds of game time" is hardcoded. Use the variable, that is initialiszed in your Setup trigger instead of "0.03".

When the target's attack is already disabled before it should get indexed (+ is NOT already indexed by your system), then it should not be indexed at all, as it would bring unwanted results. (you would enable attack, even the user disabled it by default maybe)

 

[ukn0wnD3str0y3r]

Null the effect[lastIndex] in your deindex part.

"Time - Every 0.03 seconds of game time" is hardcoded. Use the variable, that is initialiszed in your Setup trigger instead of "0.03".

When the target's attack is already disabled before it should get indexed (+ is NOT already indexed by your system), then it should not be indexed at all, as it would bring unwanted results. (you would enable attack, even the user disabled it by default maybe)

So changed to Time - Every (Disarm_Loop) seconds of game time?

Set DS_Effect[DS_Y] = DS_Effect[DS_X]?

Put ITE into the loop?
If-
level of cargo hold of unit = 0
Then-
/Do the de-index
Else-
-

Is it like that?

 

[Vinz]

Periodic: Yes.
ITE: No, if it's 0 and the duration has not run out then add it.

 

[ukn0wnD3str0y3r]

Periodic: Yes.
ITE: No, if it's 0 and the duration has not run out then add it.

I don't get it o.0?

 

[ukn0wnD3str0y3r]

Updated Verison 1.0.3~

 

[ukn0wnD3str0y3r]

May I ask, what else need to fix or change? because some spells post late than mine but it is checked by admin faster ._.

 

[IcemanBo]

Make the attachment point configurable.

Make the user decide his own event. Just provide a trigger that will run for registration.
Example:

• Set DisarmUnit = TriggeringUnit
• Set Duration = 5.00
• Trigger - Run Registration

User won't have to bother with system itself. All will be done automatically.

If unit gets registered again while it's already an instance, you have to use the bigger duration of course.

Only remove the dummy spell, if the unit has not had it before registration.

Needs Fix

 

[ukn0wnD3str0y3r]

So do you mean,

*Configuration*
*Run Trigger*
*ITE of the cargo level is 0 or no*
*Add Ability*

Or

Add a new trigger which is need run by the spell of user want to and at the trigger only Disarm_X = Disarm_X + 1?

 

[ukn0wnD3str0y3r]

Updated~ Verison 1.0.4
[+]Add a new starting trigger
[+]Now you may start a disarm more easier

 

[IcemanBo]

The usage looks simple now. It's definitly better.

But atm it doesn't work good for me. After second attack the enemy stays disarmed.

I suggest you to import a UnitIndexer and only update Duration[custom value of unit] on registration.

- Only register one unit per registration. And only one unit is needed in your examples. Not both
- The DisarmSpell, and DisarmAttck triggers are only example. Move them out of the system folder, or mark them as examples.
- Only create the effect if unit is not registered yet.

Needs Fix

 

[ukn0wnD3str0y3r]

$h*t i dont know how to use Unit Indexer @@
Anyway, do you mean before setting the Disarm Start
Add a new variable like Value = Custom Value of DS_Target?
Then only set DS_Duration[Value] = 2.00?

I don't know Unit INdexer T^T

 

[IcemanBo]

Well, the main problem is the system doesn't work correctly at the moment.

And I see further potential problems with it that a unit can be registered multiple times at same time. So you clearly have to check onDeindex if you already should enable attack again or not.

So it's easier if one unit is only registered maximum once, and you only update Duration[UnitIndex] onRegistration.

CustomValue is an integer you can bind to a unit. A Unit indexer gives every unit on map a specific CustomValue, so you can use it for your needs.