Detecting Critical Strikes

[Patio_111]

Hello everybody.

This is a very simple question (I don't know if its easy though, which isn't the same thing as simple). I just wanted to know how I could detect when a hero performs a critical strike with the ability. I've tried using the event "EVENT_PLAYER_UNIT_SPELL_EFFECT," but it doesn't seem to recognize the spell Critical Strike, neither with "EVENT_PLAYER_UNIT_SPELL_CAST." I don't even set any conditions and it still doesn't recognize it.

Thanks in advance.

By the way, here is the code I used to test it

scope Crit initializer Init
    
    private function Actions takes nothing returns nothing
        call BJDebugMsg("Critical!")
    endfunction
    
    private function Init takes nothing returns nothing
        local trigger CritTrig = CreateTrigger()
        call TriggerRegisterAnyUnitEventBJ(CritTrig, EVENT_PLAYER_UNIT_SPELL_EFFECT)     //or SPELL_CAST
        call TriggerAddAction(CritTrig, function Actions)
        set CritTrig = null
    endfunction
    
endscope

just in case I've done anything stupid.

 

[Arumen]

Well, Critical Strike is neither an effect nor a cast according to most of the game. Your wording may be what is off. I am not all to familiar with JASS, but is ABILITY an option?

 

[Raven0]

You can't detect critical strikes :0

You have to custom make a crit system if you want to have total control over it ^-^

 

[Patio_111]

You can't detect critical strikes :0

You have to custom make a crit system if you want to have total control over it ^-^

Gah, okay. Useful to know, +rep for the info.

 

[mckill2009]

make bash as custom ability, and a formula of CS after the attacked unit has a 'bash buff' called 'stun' then use Damage target trigger...that way you can detect CS as a custom ability...

 

[GhostThruster]

I've made loads of trigger-based CS before... I may be able to find my posts...

EDIT: I posted this before:

• CS 1
  • Events
    • Map initialization
    • Unit - A unit enters (Playable map area)
  • Conditions
  • Actions
    • -------- Removes unit group leak --------
    • Custom script: set bj_wantDestroyGroup =true
    • Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) is in Damage_group) Equal to False
          • Then - Actions
            • -------- Adds it to a unit group so the same unit is not picked twice --------
            • Unit Group - Add (Picked unit) to Damage_group
            • -------- Adds the damage detection event --------
            • Trigger - Add to CS 2 <gen> the event (Unit - (Picked unit) Takes damage)
          • Else - Actions

• CS 2
  • Events
  • Conditions
    • (Level of Critical Strike for (Damage source)) Greater than 0
  • Actions
    • -------- If a random real is below the %, the action fires --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Random real number between 1.00 and 100.00) Less than or equal to 15.00
      • Then - Actions
        • -------- Turns off to stop an endless loop --------
        • Trigger - Turn off (This trigger)
        • -------- By dealing damage again, it is 'doubling' --------
        • Unit - Cause (Damage source) to damage (Triggering unit), dealing (Damage taken) damage of attack type Chaos and damage type Universal
        • -------- Floating text! --------
        • Floating Text - Create floating text that reads (String((Integer((2.00 x (Damage taken)))))) above (Triggering unit) with Z offset 64.00, using font size 10.00, color (100.00%, 0.00%, 0.00%), and 0.00% transparency
        • Floating Text - Set the velocity of (Last created floating text) to 60.00 towards 90.00 degrees
        • Floating Text - Change (Last created floating text): Disable permanence
        • Floating Text - Change the lifespan of (Last created floating text) to 2.00 seconds
        • Floating Text - Change the fading age of (Last created floating text) to 1.70 seconds
        • -------- Turns on for use again --------
        • Trigger - Turn on (This trigger)
      • Else - Actions

 

[defskull]

Yes, you can detect CUSTOM CRITICAL STRIKE, we base it off from default abilities
Use trigger for the custom ability
When the custom ability critical strike is in place (occurs through trigger), you can use that trigger to detect it
And wa-la !
The effect =D

 

[Patio_111]

Okay, thanks to everyone. I guess I'll have to make my own critical strike ability then (which isn't hard at all, I'm just lazy and wanted to save some time). I just have this very cool idea for a spell based on critical strike. I'll post it in the spell section when it's finished. Once again, thanks for the help!