Demon Tag [By Mumbis]

[Moderator]

Vengeancekael
Date: 2013/Jan/22 18:23:04

[Please do not send me a message, use Staff Contact] ​

Comment:

Originality-wise there's not much to cite, however this is of acceptable quality.
Although you should improve the building tooltips, etc. (add colors, more rows, etc.)
And the fountain in the middle shouldn't be in the ground, just raise it to a normal level.​

Not Rated

[tr]​

Rules

 

[-Kobas-]

Some triggers are bad, like that income trigger.
Will check map more closely soon.

Oh hero cost lumber.

 

[Mumbis]

@-Kobas-
Incomming update!
has some fixes in it!

EDIT: Map updated

 

[Vengeancekael]

You could just disable the income for player x trigger if that specific player isn't in-game.
You wouldn't need to check it everytime that way.
Or just merge them all into one trigger, but that could overload the cpu a bit.
Also for 'cat income', just pick every player in the game and give that much gold to picked players.
However the 'cat dies' triggers can really be merged into one trigger.
Just change the event to 'A unit dies', then use different if then elses checking which unit has died.

A custom preview image wouldn't hurt either =)

I'll have a more detailed look at the map on friday.

 

[Mumbis]

@Vengeancekael
The income trigger can not be merged, I just split it after having a merged one ;o
If it is merged, it all goes... kinda messed up, everybody gets insane amounts of gold if there's more than one player building stuff etc etc, that is why it is split
Did the same for the "Die" trigger to avoid truble with it, don't know if it works to merge it, but I could give it a try if you think it'll work!

I will add a custom preview image, I just need to get some time to do so
probably will do it in the weekend

 

[-Kobas-]

Trigger is bad and, horrible inefficient.
Just convert it into custom script and replace that code with this:

function Income_Loop takes nothing returns nothing
    if GetUnitTypeId(GetEnumUnit()) == 'h00C' then
        call SetPlayerState(GetOwningPlayer(GetEnumUnit()), PLAYER_STATE_RESOURCE_GOLD, GetPlayerState(GetOwningPlayer(GetEnumUnit()), PLAYER_STATE_RESOURCE_GOLD) + 2)
    endif
    if GetUnitTypeId(GetEnumUnit()) == 'h00D' then
        call SetPlayerState(GetOwningPlayer(GetEnumUnit()), PLAYER_STATE_RESOURCE_GOLD, GetPlayerState(GetOwningPlayer(GetEnumUnit()), PLAYER_STATE_RESOURCE_GOLD) + 5)
    endif
    if GetUnitTypeId(GetEnumUnit()) == 'h00E' then
        call SetPlayerState(GetOwningPlayer(GetEnumUnit()), PLAYER_STATE_RESOURCE_GOLD, GetPlayerState(GetOwningPlayer(GetEnumUnit()), PLAYER_STATE_RESOURCE_GOLD) + 8)
    endif
    if GetUnitTypeId(GetEnumUnit()) == 'h00F' then
        call SetPlayerState(GetOwningPlayer(GetEnumUnit()), PLAYER_STATE_RESOURCE_GOLD, GetPlayerState(GetOwningPlayer(GetEnumUnit()), PLAYER_STATE_RESOURCE_GOLD) + 10)
    endif
endfunction

function Income_Actions takes nothing returns nothing
    local integer i = 0
    local group G = CreateGroup()
    loop
        exitwhen i > 8
        call GroupEnumUnitsOfPlayer(G, Player(i), null)
        call ForGroup(G, function Income_Loop)
        call GroupClear(G)
        set i = i + 1
    endloop
    call DestroyGroup(G)
    set G = null
endfunction

//===========================================================================
function InitTrig_Income takes nothing returns nothing
    set gg_trg_Income = CreateTrigger(  )
    call TriggerRegisterTimerEvent(gg_trg_Income, 5.00, true)
    call TriggerAddAction( gg_trg_Income, function Income_Actions )
endfunction

It work flawlessly

 

[Mumbis]

@-kobas-
Ignore my latest PM, I got it working!!!
Thanks for the trigger! Adding you to credits if you wanna x)

Just gonna fix some other stuff before updating

EDIT:
Map updated!

 

[Vengeancekael]

Nice, you've removed the memory leaks! =)

Now just fix the ugly terrain parts shown in the screenshots below:

First image: Remove those blizzard cliffs and use the height tool. Also add more terrain tile variation and maybe use custom animated grass models.

Second image: Remove the cliff under the fountain.

Fix that and it'll get approved. Rejected until updated.

 

[Mumbis]

Fixed as requested! (In a way I thought were appropriate ;P)

Nice, you've removed the memory leaks! =)

Now just fix the ugly terrain parts shown in the screenshots below:

First image: Remove those blizzard cliffs and use the height tool. Also add more terrain tile variation and maybe use custom animated grass models.

Second image: Remove the cliff under the fountain.

Fix that and it'll get approved. Rejected until updated.