[JASS] Custom Script: How to exit loop when...?

[Lightstalker]

How can I exist a loop when Ability_Cast = Ability_Learn[Ability_Integer]

This is what I have right now:

• Allocating Skills
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • And - All (Conditions) are true
      • Conditions
        • ((Triggering unit) is A Hero) Equal to True
        • Ability_Points[(Player number of (Owner of (Triggering unit)))] Greater than or equal to 1
  • Actions
    • Set Ability_Cast = (Ability being cast)
    • For each (Integer A) from 1 to 12, do (Actions)
      • Loop - Actions
        • Set Ability_Integer = (Integer A)
        • Custom script: exitwhen (GetAbilityId(_udg_Ability_Cast) == udg_Ability_Learn[udg_Ability_Integer])

I get error "Expected a name"

 

[Justify]

_udg_Ability_Cast

try it without this^^

 

[Lightstalker]

_udg_Ability_Cast

try it without this^^

still get the error.

 

[Saia_Djinn]

The problem is you already have exitwhen and this is the loop 1-12 you need another custom script which is a new loop
do it with
custom script :loop (yeah just loop ) before the variable setting in the loop

also make what justify old you

 

[Lightstalker]

The problem is you already have exitwhen and this is the loop 1-12 you need another custom script which is a new loop
do it with
custom script :loop (yeah just loop ) before the variable setting in the loop

also make what justify old you

What do you mean I already have exitwhen? Can you post a quick trigger please

 

[Saia_Djinn]

i cant post it but your code would like in jass like about this

loop
exitwhen exitwhen loop_integer _a > loop_integer_b( or 12)
set a = a+1
your actions
exitwhen your exitwhen
endloop

you see the point ? and i gave you a solution =D just make another loop there in your case with custom scripts =D

loop
    exitwhen loop_integer _a > loop_integer_b( or 12)
    set a = a+1
        loop // this is a new requirement do it with custom script
             your actions  //**
             exitwhen - your exitwhen   //**
        endloop// this is a new requirement do it with custom script
endloop

 

[Lightstalker]

i cant post it but your code would like in jass like about this

loop
exitwhen exitwhen loop_integer _a > loop_integer_b( or 12)
set a = a+1
your actions
exitwhen your exitwhen
endloop

you see the point ? and i gave you a solution =D just make another loop there in your case with custom scripts =D

loop
    exitwhen loop_integer _a > loop_integer_b( or 12)
    set a = a+1
        loop // this is a new requirement do it with custom script
             your actions  //**
             exitwhen - your exitwhen   //**
        endloop// this is a new requirement do it with custom script
endloop

The problem is that I'm trying to exit the loop at a certain time and I don't know how to exit a loop when the ability cast is = to ability[X].

 

[Justify]

Its not forbidden to have multiple "exitwhen" in the same loop and there isn't a reason why it should be...
The problem is "GetAbilityId"... this function doesn't exist, at least I never heard of it and JassCraft doesn't "know" it too
I bet you're searching for "GetSpellAbilityId"

@Saia_Djinn: Please stop posting stuff when you don't know what you're talking about :/ exitwhen only stops the current loop and not the ones "above" it, so your idea can't work...

 

[Saia_Djinn]

Edit oh yes your right justify just forget my trassh talk sry

 

[GhostWolf]

If you don't know what you're talking about, better be silent.

 

[Lightstalker]

Custom script:   exitwhen (GetSpellAbilityId(udg_Ability_Cast) == udg_Ability_Learn[udg_Ability_Integer])

I get "invalid number of arguments" now

 

[Mechanical Man]

Use a variable isntead of A or B and set that variable to the max number when the condition is set.

 

[Eleandor]

GetSpellAbilityId() takes no parameters. It's basically jass for "Ability being cast"

I think what you're looking for is this:
exitwhen (udg_Ability_Cast == udg_Ability_Learn[udg_Ability_Integer])

 

[Lord_BoNes]

You'd also be (only slightly) better off using:

exitwhen (udg_Ability_Cast == udg_Ability_Learn[bj_forLoopAIndex])

and forget the udg_Ability_Integer variable all together.

It's only 1 CPU cycle per loop, but, it's a good practice to look for faster ways to do things... especially once you move on to more complex things.

EDIT:
@Lightstalker: Just looking over that script of yours, shouldn't "triggering unit" be "casting unit"?

 

[Teelo]

Couldn't you just use:

• Trigger - Skip remaining actions

 

[Justify]

This doesn't stop a loop but the entire trigger, and that's not what he wants

 

[Lightstalker]

You'd also be (only slightly) better off using:

exitwhen (udg_Ability_Cast == udg_Ability_Learn[bj_forLoopAIndex])

and forget the udg_Ability_Integer variable all together.

It's only 1 CPU cycle per loop, but, it's a good practice to look for faster ways to do things... especially once you move on to more complex things.

EDIT:
@Lightstalker: Just looking over that script of yours, shouldn't "triggering unit" be "casting unit"?

Could I? I heard bjs were bad, but if they're not I'll just use that. Much easier than making an integer.

 

[Lord_BoNes]

When being told to avoid BJ's, it's in reference to BJ functions that just call other functions (wasting CPU time and lowering performance). That BJ I gave you is the JASS equivilant of "Integer A" in GUI. It is a direct reference to the variable, and would gain you CPU time (as stated earlier, only 1 cycle per loop. But, it can add up). The way you did it was, simply put:

udg_Ability_Integer = bj_forLoopAIndex
exitwhen (udg_Ability_Cast == udg_Ability_Learn[udg_Ability_Integer])

My way:

exitwhen (udg_Ability_Cast == udg_Ability_Learn[bj_forLoopAIndex])

I skip the useless "udg_Ability_Integer = bj_forLoopAIndex"... you don't need it, just access what udg_Ability_Integer is pointing to directly. In a way, you'd created your own mini BJ.

Hope this helps you understand what I meant