[JASS] custom script help

[Ultimatus]

Hello can someone help my with a a custom scipt. i dont know how to change the location. This is the trigger and REVIVE is the name of the lacation.

 call ReviveHeroLoc(OURHERO, GetRectCenter(gg_rct_REVIVE, true)

this trigger is wrong coz it shows errors.

 

[Jacek]

most likely the error is with OURHERO... it would have to be local variable, I bet you have global variable (Trigger Editor -> Variables). Try replacing OURHERO with udg_OURHERO, and say what happens

 

[Dr Super Good]

Simply add this to you jass trigger.

local location l = GetRectCenter(gg_rct_REVIVE)
call ReviveHeroLoc(OURHERO,l,true)
call RemoveLocation(l)
set l = null

You basicly did not close your call and gave the boolean to the wrong function.

If you are using GUI (not recomended), you need to put the local before any actions in the actions part of the trigger or it will fail syntax. The other 3 lines can be called directly after each other.

 

[Ultimatus]

@ Dr Goku no it show 3 more errors. i use the trigger from http://world-editor-tutorials.thehelper.net/revive.php

 

[Dr Super Good]

I am sorry, but you are not helpfull.
Please post the trigger that uses this (all functions), the errors you get, and what globals it uses.

MAKE SURE OURHERO IS A LOCAL OR IT BUST HAVE udg_ Before its name if it is a global.

 

[PurplePoot]

Should have a closing bracked after gg_rct_REVIVE. And super, I know that trigger, OURHERO is a local

call ReviveHeroLoc(OURHERO, GetRectCenter(gg_rct_REVIVE), true)

That should work

 

[UnMi]

Eh?
You people are underestimating the power of globals.
Get a global location from the center of that REVIVE-rect at initialization and use use use it without having to remove it!!!

 

[PurgeandFire]

Eh?
You people are underestimating the power of globals.
Get a global location from the center of that REVIVE-rect at initialization and use use use it without having to remove it!!!

If you use a location, whether or not it is a global or a local, it will leak if you use it without removing it.

 

[PurplePoot]

Even better...

call ReviveHero( OURHERO, GetRectCenterX( gg_rct_REVIVE ), GetRectCenterY( gg_rct_REVIVE ), true )

He was just asking why that wasn't compiling ><

 

[paskovich]

If you use a location, whether or not it is a global or a local, it will leak if you use it without removing it.

He is talking about storing the location at map init, and use that location everywhere instead of GetRectCenter(..). You don't have to remove this (single) leak, as you use it over and over again as a global. You do not create new locations to that variable, so you don't have to remove it. UnMi is right, this is a good way to optimize triggers that use the same point on each run. It's true that it'll leave one leak per location, but that does not matter...

 

[Ultimatus]

this is mine trigger

• function Trig_revive_Actions takes nothing returns nothing
  • local timerdialog WINDOW
  • local integer HEROWAIT
  • local timer OURTIMER
  • local unit OURHERO
  • set OURHERO = GetDyingUnit()
  • set HEROWAIT = ( GetHeroLevel(OURHERO) )
  • set OURTIMER = CreateTimer()
  • call StartTimerBJ( OURTIMER, false, ( I2R(HEROWAIT) ))
  • call CreateTimerDialogBJ ( OURTIMER, GetPlayerName(GetOwningPlayer(OURHERO)) )
  • set WINDOW = GetLastCreatedTimerDialogBJ()
  • call TimerDialogDisplayForPlayerBJ( true, WINDOW, GetOwningPlayer(OURHERO) )
  • call PolledWait( HEROWAIT )
  • call ReviveHeroLoc(OURHERO, GetRectCenter(gg_rct_REVIVE, true)
  • call PanCameraToTimedLocForPlayer( GetOwningPlayer(OURHERO), GetUnitLoc(OURHERO), 0.60 )
  • call DestroyTimerDialog(WINDOW)
• endfunction

and this dont work

• call ReviveHeroLoc(OURHERO, GetRectCenter(gg_rct_REVIVE, true)

 

[Dr Super Good]

Your opening 2 functions befor closing 1. GUI actions by default open a function, and you open another function.

And why are you using GUI? Switch over to pure JASS since it is easier to work with text and you can write triggers more efficently.

Also I recomend you look at one of our many jass tutorials to get some good starting jass know how before atempting anything with JASS.

 

[paskovich]

You're missing a ")" from that line.
Correct it to:

call ReviveHeroLoc(OURHERO, GetRectCenter(gg_rct_REVIVE), true)

 

[PurplePoot]

this is mine trigger

• function Trig_revive_Actions takes nothing returns nothing
  • local timerdialog WINDOW
  • local integer HEROWAIT
  • local timer OURTIMER
  • local unit OURHERO
  • set OURHERO = GetDyingUnit()
  • set HEROWAIT = ( GetHeroLevel(OURHERO) )
  • set OURTIMER = CreateTimer()
  • call StartTimerBJ( OURTIMER, false, ( I2R(HEROWAIT) ))
  • call CreateTimerDialogBJ ( OURTIMER, GetPlayerName(GetOwningPlayer(OURHERO)) )
  • set WINDOW = GetLastCreatedTimerDialogBJ()
  • call TimerDialogDisplayForPlayerBJ( true, WINDOW, GetOwningPlayer(OURHERO) )
  • call PolledWait( HEROWAIT )
  • call ReviveHeroLoc(OURHERO, GetRectCenter(gg_rct_REVIVE, true)
  • call PanCameraToTimedLocForPlayer( GetOwningPlayer(OURHERO), GetUnitLoc(OURHERO), 0.60 )
  • call DestroyTimerDialog(WINDOW)
• endfunction

and this dont work

• call ReviveHeroLoc(OURHERO, GetRectCenter(gg_rct_REVIVE, true)

Should have a closing bracked after gg_rct_REVIVE. And super, I know that trigger, OURHERO is a local

call ReviveHeroLoc(OURHERO, GetRectCenter(gg_rct_REVIVE),  true)

That should work

Even better...

call ReviveHero(OURHERO,GeRectCenterX(gg_rct_REVIVE),GetRectCenterY(gg_rct_REVIVE),true)

He was just asking why that wasn't compiling ><

Please read a bit more next time, Ultimatus

 

[Dr Super Good]

Stop posting JASS in TRIGGER tags, JASS tags are for JASS and TRIGGER tags are for GUI.