Cursed Lightning

[Pyrogasm]

• Don't use the Unit - Damage Area function. It is target-agnostic and will damage the caster as well as allied units in the area like a ground attack from catapults. Additionally the damage dealt is actually N*SpellDmg where N is the number of units in the group, because your trigger tells the caster to damage the entire area once for each unit inside it. I assume you did not intend this. Change the damage line to Unit - Damage Target instead. There's also no target filtering right now; when you set the group variable you should use some Matching... commands to only grab nearby units hostile to the caster that are not spell-immune rather than just grabbing all units nearby.
  
  
• Why use a dummy unit to follow the target around when you could just reduce the armor of the target directly with something like inner fire? (there are other options too)
  
  
• Even if having a dummy unit was the best way, simply ordering it to follow the target is not an acceptable implementation. What if the target jumps over a wall? What if it has a spell that teleports it somewhere else on the map? Etc. If you're going to do it that way you'll need to manually move the dummy unit to the target's position on a low-timeout periodic timer. This brings me to my fourth point:
  
  
• This is not MUI, and using a timer to move the unit would make it even less so. It needs to use dynamic indexing; read this for more information: Visualize: Dynamic Indexing
  
  
• What exactly is the point of CL_Debuff_Group? Nothing is ever added to it so I don't see how it does anything. In any case you're erroneously destroying CL_Debuff_Group in the periodic trigger, which means after the first time it runs the group can't have any units added to it and is doubly pointless. You can replace the group destroy line with a Unit Group - Remove all units command, but I'm still not sure that that should happen there at all.
  
  
• What if the caster dies while the spell is in effect? Currently it will stop dealing damage (well, unless dead units can deal damage but not sure on that one and in any case if the unit was explicitly removed from the map the damage every 2 seconds would fail).
  
  
• The spell's tooltip says nothing about armor reduction or periodic damage that follows the target.

 

[Jay-B]

• Don't use the Unit - Damage Area function. It is target-agnostic and will damage the caster as well as allied units in the area like a ground attack from catapults. Additionally the damage dealt is actually N*SpellDmg where N is the number of units in the group, because your trigger tells the caster to damage the entire area once for each unit inside it. I assume you did not intend this. Change the damage line to Unit - Damage Target instead. There's also no target filtering right now; when you set the group variable you should use some Matching... commands to only grab nearby units hostile to the caster that are not spell-immune rather than just grabbing all units nearby.
  
  
• Why use a dummy unit to follow the target around when you could just reduce the armor of the target directly with something like inner fire? (there are other options too)
  
  
• Even if having a dummy unit was the best way, simply ordering it to follow the target is not an acceptable implementation. What if the target jumps over a wall? What if it has a spell that teleports it somewhere else on the map? Etc. If you're going to do it that way you'll need to manually move the dummy unit to the target's position on a low-timeout periodic timer. This brings me to my fourth point:
  
  
• This is not MUI, and using a timer to move the unit would make it even less so. It needs to use dynamic indexing; read this for more information: Visualize: Dynamic Indexing
  
  
• What exactly is the point of CL_Debuff_Group? Nothing is ever added to it so I don't see how it does anything. In any case you're erroneously destroying CL_Debuff_Group in the periodic trigger, which means after the first time it runs the group can't have any units added to it and is doubly pointless. You can replace the group destroy line with a Unit Group - Remove all units command, but I'm still not sure that that should happen there at all.
  
  
• What if the caster dies while the spell is in effect? Currently it will stop dealing damage (well, unless dead units can deal damage but not sure on that one and in any case if the unit was explicitly removed from the map the damage every 2 seconds would fail).
  
  
• The spell's tooltip says nothing about armor reduction or periodic damage that follows the target.

Thank you for the information @Pyrogasm i'll be updating this spell to fix those bugs

 

[Jay-B]

@Pyrogasm i changed the "Unit - Damage Area" - "Unit - Damage Target", but it seems like it doesn't afflict any damage to the targeted unit

i separated the Cast trigger and the damage trigger to avoid any mess.

• Cursed Lightning Damage
  • Events
  • Conditions
  • Actions
    • Set CL_Group = (Units within CL_Radius[CL_Index] of CL_Point matching (CL_Target Equal to (Picked unit)))
    • Set CL_Player = (Triggering player)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • CL_Index Greater than 1
      • Then - Actions
        • Unit Group - Pick every unit in CL_Group and do (Actions)
          • Loop - Actions
            • Unit - Cause CL_Caster to damage CL_Target, dealing CL_Damage[CL_Index] damage of attack type Spells and damage type Normal
        • Custom script: call DestroyGroup(udg_CL_Group)
      • Else - Actions
    • Custom script: call RemoveLocation(udg_CL_Point)

 

[doomhammer99]

@Jay-B, you have to set CL_Target = Picked unit.
and the player should be set into a variable
e.g

• Set CL_Owner = (Owner of (Triggering unit))

edit:
aslo why?

• -------- Don't change unless there are bugs! --------

configs should always be configurable

 

[JC Helas]

@Jay-B, you have to set CL_Target = Picked unit.
and the player should be set into a variable
e.g

• Set CL_Owner = (Owner of (Triggering unit))

edit:
aslo why?

• -------- Don't change unless there are bugs! --------

configs should always be configurable

also this

Special Effect - Create a special effect attached to the origin of CL_Target using CL_Ground_Special_Effect

Special Effect - Create a special effect at CL_Point using CL_Special_Effect
pay attention from getting rid this effects

in this case, you used group to your loop so I suggest to hash everything.

Unit Group - Pick every unit in CL_Debuff_Group and do (Actions)

Loop - Actions

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

((Picked unit) has buff Cursed Lighting (Debuff)) Equal to True

Then - Actions

Unit - Cause CL_Caster to damage (Picked unit), dealing CL_Damage_Overtime[CL_Ability_Level] damage of attack type Spells and damage type Normal

Else - Actions

Unit Group - Remove (Picked unit) from CL_Debuff_Group

Custom script: call DestroyGroup(udg_CL_Debuff_Group)

also this,, you had mention picked unit for many times, I suggest to create temporary unit variable and set it above the action if then else

 

[Jay-B]

@Jay-B, you have to set CL_Target = Picked unit.
and the player should be set into a variable
e.g

• Set CL_Owner = (Owner of (Triggering unit))

edit:
aslo why?

• -------- Don't change unless there are bugs! --------

configs should always be configurable

also this

Special Effect - Create a special effect attached to the origin of CL_Target using CL_Ground_Special_Effect

Special Effect - Create a special effect at CL_Point using CL_Special_Effect
pay attention from getting rid this effects

in this case, you used group to your loop so I suggest to hash everything.

Unit Group - Pick every unit in CL_Debuff_Group and do (Actions)

Loop - Actions

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

((Picked unit) has buff Cursed Lighting (Debuff)) Equal to True

Then - Actions

Unit - Cause CL_Caster to damage (Picked unit), dealing CL_Damage_Overtime[CL_Ability_Level] damage of attack type Spells and damage type Normal

Else - Actions

Unit Group - Remove (Picked unit) from CL_Debuff_Group

Custom script: call DestroyGroup(udg_CL_Debuff_Group)

also this,, you had mention picked unit for many times, I suggest to create temporary unit variable and set it above the action if then else

more like this?

• Cursed Lightning Cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to CL_Ability
  • Actions
    • -------- -------- --------
    • -------- Casting Variables --------
    • -------- -------- --------
    • Set CL_Caster = (Triggering unit)
    • Set CL_Player = (Owner of CL_Caster)
    • Set CL_Ability_Lvl = (Level of CL_Ability for CL_Caster)
    • Set CL_Target = (Picked unit)
    • Set CL_Point = (Position of CL_Target)
    • -------- -------- --------
    • -------- Creating the dummy unit --------
    • -------- -------- --------
    • Unit - Create 1 CL_Dummy for Player 1 (Red) at (Position of CL_Target) facing Default building facing degrees
    • Set CL_Dummy_Unit_Var = (Last created unit)
    • -------- Adding an Expiration Timer --------
    • -------- -------- --------
    • Unit - Add Cursed Lightning Debuff to CL_Dummy_Unit_Var
    • Unit - Order CL_Dummy_Unit_Var to Human Priest - Inner Fire CL_Target
    • Unit - Add a 10.00 second Generic expiration timer to CL_Dummy_Unit_Var
    • -------- -------- --------
    • -------- Applying the Special Effects to the dummy unit --------
    • -------- -------- --------
    • Special Effect - Create a special effect attached to the origin of CL_Target using CL_Ground_Special_Effect
    • Special Effect - Destroy (Last created special effect)
    • Special Effect - Create a special effect at CL_Point using CL_Special_Effect
    • Special Effect - Destroy (Last created special effect)
    • Trigger - Run Cursed Lightning Damage <gen> (checking conditions)

 

[doomhammer99]

check pyrogasm's post about dynamic indexing

 

[MyPad]

This needs an extensive rewrite, as recreating the spell so as to keep it in line with the envisioned mechanics is rather cumbersome.
There are logical flaws with the triggers and some unneeded variables, as well as the lack of configurability in the spell (affects allies as well?).

Some of the logical flaws have already been presented by Pyrogasm, and it is worth mentioning that the spell could actually benefit from some form of dynamic indexing, presented above as a link.

As a hint, these are the variables needed to be converted to arrays:

• CL_Caster
• CL_Group

As for the time being, this resource bundle shall be temporarily moved to Substandard.

Status:

• Substandard

 

[Jay-B]

Done! the spell trigger is rewrited and i removed some of the functions that create leaks and other flaws.