Creep Respawning System

[Wrda]

Why another Creep Spawning System? We already have lots of them, and this one doesn't even have anything special. Sorry buddy but this won't be approved since there are many of this type and as you said, very simple system. I could do this system in 10 minutes.

 

[Tasyen]

Systems should leak as less as possible.
After the Respawning I would have expected a clean off (hashtable inserts, location remove) and maybe an automatic readd to the respawn system.

 

[Zephyrius2412]

The system doesn't clean the hashtable because the creeps respawn infinitely. If it cleans the hashtable, the system can't retrieve the initial position of the creeps.

 

[Tasyen]

Then you missed to take over the custom value to the respawned creep.
Currently it respawns only 1 time.
Edit: Simply cause the new Creeps custom value is 0

 

[Zephyrius2412]

Oh yes, you are right.
Corrected.

 

[EdgeOfChaos]

• Unit - Set the custom value of (Picked unit) to CreepRespawn_CustomValue

This line would interfere with Unit Indexer systems, which most maps use. I would recommend using a unit indexer that is already on THW, and never edit custom value yourself, at least not in a system.

Also, you're leaking that group you made there. Either save it to a variable and destroy it, or use bj_wantDestroyGroup to destroy it. It only happens once so it's not a big deal, but 0 leaks is better than 1.

• Wait CreepRespawn_RespawnDelay seconds

Waits are not good to have because there are bugs related to them. Unfortunately the only good way to avoid Wait is to use vjass TimerUtils. I would really recommend learning vjass anyways though, as it will greatly increase your code quality.