Cranium Rush v1.0a

[Moderator]

15:57, 18th Dec 2012
Magtheridon96: Beautiful, but I'd recommend re-using one of the 3 special effect arrays for stage 1 because after stage 0 is over, they become useless. A fourth array is not needed.

 

[BUP]

You can +rep here!

 

[Losam]

Depends if you return me "+ rep" and if I like your spell.

 

[BUP]

There is a bug like reached the target pint but not changing stage,,it depends on the speed i guess

 

[Almia]

Review:
1.Use this auto flyer line:
[jass=]
if UnitAddAbility(myunit,'Amrf') and UnitRemoveAbility(myunit,'Amrf') then
endif[/code]
to decrease line
2.Creating sfx should be inside the Integer Loop(for loop integer my integer)
3.Leaks a location when creating a unit:
Position of triggering unit
4.special effect(not the model) should be an array.
5.remove the turn collision off/on because SetUnitX/Y ignores collision
6.you dont need to reset the height as i have mentioned before about the arc formula,because the arc automatically resets to zero.
7.Min distance should be configurable,or i suggest using my system GetUnitCollisionSize is much better.
This needs fix BUP

 

[BUP]

Max distance is configurable
try removing the resetting part and test it

 

[Almia]

Oh yeah,forgot that you are using indexer
uhmm i mean the min distance,the one w/ 120
Also read my review.

 

[BUP]

I don't understand no.2
I think the point in the cast trigger does not leak it is created at the variable point"CaRu_Target_Point" and I removed that after I finished using it.

4.special effect(not the model) should be an array.

You mean I should use only one variable with 1,2,3 arrays? instead of using 3 special effect variables
like this?

Instead Of Doing Like This

• Special Effect - Create a special effect attached to the CaRu_Attachment[1] of CaRu_Caster[CaRu_Current_Index] using CaRu_Effect_Model[1]
• Set CaRu_SE_1[CaRu_Current_Index] = (Last created special effect)
• Special Effect - Create a special effect attached to the CaRu_Attachment[2] of CaRu_Caster[CaRu_Current_Index] using CaRu_Effect_Model[2]
• Set CaRu_SE_2[CaRu_Current_Index] = (Last created special effect)
• Special Effect - Create a special effect attached to the CaRu_Attachment[3] of CaRu_Caster[CaRu_Current_Index] using CaRu_Effect_Model[3]
• Set CaRu_SE_3[CaRu_Current_Index] = (Last created special effect)

Should I do Like this?

• Special Effect - Create a special effect attached to the CaRu_Attachment[1] of CaRu_Caster[CaRu_Current_Index] using CaRu_Effect_Model[1]
• Set CaRu_SE[1] = (Last created special effect)
• Special Effect - Create a special effect attached to the CaRu_Attachment[2] of CaRu_Caster[CaRu_Current_Index] using CaRu_Effect_Model[2]
• Set CaRu_SE[2] = (Last created special effect)
• Special Effect - Create a special effect attached to the CaRu_Attachment[3] of CaRu_Caster[CaRu_Current_Index] using CaRu_Effect_Model[3]
• Set CaRu_SE[3] = (Last created special effect)

 

[doomhammer99]

damn right BUP
But if you want the code to be short
Here See This

Preview

• Custom script: set udg_CaRu_SE[1] = AddSpecialEffectTarget(CaRu_Effect_Model[1], CaRu_Caster[CaRu_Current_Index], CaRu_Attachment[1])
• Custom script: set udg_CaRu_SE[2] = AddSpecialEffectTarget(CaRu_Effect_Model[2], CaRu_Caster[CaRu_Current_Index], CaRu_Attachment[2])
• Custom script: set udg_CaRu_SE[3] = AddSpecialEffectTarget(CaRu_Effect_Model[3], CaRu_Caster[CaRu_Current_Index], CaRu_Attachment[3])

And you could destroy it easily like this.

• Custom script: call DestroyEffect(udg_CaRu_SE[1])
• Custom script: call DestroyEffect(udg_CaRu_SE[2])
• Custom script: call DestroyEffect(udg_CaRu_SE[3])

 

[BUP]

The Special effect are not destroyed when it is cast two times

 

[Almia]

oh sorry


well this is much better:

• For integer Integer,from 1 to Max
  • Loop-Actions
    • Create SFX
    • Set SFX[Integer] = Last Created SFX

Just like that
Then cache it to an indexed variable

 

[Losam]

I tested and liked his spell (despite the leaks, the rest is approved). Furthermore, I give you 5/5 (or the maximum of hating)

 

[BUP]

If u want to rate don't just rate in your comment please actually rate it

 

[BUP]

I got this spell in one-shot but I will update with Radamantus advice

 

[McDc]

you should check if the target unit dies - if the unit dies while you are charging him he just stops and keeps spining there awkwardly :>.A nice spell

 

[BUP]

That condition is already added,only Resetting animation action is needed.But It's OK.All special effects are removed.

 

[BUP]

The condition is already included

 

[FUJI]

you don't need stage 2 because you can deindex or recycle them already in the else block of stage 1 but i think there's no harm or issue with that so nice spell ^^.

 

[GywGod133]

AH GOOD... USEFUL FOR MY RPG MAP Thanks for this

 

[BUP]

AH GOOD... USEFUL FOR MY RPG MAP Thanks for this

Make yourself useful with this