[JASS] count players controlled by a user

[deathismyfriend]

what is the best way to count players tht r playing ?

basically i just want to do set Players_Playing = ( number of user controlled players playing )

thx to anyone tht helps

 

[SeriousEnemy]

I know two ways.
1. Use the ugly bj function (or the blizzard script itself)

set i = CountPlayersInForceBJ(GetPlayersByMapControl(MAP_CONTROL_USER))

.j

function CountPlayersInForceEnum takes nothing returns nothing
     set bj_forceCountPlayers = bj_forceCountPlayers + 1
 endfunction 
 function CountPlayersInForceBJ takes force f returns integer
     set bj_forceCountPlayers = 0
     call ForForce(f, function CountPlayersInForceEnum)
     return bj_forceCountPlayers
 endfunction

2. Or use a loop for all player numbers and check if the player is controlled by user (this is how I do it)

 

[deathismyfriend]

isnt the bottom the same way as the top lol u just wrote everything out

 

[SeriousEnemy]

isnt the bottom the same way as the top lol u just wrote everything out

One way uses player groups, the other uses a loop checking for every player.
But basicly it's pretty much the same.
And the hidden trigger is just how to remove the bj.

 

[Cokemonkey11]

Hi, you should not use BJ functions, and you should use camelCase for variable names.

Also, you probably want to check the player's slot state in addition to his controller.

scope example initializer i
    globals
        private integer playersPlaying=0
    endglobals
    
    private function i takes nothing returns nothing
        local integer index=0
        loop
            exitwhen index>11
            if GetPlayerSlotState(Player(index))==PLAYER_SLOT_STATE_PLAYING and GetPlayerController(Player(index))==MAP_CONTROL_USER then
                set playersPlaying=playersPlaying+1
            endif
            set index=index+1
        endloop
    endfunction
endscope

This is a vJass example but it can be easily adapted to jass.

 

[deathismyfriend]

i use vjass anyways so tht is fine and as for camelCase i just always caps mine like Players_Playing never thought of it as a big deal ? and i dont use bjs

 

[Cokemonkey11]

Hi, camelCase is convention. You aren't obligated to use it, but you probably are if you submit a resource publicly.

 

[deathismyfriend]

ok lol doubt ill ever submit a resource or anything i just find it harder to read everything without the spaces in it i might switch it over tho who knows lol