Concatenation Errors

[khamarr3524]

[Solved] Concatenation Errors

For some reason this line of code is giving me a bunch of bad operators. Any reasons. It's obviously the concatenation, but I followed syntax didn't i? call DisplayTimedTextToPlayer(recP, 0., 0., 8.5,("(Allies): " + PCOLOR[pnum] + GetPlayerName(p) + ": " + s + "|r"))

Edit: I'm so sorry for the wasted post. I checked over the coding again, and I forgot to do COLOR[PCOLOR[pnum]], Doing what I did before was causing the code to supply an integer. My apologies.

 

[Dr Super Good]

JASS does not automatically type cast to string. A major annoyance, especially if you are used to languages like Java which does.

 

[khamarr3524]

I'm in the process of making a vJass Customizable Chat System. One that you can pick sections of the system to use, and customize, however I have hardly ever used String based systems and so concatenation and SubStrings are being learned as I work ; ). I'm sure once I get the hang of it, the system will be clean, efficient and more so helpful to others who may want a system like this.

 

[Dr Super Good]

Be aware that every unique string you create leaks permanently as WarCraft III does not undergo any form of string garbage collection. People have said that after enough time it will randomly do one but they have never given evidence to prove it.

 

[khamarr3524]

All strings being used are stored to locals, used, nulled, and the system works very efficiently, as of now, and does not leak yet. However I do have a question. If I call say: SubString("Red", 0, 4) will it return "Red " with one space, or is the space cut off. This is very important for me to know.

 

[Dr Super Good]

All strings being used are stored to locals, used, nulled,

This has what to do with string leaks exactly?

Once a string has been created (via any means) it will exist until the end of the session even if no references exist to it.

will it return "Red " with one space, or is the space cut off. This is very important for me to know.

I suspect it will return just "Red" as there are no other characters to use so adding extra characters would be illogical.

 

[khamarr3524]

I was certain there was a way to clear the entered string so that after it is entered it was like it didn't exist. Is this only with entered string, or if I create a local string, even if I null that string, it stays in the memory for the remainder of the game?

 

[Dr Super Good]

Once a string has been created (via any means) it will exist until the end of the session even if no references exist to it.

If you do not believe me, make a trigger than counts from 0 upwards while printing each number (thus creating a unqiue string). You will be able to see the memory usage of WC3 rise during this and if it is done fast enough you will even start to get frame skipping after enough leaks have occured.

 

[khamarr3524]

What is the reason for this? If the data is being stored into the system, doesn't that mean we should be able to get the string and remove it? I don't see why blizzard would design a system like this.

 

[Dr Super Good]

What is the reason for this? If the data is being stored into the system, doesn't that mean we should be able to get the string and remove it? I don't see why blizzard would design a system like this.

It is due to the strange way of storing strings that they use. Every string is given a unqiue reference and string comparisons are done by reference. When you create new strings, the contense is created locally, hashed and then checked to see if an entry for it exists in the string table. If it does then the string number for the entry is returned else it will add the entry to the hashtable and assign it a string number which is then returned.

I am not sure if strings even get reference counted. If not then there is no way to perform a garbage collection on the string system.

 

[khamarr3524]

By the way, you never answered my question. If I "overshoot" in substrings, does it add spaces?

 

[Dr Super Good]

I suspect it will return just "Red" as there are no other characters to use so adding extra characters would be illogical.

I am reasonably sure that is the answer. I have not used JASS that often recently so there is some doubts. Do a quick test if you want to be absolutly certain.

 

[khamarr3524]

No Spaces are added at all. Thanks for your help! Now I have a (somewhat) finished system to debug because it won't work.